# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit} 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b already have revision, skipping fetch # git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # git clean -qxdf # < git log -1 # commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # Author: Linus Torvalds # Date: Wed Aug 15 19:08:10 2018 -0700 # # ALSA: update dell-wmi mic-mute registration to new world order # # Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED # controls") changed the return value of the snd_hda_gen_add_micmute_led() # without actually updating the callers. # # Admittedly, almost no callers actually cared about the return value. # But one call site very much did: the Dell wmi code. It would see the # registration return zero, which _used_ to mean "failed" but now means # "success", and clear the dell_micmute_led_set_func pointer. # # End result: the successful registration would end up calling the Dell # code that thought it had all failed, and call through a NULL pointer. # # To make matters worse, it ends up being a tail-call, and with the # retpoline sequence you don't even see the caller (dell_micmute_update()) # in the stack trace, so the error ended up way less obvious than it # should have been. # # Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls" # Cc: Takashi Iwai # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # < make -s -j 40 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- randconfig KCONFIG_SEED=0x96EF91D0 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # make -s -j 40 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- olddefconfig # make -s -j 40 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- In file included from /kisskb/src/include/linux/bitmap.h:9, from /kisskb/src/include/linux/cpumask.h:12, from /kisskb/src/arch/x86/include/asm/cpumask.h:5, from /kisskb/src/arch/x86/include/asm/msr.h:11, from /kisskb/src/arch/x86/include/asm/processor.h:21, from /kisskb/src/arch/x86/include/asm/cpufeature.h:5, from /kisskb/src/arch/x86/include/asm/thread_info.h:53, from /kisskb/src/include/linux/thread_info.h:38, from /kisskb/src/arch/x86/include/asm/preempt.h:7, from /kisskb/src/include/linux/preempt.h:81, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/hfsplus/hfsplus_fs.h:20, from /kisskb/src/fs/hfsplus/xattr.c:10: In function 'strncpy', inlined from 'copy_name' at /kisskb/src/fs/hfsplus/xattr.c:416:3: /kisskb/src/include/linux/string.h:246:9: warning: '__builtin_strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c: In function 'amdgpu_bo_do_create': /kisskb/src/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:476:2: warning: #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance thanks to write-combining [-Wcpp] #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \ ^~~~~~~ /kisskb/src/lib/ubsan.c:432:1: warning: ignoring attribute 'noreturn' in declaration of a built-in function '__ubsan_handle_builtin_unreachable' because it conflicts with attribute 'const' [-Wattributes] { ^ : note: previous declaration here In file included from /kisskb/src/include/linux/bitmap.h:9, from /kisskb/src/include/linux/cpumask.h:12, from /kisskb/src/arch/x86/include/asm/cpumask.h:5, from /kisskb/src/arch/x86/include/asm/msr.h:11, from /kisskb/src/arch/x86/include/asm/processor.h:21, from /kisskb/src/arch/x86/include/asm/cpufeature.h:5, from /kisskb/src/arch/x86/include/asm/thread_info.h:53, from /kisskb/src/include/linux/thread_info.h:38, from /kisskb/src/arch/x86/include/asm/preempt.h:7, from /kisskb/src/include/linux/preempt.h:81, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/mmzone.h:8, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/drivers/target/iscsi/iscsi_target_tpg.c:19: In function 'strncat', inlined from 'iscsit_ta_authentication' at /kisskb/src/drivers/target/iscsi/iscsi_target_tpg.c:639:3: /kisskb/src/include/linux/string.h:313:10: warning: '__builtin_strncat' specified bound 1 equals source length [-Wstringop-overflow=] return __builtin_strncat(p, q, count); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'strncat', inlined from 'iscsit_ta_authentication' at /kisskb/src/drivers/target/iscsi/iscsi_target_tpg.c:640:3: /kisskb/src/include/linux/string.h:313:10: warning: '__builtin_strncat' specified bound 4 equals source length [-Wstringop-overflow=] return __builtin_strncat(p, q, count); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ERROR: "__sanitizer_cov_trace_cmpd" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! ERROR: "__sanitizer_cov_trace_cmpf" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! /kisskb/src/scripts/Makefile.modpost:92: recipe for target '__modpost' failed make[2]: *** [__modpost] Error 1 /kisskb/src/Makefile:1216: recipe for target 'modules' failed make[1]: *** [modules] Error 2 make[1]: *** Waiting for unfinished jobs.... Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 40 ARCH=x86_64 O=/kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_x86_64-randconfig_x86_64-gcc8 # Build took: 0:02:17.965385