# git rev-parse -q --verify 17adceb5b3e37c894ee5f36814b4e1a3fb603e0d^{commit} 17adceb5b3e37c894ee5f36814b4e1a3fb603e0d already have revision, skipping fetch # git checkout -q -f -B kisskb 17adceb5b3e37c894ee5f36814b4e1a3fb603e0d # git clean -qxdf # < git log -1 # commit 17adceb5b3e37c894ee5f36814b4e1a3fb603e0d # Author: Christophe Lombard # Date: Tue Aug 14 14:45:15 2018 +0200 # # ocxl: Fix access to the AFU Descriptor Data # # The AFU Information DVSEC capability is a means to extract common, # general information about all of the AFUs associated with a Function # independent of the specific functionality that each AFU provides. # Write in the AFU Index field allows to access to the descriptor data # for each AFU. # # With the current code, we are not able to access to these specific data # when the index >= 1 because we are writing to the wrong location. # All requests to the data of each AFU are pointing to those of the AFU 0, # which could have impacts when using a card with more than one AFU per # function. # # This patch fixes the access to the AFU Descriptor Data indexed by the # AFU Info Index field. # # Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") # Cc: stable # 4.16 # Signed-off-by: Christophe Lombard # # Acked-by: Frederic Barrat # Acked-by: Andrew Donnellan # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 17adceb5b3e37c894ee5f36814b4e1a3fb603e0d # < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64_book3e_allmodconfig # make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. In file included from /kisskb/src/drivers/net/ethernet/aurora/nb8800.c:40:0: /kisskb/src/drivers/net/ethernet/aurora/nb8800.h:92:0: warning: "TCR_DIE" redefined #define TCR_DIE BIT(7) ^ In file included from /kisskb/src/arch/powerpc/include/asm/reg.h:21:0, from /kisskb/src/arch/powerpc/include/asm/processor.h:13, from /kisskb/src/arch/powerpc/include/asm/thread_info.h:28, from /kisskb/src/include/linux/thread_info.h:38, from /kisskb/src/include/asm-generic/preempt.h:5, from ./arch/powerpc/include/generated/asm/preempt.h:1, from /kisskb/src/include/linux/preempt.h:81, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/drivers/net/ethernet/aurora/nb8800.c:23: /kisskb/src/arch/powerpc/include/asm/reg_booke.h:554:0: note: this is the location of the previous definition #define TCR_DIE TCR_PIE /* DEC Interrupt Enable */ ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c: In function 'usb_otg_start': /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:865:3: error: '_fsl_readl' undeclared (first use in this function) _fsl_readl = _fsl_readl_be; ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:865:3: note: each undeclared identifier is reported only once for each function it appears in /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:865:16: error: '_fsl_readl_be' undeclared (first use in this function) _fsl_readl = _fsl_readl_be; ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:866:3: error: '_fsl_writel' undeclared (first use in this function) _fsl_writel = _fsl_writel_be; ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:866:17: error: '_fsl_writel_be' undeclared (first use in this function) _fsl_writel = _fsl_writel_be; ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:868:16: error: '_fsl_readl_le' undeclared (first use in this function) _fsl_readl = _fsl_readl_le; ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:869:17: error: '_fsl_writel_le' undeclared (first use in this function) _fsl_writel = _fsl_writel_le; ^ In file included from /kisskb/src/include/linux/kobject.h:20:0, from /kisskb/src/include/linux/module.h:17, from /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:11: /kisskb/src/drivers/usb/phy/phy-fsl-usb.c: At top level: /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:1042:49: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] static DEVICE_ATTR(fsl_usb2_otg_state, S_IRUGO, show_fsl_usb2_otg_state, NULL); ^ /kisskb/src/include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR' .show = _show, \ ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:1042:8: note: in expansion of macro 'DEVICE_ATTR' static DEVICE_ATTR(fsl_usb2_otg_state, S_IRUGO, show_fsl_usb2_otg_state, NULL); ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:1042:49: note: (near initialization for 'dev_attr_fsl_usb2_otg_state.show') static DEVICE_ATTR(fsl_usb2_otg_state, S_IRUGO, show_fsl_usb2_otg_state, NULL); ^ /kisskb/src/include/linux/sysfs.h:104:10: note: in definition of macro '__ATTR' .show = _show, \ ^ /kisskb/src/drivers/usb/phy/phy-fsl-usb.c:1042:8: note: in expansion of macro 'DEVICE_ATTR' static DEVICE_ATTR(fsl_usb2_otg_state, S_IRUGO, show_fsl_usb2_otg_state, NULL); ^ cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:317: recipe for target 'drivers/usb/phy/phy-fsl-usb.o' failed make[4]: *** [drivers/usb/phy/phy-fsl-usb.o] Error 1 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/scripts/Makefile.build:558: recipe for target 'drivers/usb/phy' failed make[3]: *** [drivers/usb/phy] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/scripts/Makefile.build:558: recipe for target 'drivers/usb' failed make[2]: *** [drivers/usb] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/Makefile:1034: recipe for target 'drivers' failed make[1]: *** [drivers] Error 2 Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-5.3 # Build took: 0:10:36.422513