# git rev-parse -q --verify 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3^{commit} 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 already have revision, skipping fetch # git checkout -q -f -B kisskb 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 # git clean -qxdf # < git log -1 # commit 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 # Author: Michael Neuling # Date: Fri Sep 14 11:14:11 2018 +1000 # # powerpc: Avoid code patching freed init sections # # This stops us from doing code patching in init sections after they've # been freed. # # In this chain: # kvm_guest_init() -> # kvm_use_magic_page() -> # fault_in_pages_readable() -> # __get_user() -> # __get_user_nocheck() -> # barrier_nospec(); # # We have a code patching location at barrier_nospec() and # kvm_guest_init() is an init function. This whole chain gets inlined, # so when we free the init section (hence kvm_guest_init()), this code # goes away and hence should no longer be patched. # # We seen this as userspace memory corruption when using a memory # checker while doing partition migration testing on powervm (this # starts the code patching post migration via # /sys/kernel/mobility/migration). In theory, it could also happen when # using /sys/kernel/debug/powerpc/barrier_nospec. # # Cc: stable@vger.kernel.org # 4.13+ # Signed-off-by: Michael Neuling # Reviewed-by: Nicholas Piggin # Reviewed-by: Christophe Leroy # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 51c3c62b58b357e8d35e4cc32f7b4ec907426fe3 # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xDA211700 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c: In function 'soc15_set_ip_blocks': /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:532:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] # warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." ^ /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:551:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] # warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." ^ arch/powerpc/kvm/book3s_hv.o: In function `.kvmppc_run_core': book3s_hv.c:(.text+0x8780): undefined reference to `.radix__local_flush_tlb_lpid_guest' arch/powerpc/kvm/book3s_hv.o: In function `.kvmppc_pseries_do_hcall': (.text+0x9884): undefined reference to `.kvmppc_h_put_tce' (.text+0x98dc): undefined reference to `.kvmppc_h_put_tce_indirect' (.text+0x99f4): undefined reference to `.kvmppc_h_stuff_tce' arch/powerpc/kvm/book3s_64_mmu_radix.o: In function `.kvmppc_unmap_pte': book3s_64_mmu_radix.c:(.text+0x78): undefined reference to `.radix__flush_tlb_lpid_page' book3s_64_mmu_radix.c:(.text+0xc0): undefined reference to `.radix__flush_tlb_lpid_page' arch/powerpc/kvm/book3s_64_mmu_radix.o: In function `.kvmppc_book3s_radix_page_fault': (.text+0x171c): undefined reference to `.radix__flush_pwc_lpid' (.text+0x1768): undefined reference to `.radix__flush_pwc_lpid' arch/powerpc/kvm/book3s_64_mmu_radix.o: In function `.kvm_unmap_radix': (.text+0x1930): undefined reference to `.radix__flush_tlb_lpid_page' arch/powerpc/kvm/book3s_64_mmu_radix.o: In function `.kvmppc_hv_get_dirty_log_radix': (.text+0x1c08): undefined reference to `.radix__flush_tlb_lpid_page' arch/powerpc/kvm/book3s_hv_rmhandlers.o: In function `hcall_real_table': (.text+0x1584): undefined reference to `.kvmppc_h_get_tce' (.text+0x1588): undefined reference to `.kvmppc_rm_h_put_tce' (.text+0x16a0): undefined reference to `.kvmppc_rm_h_stuff_tce' (.text+0x16a4): undefined reference to `.kvmppc_rm_h_put_tce_indirect' make[1]: *** [/kisskb/src/Makefile:1040: vmlinux] Error 1 make: *** [Makefile:146: sub-make] Error 2 Command 'make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc-gcc5 # Build took: 0:04:03.112002