# git rev-parse -q --verify 2483ef056f6e42f61cd266452e2841165dfe1b5c^{commit} 2483ef056f6e42f61cd266452e2841165dfe1b5c already have revision, skipping fetch # git checkout -q -f -B kisskb 2483ef056f6e42f61cd266452e2841165dfe1b5c # git clean -qxdf # < git log -1 # commit 2483ef056f6e42f61cd266452e2841165dfe1b5c # Author: Srikar Dronamraju # Date: Tue Sep 25 17:55:15 2018 +0530 # # powerpc/numa: Use associativity if VPHN hcall is successful # # Currently associativity is used to lookup node-id even if the # preceding VPHN hcall failed. However this can cause CPU to be made # part of the wrong node, (most likely to be node 0). This is because # VPHN is not enabled on KVM guests. # # With 2ea6263 ("powerpc/topology: Get topology for shared processors at # boot"), associativity is used to set to the wrong node. Hence KVM # guest topology is broken. # # For example : A 4 node KVM guest before would have reported. # # [root@localhost ~]# numactl -H # available: 4 nodes (0-3) # node 0 cpus: 0 1 2 3 # node 0 size: 1746 MB # node 0 free: 1604 MB # node 1 cpus: 4 5 6 7 # node 1 size: 2044 MB # node 1 free: 1765 MB # node 2 cpus: 8 9 10 11 # node 2 size: 2044 MB # node 2 free: 1837 MB # node 3 cpus: 12 13 14 15 # node 3 size: 2044 MB # node 3 free: 1903 MB # node distances: # node 0 1 2 3 # 0: 10 40 40 40 # 1: 40 10 40 40 # 2: 40 40 10 40 # 3: 40 40 40 10 # # Would now report: # # [root@localhost ~]# numactl -H # available: 4 nodes (0-3) # node 0 cpus: 0 2 3 4 5 6 7 8 9 10 11 12 13 14 15 # node 0 size: 1746 MB # node 0 free: 1244 MB # node 1 cpus: # node 1 size: 2044 MB # node 1 free: 2032 MB # node 2 cpus: 1 # node 2 size: 2044 MB # node 2 free: 2028 MB # node 3 cpus: # node 3 size: 2044 MB # node 3 free: 2032 MB # node distances: # node 0 1 2 3 # 0: 10 40 40 40 # 1: 40 10 40 40 # 2: 40 40 10 40 # 3: 40 40 40 10 # # Fix this by skipping associativity lookup if the VPHN hcall failed. # # Fixes: 2ea626306810 ("powerpc/topology: Get topology for shared processors at boot") # Signed-off-by: Srikar Dronamraju # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 2483ef056f6e42f61cd266452e2841165dfe1b5c # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pseries_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_pseries_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/swap_state.c: In function '__add_to_swap_cache': /kisskb/src/mm/swap_state.c:135:5: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec': /kisskb/src/net/bridge/br_netlink.c:647:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:185:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2511:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1833:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2069:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1836:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1746:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/powerpc-fixes_pseries_defconfig_powerpc # Build took: 0:02:17.984177