# git rev-parse -q --verify 1d59e2c78793d8aea9949ca71323c4583c78f488^{commit} 1d59e2c78793d8aea9949ca71323c4583c78f488 already have revision, skipping fetch # git checkout -q -f -B kisskb 1d59e2c78793d8aea9949ca71323c4583c78f488 # git clean -qxdf # < git log -1 # commit 1d59e2c78793d8aea9949ca71323c4583c78f488 # Author: Dan Carpenter # Date: Mon Oct 1 19:44:58 2018 +0300 # # powerpc: signedness bug in update_flash_db() # # The "count < sizeof(struct os_area_db)" comparison is type promoted to # size_t so negative values of "count" are treated as very high values and # we accidentally return success instead of a negative error code. # # This doesn't really change runtime much but it fixes a static checker # warning. # # Signed-off-by: Dan Carpenter # Acked-by: Geoff Levand # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 1d59e2c78793d8aea9949ca71323c4583c78f488 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64le_allmodconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64le_allmodconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64le_allmodconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/scripts/unifdef.c: In function 'Mpass': /kisskb/src/scripts/unifdef.c:453:28: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); } ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:19, from /kisskb/src/arch/powerpc/include/asm/current.h:16, from /kisskb/src/include/linux/sched.h:12, from /kisskb/src/kernel/debug/kdb/kdb_support.c:15: In function 'strncpy', inlined from 'kallsyms_symbol_next' at /kisskb/src/kernel/debug/kdb/kdb_support.c:239:4: /kisskb/src/include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/kernel/debug/kdb/kdb_support.c: In function 'kallsyms_symbol_next': /kisskb/src/include/linux/string.h:267:10: note: length computed here return __builtin_strlen(p); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/crypto/internal/hash.h:17, from /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:12: /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c: In function 'crc_test_init': /kisskb/src/include/crypto/hash.h:155:38: warning: ISO C90 forbids variable length array '__crct10dif_shash_desc' [-Wvla] char __##shash##_desc[sizeof(struct shash_desc) + \ ^~~~~~~~~~ /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:59:3: note: in expansion of macro 'SHASH_DESC_ON_STACK' SHASH_DESC_ON_STACK(crct10dif_shash, crct10dif_tfm); ^~~~~~~~~~~~~~~~~~~ /kisskb/src/include/crypto/hash.h:155:38: warning: ISO C90 forbids variable length array '__crc32c_shash_desc' [-Wvla] char __##shash##_desc[sizeof(struct shash_desc) + \ ^~~~~~~~~~ /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:60:3: note: in expansion of macro 'SHASH_DESC_ON_STACK' SHASH_DESC_ON_STACK(crc32c_shash, crc32c_tfm); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/kvm_host.h:14, from /kisskb/src/arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:21: /kisskb/src/include/linux/signal.h: In function 'sigemptyset': /kisskb/src/include/linux/signal.h:180:22: warning: this statement may fall through [-Wimplicit-fallthrough=] case 2: set->sig[1] = 0; ~~~~~~~~~~~~^~~ /kisskb/src/include/linux/signal.h:181:2: note: here case 1: set->sig[0] = 0; ^~~~ /kisskb/src/arch/powerpc/kvm/book3s_32_mmu.c: In function 'kvmppc_mmu_book3s_32_xlate_pte': /kisskb/src/arch/powerpc/kvm/book3s_32_mmu.c:252:21: warning: this statement may fall through [-Wimplicit-fallthrough=] pte->may_write = true; ~~~~~~~~~~~~~~~^~~~~~ /kisskb/src/arch/powerpc/kvm/book3s_32_mmu.c:253:5: note: here case 3: ^~~~ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:19, from /kisskb/src/arch/powerpc/include/asm/hw_irq.h:64, from /kisskb/src/arch/powerpc/include/asm/irqflags.h:12, from /kisskb/src/include/linux/irqflags.h:16, from /kisskb/src/include/linux/spinlock.h:54, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/lib/test_hexdump.c:8: In function 'strncpy', inlined from 'test_hexdump_prepare_test.isra.0' at /kisskb/src/lib/test_hexdump.c:102:3: /kisskb/src/include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/lib/test_hexdump.c: In function 'test_hexdump_prepare_test.isra.0': /kisskb/src/include/linux/string.h:267:10: note: length computed here return __builtin_strlen(p); ^~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/scsi/esas2r/esas2r_ioctl.c: In function 'esas2r_write_vda': /kisskb/src/drivers/scsi/esas2r/esas2r_ioctl.c:1910:19: warning: 'dma_addr' may be used uninitialized in this function [-Wmaybe-uninitialized] a->ppvda_buffer = dma_addr; ~~~~~~~~~~~~~~~~^~~~~~~~~~ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:19, from /kisskb/src/arch/powerpc/include/asm/hw_irq.h:64, from /kisskb/src/arch/powerpc/include/asm/irqflags.h:12, from /kisskb/src/include/linux/irqflags.h:16, from /kisskb/src/include/linux/spinlock.h:54, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:27: In function 'strncat', inlined from 'ibmvscsis_probe' at /kisskb/src/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3478:2: /kisskb/src/include/linux/string.h:313:10: warning: '__builtin_strncat' specified bound 64 equals destination size [-Wstringop-overflow=] return __builtin_strncat(p, q, count); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ WARNING: vmlinux.o(.text+0x3774): Section mismatch in reference from the variable __boot_from_prom to the function .init.text:prom_init() The function __boot_from_prom() references the function __init prom_init(). This is often because __boot_from_prom lacks a __init annotation or the annotation of prom_init is wrong. WARNING: vmlinux.o(.text+0x3a44): Section mismatch in reference from the variable start_here_multiplatform to the function .init.text:early_setup() The function start_here_multiplatform() references the function __init early_setup(). This is often because start_here_multiplatform lacks a __init annotation or the annotation of early_setup is wrong. WARNING: vmlinux.o(.text+0x3a78): Section mismatch in reference from the variable start_here_common to the function .init.text:start_kernel() The function start_here_common() references the function __init start_kernel(). This is often because start_here_common lacks a __init annotation or the annotation of start_kernel is wrong. /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'. /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'. /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'. Completed OK # rm -rf /kisskb/build/powerpc-next_ppc64le_allmodconfig_powerpc-gcc8 # Build took: 0:04:57.063168