# git rev-parse -q --verify 1d59e2c78793d8aea9949ca71323c4583c78f488^{commit} 1d59e2c78793d8aea9949ca71323c4583c78f488 already have revision, skipping fetch # git checkout -q -f -B kisskb 1d59e2c78793d8aea9949ca71323c4583c78f488 # git clean -qxdf # < git log -1 # commit 1d59e2c78793d8aea9949ca71323c4583c78f488 # Author: Dan Carpenter # Date: Mon Oct 1 19:44:58 2018 +0300 # # powerpc: signedness bug in update_flash_db() # # The "count < sizeof(struct os_area_db)" comparison is type promoted to # size_t so negative values of "count" are treated as very high values and # we accidentally return success instead of a negative error code. # # This doesn't really change runtime much but it fixes a static checker # warning. # # Signed-off-by: Dan Carpenter # Acked-by: Geoff Levand # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 1d59e2c78793d8aea9949ca71323c4583c78f488 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- corenet64_smp_defconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/arch/powerpc/kernel/signal_32.c:32: /kisskb/src/include/linux/compat.h: In function 'put_compat_sigset': /kisskb/src/include/linux/compat.h:494:51: error: this statement may fall through [-Werror=implicit-fallthrough=] case 4: v.sig[7] = (set->sig[3] >> 32); v.sig[6] = set->sig[3]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:495:2: note: here case 3: v.sig[5] = (set->sig[2] >> 32); v.sig[4] = set->sig[2]; ^~~~ /kisskb/src/include/linux/compat.h:495:51: error: this statement may fall through [-Werror=implicit-fallthrough=] case 3: v.sig[5] = (set->sig[2] >> 32); v.sig[4] = set->sig[2]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:496:2: note: here case 2: v.sig[3] = (set->sig[1] >> 32); v.sig[2] = set->sig[1]; ^~~~ /kisskb/src/include/linux/compat.h:496:51: error: this statement may fall through [-Werror=implicit-fallthrough=] case 2: v.sig[3] = (set->sig[1] >> 32); v.sig[2] = set->sig[1]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:497:2: note: here case 1: v.sig[1] = (set->sig[0] >> 32); v.sig[0] = set->sig[0]; ^~~~ cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:305: arch/powerpc/kernel/signal_32.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:546: arch/powerpc/kernel] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1060: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/net/core/rtnetlink.c: In function 'rtnl_newlink': /kisskb/src/net/core/rtnetlink.c:3152:1: warning: the frame size of 1248 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ make: *** [Makefile:146: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_corenet64_smp_defconfig_powerpc-gcc8 # Build took: 0:00:33.301737