# git rev-parse -q --verify 1d59e2c78793d8aea9949ca71323c4583c78f488^{commit} 1d59e2c78793d8aea9949ca71323c4583c78f488 already have revision, skipping fetch # git checkout -q -f -B kisskb 1d59e2c78793d8aea9949ca71323c4583c78f488 # git clean -qxdf # < git log -1 # commit 1d59e2c78793d8aea9949ca71323c4583c78f488 # Author: Dan Carpenter # Date: Mon Oct 1 19:44:58 2018 +0300 # # powerpc: signedness bug in update_flash_db() # # The "count < sizeof(struct os_area_db)" comparison is type promoted to # size_t so negative values of "count" are treated as very high values and # we accidentally return success instead of a negative error code. # # This doesn't really change runtime much but it fixes a static checker # warning. # # Signed-off-by: Dan Carpenter # Acked-by: Geoff Levand # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 1d59e2c78793d8aea9949ca71323c4583c78f488 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64_book3e_allmodconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/scripts/unifdef.c: In function 'Mpass': /kisskb/src/scripts/unifdef.c:453:28: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); } ^~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/kvm_host.h:14, from /kisskb/src/arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:21: /kisskb/src/include/linux/signal.h: In function 'sigemptyset': /kisskb/src/include/linux/signal.h:180:22: warning: this statement may fall through [-Wimplicit-fallthrough=] case 2: set->sig[1] = 0; ~~~~~~~~~~~~^~~ /kisskb/src/include/linux/signal.h:181:2: note: here case 1: set->sig[0] = 0; ^~~~ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:19, from /kisskb/src/arch/powerpc/include/asm/current.h:16, from /kisskb/src/include/linux/sched.h:12, from /kisskb/src/kernel/debug/kdb/kdb_support.c:15: In function 'strncpy', inlined from 'kallsyms_symbol_next' at /kisskb/src/kernel/debug/kdb/kdb_support.c:239:4: /kisskb/src/include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/kernel/debug/kdb/kdb_support.c: In function 'kallsyms_symbol_next': /kisskb/src/include/linux/string.h:267:10: note: length computed here return __builtin_strlen(p); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/arch/powerpc/kernel/signal_32.c:32: /kisskb/src/include/linux/compat.h: In function 'put_compat_sigset': /kisskb/src/include/linux/compat.h:494:51: warning: this statement may fall through [-Wimplicit-fallthrough=] case 4: v.sig[7] = (set->sig[3] >> 32); v.sig[6] = set->sig[3]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:495:2: note: here case 3: v.sig[5] = (set->sig[2] >> 32); v.sig[4] = set->sig[2]; ^~~~ /kisskb/src/include/linux/compat.h:495:51: warning: this statement may fall through [-Wimplicit-fallthrough=] case 3: v.sig[5] = (set->sig[2] >> 32); v.sig[4] = set->sig[2]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:496:2: note: here case 2: v.sig[3] = (set->sig[1] >> 32); v.sig[2] = set->sig[1]; ^~~~ /kisskb/src/include/linux/compat.h:496:51: warning: this statement may fall through [-Wimplicit-fallthrough=] case 2: v.sig[3] = (set->sig[1] >> 32); v.sig[2] = set->sig[1]; ~~~~~~~~~^~~~~~~~~~~~~ /kisskb/src/include/linux/compat.h:497:2: note: here case 1: v.sig[1] = (set->sig[0] >> 32); v.sig[0] = set->sig[0]; ^~~~ In file included from /kisskb/src/include/crypto/internal/hash.h:17, from /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:12: /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c: In function 'crc_test_init': /kisskb/src/include/crypto/hash.h:155:38: warning: ISO C90 forbids variable length array '__crct10dif_shash_desc' [-Wvla] char __##shash##_desc[sizeof(struct shash_desc) + \ ^~~~~~~~~~ /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:59:3: note: in expansion of macro 'SHASH_DESC_ON_STACK' SHASH_DESC_ON_STACK(crct10dif_shash, crct10dif_tfm); ^~~~~~~~~~~~~~~~~~~ /kisskb/src/include/crypto/hash.h:155:38: warning: ISO C90 forbids variable length array '__crc32c_shash_desc' [-Wvla] char __##shash##_desc[sizeof(struct shash_desc) + \ ^~~~~~~~~~ /kisskb/src/arch/powerpc/crypto/crc-vpmsum_test.c:60:3: note: in expansion of macro 'SHASH_DESC_ON_STACK' SHASH_DESC_ON_STACK(crc32c_shash, crc32c_tfm); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:19, from /kisskb/src/arch/powerpc/include/asm/hw_irq.h:64, from /kisskb/src/arch/powerpc/include/asm/irqflags.h:12, from /kisskb/src/include/linux/irqflags.h:16, from /kisskb/src/include/linux/spinlock.h:54, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/lib/test_hexdump.c:8: In function 'strncpy', inlined from 'test_hexdump_prepare_test.isra.0' at /kisskb/src/lib/test_hexdump.c:102:3: /kisskb/src/include/linux/string.h:246:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/lib/test_hexdump.c: In function 'test_hexdump_prepare_test.isra.0': /kisskb/src/include/linux/string.h:267:10: note: length computed here return __builtin_strlen(p); ^~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/drivers/net/ethernet/aurora/nb8800.c:40: /kisskb/src/drivers/net/ethernet/aurora/nb8800.h:92: warning: "TCR_DIE" redefined #define TCR_DIE BIT(7) In file included from /kisskb/src/arch/powerpc/include/asm/reg.h:21, from /kisskb/src/arch/powerpc/include/asm/processor.h:13, from /kisskb/src/arch/powerpc/include/asm/thread_info.h:28, from /kisskb/src/include/linux/thread_info.h:38, from /kisskb/src/include/asm-generic/preempt.h:5, from ./arch/powerpc/include/generated/asm/preempt.h:1, from /kisskb/src/include/linux/preempt.h:81, from /kisskb/src/include/linux/spinlock.h:51, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/drivers/net/ethernet/aurora/nb8800.c:23: /kisskb/src/arch/powerpc/include/asm/reg_booke.h:554: note: this is the location of the previous definition #define TCR_DIE TCR_PIE /* DEC Interrupt Enable */ /kisskb/src/drivers/scsi/esas2r/esas2r_ioctl.c: In function 'esas2r_write_vda': /kisskb/src/drivers/scsi/esas2r/esas2r_ioctl.c:1910:19: warning: 'dma_addr' may be used uninitialized in this function [-Wmaybe-uninitialized] a->ppvda_buffer = dma_addr; ~~~~~~~~~~~~~~~~^~~~~~~~~~ /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'. drivers/usb/phy/phy-fsl-usb.o: In function `.fsl_otg_ioctl': phy-fsl-usb.c:(.text.fsl_otg_ioctl+0xb4): undefined reference to `.otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `.fsl_otg_start_srp': phy-fsl-usb.c:(.text.fsl_otg_start_srp+0x4c): undefined reference to `.otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `.fsl_otg_set_host': phy-fsl-usb.c:(.text.fsl_otg_set_host+0xd0): undefined reference to `.otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `.fsl_otg_start_hnp': phy-fsl-usb.c:(.text.fsl_otg_start_hnp+0x68): undefined reference to `.otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `.show_fsl_usb2_otg_state': phy-fsl-usb.c:(.text.show_fsl_usb2_otg_state+0x154): undefined reference to `.usb_otg_state_string' drivers/usb/phy/phy-fsl-usb.o: In function `.a_wait_enum': (.text.a_wait_enum+0x4c): undefined reference to `.otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `.fsl_otg_set_peripheral': phy-fsl-usb.c:(.text.fsl_otg_set_peripheral+0x84): undefined reference to `.usb_gadget_vbus_disconnect' phy-fsl-usb.c:(.text.fsl_otg_set_peripheral+0x9c): undefined reference to `.otg_statemachine' make[1]: *** [/kisskb/src/Makefile:1036: vmlinux] Error 1 make: *** [Makefile:146: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_ppc64_book3e_allmodconfig_powerpc-gcc8 # Build took: 0:03:40.592170