# git rev-parse -q --verify f0a7d1883d9f78ae7bf15fc258bf9a2b20f35b76^{commit}
f0a7d1883d9f78ae7bf15fc258bf9a2b20f35b76
already have revision, skipping fetch
# git checkout -q -f -B kisskb f0a7d1883d9f78ae7bf15fc258bf9a2b20f35b76
# git clean -qxdf
# < git log -1
# commit f0a7d1883d9f78ae7bf15fc258bf9a2b20f35b76
# Author: David Howells <dhowells@redhat.com>
# Date:   Mon Oct 15 12:43:02 2018 +0100
# 
#     afs: Fix clearance of reply
#     
#     The recent patch to fix the afs_server struct leak didn't actually fix the
#     bug, but rather fixed some of the symptoms.  The problem is that an
#     asynchronous call that holds a resource pointed to by call->reply[0] will
#     find the pointer cleared in the call destructor, thereby preventing the
#     resource from being cleaned up.
#     
#     In the case of the server record leak, the afs_fs_get_capabilities()
#     function in devel code sets up a call with reply[0] pointing at the server
#     record that should be altered when the result is obtained, but this was
#     being cleared before the destructor was called, so the put in the
#     destructor does nothing and the record is leaked.
#     
#     Commit f014ffb025c1 removed the additional ref obtained by
#     afs_install_server(), but the removal of this ref is actually used by the
#     garbage collector to mark a server record as being defunct after the record
#     has expired through lack of use.
#     
#     The offending clearance of call->reply[0] upon completion in
#     afs_process_async_call() has been there from the origin of the code, but
#     none of the asynchronous calls actually use that pointer currently, so it
#     should be safe to remove (note that synchronous calls don't involve this
#     function).
#     
#     Fix this by the following means:
#     
#      (1) Revert commit f014ffb025c1.
#     
#      (2) Remove the clearance of reply[0] from afs_process_async_call().
#     
#     Without this, afs_manage_servers() will suffer an assertion failure if it
#     sees a server record that didn't get used because the usage count is not 1.
#     
#     Fixes: f014ffb025c1 ("afs: Fix afs_server struct leak")
#     Fixes: 08e0e7c82eea ("[AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.")
#     Signed-off-by: David Howells <dhowells@redhat.com>
#     Cc: stable <stable@vger.kernel.org>
#     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version
# < git log --format=%s --max-count=1 f0a7d1883d9f78ae7bf15fc258bf9a2b20f35b76
# < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-  allnoconfig
# make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allnoconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-  
/kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:185:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
FIT description: Linux 4.19.0-rc8+
Created:         Tue Oct 16 03:43:30 2018
 Image 0 (kernel@0)
  Description:  Linux 4.19.0-rc8+
  Created:      Tue Oct 16 03:43:30 2018
  Type:         Kernel Image
  Compression:  gzip compressed
  Data Size:    658908 Bytes = 643.46 KiB = 0.63 MiB
  Architecture: MIPS
  OS:           Linux
  Load Address: 0x80100000
  Entry Point:  0x80227470
  Hash algo:    sha1
  Hash value:   c4994f6295d4520904b902a677faeef511161061
 Default Configuration: 'conf@default'
 Configuration 0 (conf@default)
  Description:  Generic Linux kernel
  Kernel:       kernel@0
Completed OK
# rm -rf /kisskb/build/linus_mips-allnoconfig_mips
# Build took: 0:00:13.315482