# git rev-parse -q --verify 69d5b97c597307773fe6c59775a5d5a88bb7e6b3^{commit}
69d5b97c597307773fe6c59775a5d5a88bb7e6b3
already have revision, skipping fetch
# git checkout -q -f -B kisskb 69d5b97c597307773fe6c59775a5d5a88bb7e6b3
# git clean -qxdf
# < git log -1
# commit 69d5b97c597307773fe6c59775a5d5a88bb7e6b3
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Sat Oct 27 11:03:27 2018 -0700
# 
#     HID: we do not randomly make new drivers 'default y'
#     
#     .. even when that "default y" is hidden syntactically as a
#     
#             default !EXPERT
#     
#     it's wrong.
#     
#     The only reason something should be 'default y' is if it used to be
#     built-in, and it was made configurable, and the 'default y' is just
#     retaining the status quo.
#     
#     Altheratively, the hardware for the driver has become _so_ common that
#     it really makes sense for everybody to build it.  Finally, one possible
#     reason for 'default y' is because the option is not enabling any new
#     code at all, but is just enabling other options (the networking people
#     do this for vendor options, for example, so that you can disable whole
#     vendors at a time).
#     
#     Clearly, none of these cases hold for the BigBen Interactive Kids'
#     gamepad, and HID_BIGBEN_FF should thus most definitely not default
#     to on for everybody.
#     
#     Cc: Hanno Zulla <kontakt@hanno.de>
#     Cc: Jiri Kosina <jkosina@suse.cz>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version
# < git log --format=%s --max-count=1 69d5b97c597307773fe6c59775a5d5a88bb7e6b3
# < make -s -j 48 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-  allmodconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# Added to kconfig CONFIG_SAMPLES=n
# yes \n | make -s -j 48 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-  oldconfig
yes: standard output: Broken pipe
# make -s -j 48 ARCH=x86 O=/kisskb/build/linus_x86-allmodconfig_x86_64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux-  
In file included from /kisskb/src/include/linux/bitmap.h:9,
                 from /kisskb/src/include/linux/cpumask.h:12,
                 from /kisskb/src/arch/x86/include/asm/paravirt.h:17,
                 from /kisskb/src/arch/x86/include/asm/irqflags.h:68,
                 from /kisskb/src/include/linux/irqflags.h:16,
                 from /kisskb/src/include/linux/rcupdate.h:39,
                 from /kisskb/src/include/linux/rculist.h:11,
                 from /kisskb/src/include/linux/pid.h:5,
                 from /kisskb/src/include/linux/sched.h:14,
                 from /kisskb/src/kernel/debug/kdb/kdb_support.c:15:
In function 'strncpy',
    inlined from 'kallsyms_symbol_next' at /kisskb/src/kernel/debug/kdb/kdb_support.c:239:4:
/kisskb/src/include/linux/string.h:253:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
  return __builtin_strncpy(p, q, size);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/kernel/debug/kdb/kdb_support.c: In function 'kallsyms_symbol_next':
/kisskb/src/include/linux/string.h:274:10: note: length computed here
   return __builtin_strlen(p);
          ^~~~~~~~~~~~~~~~~~~
/kisskb/src/lib/ubsan.c:432:1: warning: ignoring attribute 'noreturn' in declaration of a built-in function '__ubsan_handle_builtin_unreachable' because it conflicts with attribute 'const' [-Wattributes]
 {
 ^
<built-in>: note: previous declaration here
In file included from /kisskb/src/include/linux/bitmap.h:9,
                 from /kisskb/src/include/linux/cpumask.h:12,
                 from /kisskb/src/arch/x86/include/asm/cpumask.h:5,
                 from /kisskb/src/arch/x86/include/asm/msr.h:11,
                 from /kisskb/src/arch/x86/include/asm/processor.h:21,
                 from /kisskb/src/arch/x86/include/asm/cpufeature.h:8,
                 from /kisskb/src/arch/x86/include/asm/thread_info.h:53,
                 from /kisskb/src/include/linux/thread_info.h:38,
                 from /kisskb/src/arch/x86/include/asm/preempt.h:7,
                 from /kisskb/src/include/linux/preempt.h:81,
                 from /kisskb/src/include/linux/spinlock.h:51,
                 from /kisskb/src/include/linux/seqlock.h:36,
                 from /kisskb/src/include/linux/time.h:6,
                 from /kisskb/src/include/linux/stat.h:19,
                 from /kisskb/src/include/linux/module.h:10,
                 from /kisskb/src/lib/test_hexdump.c:8:
In function 'strncpy',
    inlined from 'test_hexdump_prepare_test.constprop' at /kisskb/src/lib/test_hexdump.c:102:3:
/kisskb/src/include/linux/string.h:253:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
  return __builtin_strncpy(p, q, size);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/lib/test_hexdump.c: In function 'test_hexdump_prepare_test.constprop':
/kisskb/src/include/linux/string.h:274:10: note: length computed here
   return __builtin_strlen(p);
          ^~~~~~~~~~~~~~~~~~~
/kisskb/src/scripts/unifdef.c: In function 'Mpass':
/kisskb/src/scripts/unifdef.c:453:28: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation]
 static void Mpass (void) { strncpy(keyword, "if  ", 4); Pelif(); }
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Completed OK
# rm -rf /kisskb/build/linus_x86-allmodconfig_x86_64-gcc8
# Build took: 0:19:39.738004