# git rev-parse -q --verify 69d5b97c597307773fe6c59775a5d5a88bb7e6b3^{commit} 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 already have revision, skipping fetch # git checkout -q -f -B kisskb 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # git clean -qxdf # < git log -1 # commit 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # Author: Linus Torvalds # Date: Sat Oct 27 11:03:27 2018 -0700 # # HID: we do not randomly make new drivers 'default y' # # .. even when that "default y" is hidden syntactically as a # # default !EXPERT # # it's wrong. # # The only reason something should be 'default y' is if it used to be # built-in, and it was made configurable, and the 'default y' is just # retaining the status quo. # # Altheratively, the hardware for the driver has become _so_ common that # it really makes sense for everybody to build it. Finally, one possible # reason for 'default y' is because the option is not enabling any new # code at all, but is just enabling other options (the networking people # do this for vendor options, for example, so that you can disable whole # vendors at a time). # # Clearly, none of these cases hold for the BigBen Interactive Kids' # gamepad, and HID_BIGBEN_FF should thus most definitely not default # to on for everybody. # # Cc: Hanno Zulla # Cc: Jiri Kosina # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < git log --format=%s --max-count=1 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # < make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- m5272c3_defconfig # make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- :1239:2: warning: #warning syscall seccomp not implemented [-Wcpp] :1317:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1320:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1323:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_restart': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:912:6: warning: unused variable 'val' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_get_mac': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:1640:28: warning: unused variable 'pdata' [-Wunused-variable] /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/net/core/filter.c:3304:4: warning: value computed is not used [-Wunused-value] Completed OK # rm -rf /kisskb/build/linus_m5272c3_defconfig_m68k # Build took: 0:00:22.038404