# git rev-parse -q --verify 69d5b97c597307773fe6c59775a5d5a88bb7e6b3^{commit} 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 already have revision, skipping fetch # git checkout -q -f -B kisskb 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # git clean -qxdf # < git log -1 # commit 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # Author: Linus Torvalds # Date: Sat Oct 27 11:03:27 2018 -0700 # # HID: we do not randomly make new drivers 'default y' # # .. even when that "default y" is hidden syntactically as a # # default !EXPERT # # it's wrong. # # The only reason something should be 'default y' is if it used to be # built-in, and it was made configurable, and the 'default y' is just # retaining the status quo. # # Altheratively, the hardware for the driver has become _so_ common that # it really makes sense for everybody to build it. Finally, one possible # reason for 'default y' is because the option is not enabling any new # code at all, but is just enabling other options (the networking people # do this for vendor options, for example, so that you can disable whole # vendors at a time). # # Clearly, none of these cases hold for the BigBen Interactive Kids' # gamepad, and HID_BIGBEN_FF should thus most definitely not default # to on for everybody. # # Cc: Hanno Zulla # Cc: Jiri Kosina # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version # < git log --format=%s --max-count=1 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # < make -s -j 80 ARCH=um O=/kisskb/build/linus_um-defconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 defconfig # make -s -j 80 ARCH=um O=/kisskb/build/linus_um-defconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/scripts/unifdef.c: In function 'Mpass': /kisskb/src/scripts/unifdef.c:453:28: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); } ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/arch/um/os-Linux/skas/process.c: In function 'start_idle_thread': /kisskb/src/arch/um/os-Linux/skas/process.c:613:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ /kisskb/src/net/core/rtnetlink.c: In function 'rtnl_newlink': /kisskb/src/net/core/rtnetlink.c:3224:1: warning: the frame size of 1296 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ LINK linux Completed OK # rm -rf /kisskb/build/linus_um-defconfig_um-x86_64 # Build took: 0:00:46.995250