# git rev-parse -q --verify 69d5b97c597307773fe6c59775a5d5a88bb7e6b3^{commit} 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 already have revision, skipping fetch # git checkout -q -f -B kisskb 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # git clean -qxdf # < git log -1 # commit 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # Author: Linus Torvalds # Date: Sat Oct 27 11:03:27 2018 -0700 # # HID: we do not randomly make new drivers 'default y' # # .. even when that "default y" is hidden syntactically as a # # default !EXPERT # # it's wrong. # # The only reason something should be 'default y' is if it used to be # built-in, and it was made configurable, and the 'default y' is just # retaining the status quo. # # Altheratively, the hardware for the driver has become _so_ common that # it really makes sense for everybody to build it. Finally, one possible # reason for 'default y' is because the option is not enabling any new # code at all, but is just enabling other options (the networking people # do this for vendor options, for example, so that you can disable whole # vendors at a time). # # Clearly, none of these cases hold for the BigBen Interactive Kids' # gamepad, and HID_BIGBEN_FF should thus most definitely not default # to on for everybody. # # Cc: Hanno Zulla # Cc: Jiri Kosina # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux-gcc --version # < git log --format=%s --max-count=1 69d5b97c597307773fe6c59775a5d5a88bb7e6b3 # < make -s -j 48 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- a500_defconfig # make -s -j 48 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/arch/parisc/include/asm/atomic.h:10, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/arch/parisc/include/asm/bitops.h:13, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/drivers/scsi/scsi_debug.c:23: /kisskb/src/drivers/scsi/scsi_debug.c: In function 'resp_start_stop': /kisskb/src/arch/parisc/include/asm/cmpxchg.h:48:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))) /kisskb/src/arch/parisc/include/asm/atomic.h:78:30: note: in expansion of macro 'xchg' #define atomic_xchg(v, new) (xchg(&((v)->counter), new)) ^~~~ /kisskb/src/drivers/scsi/scsi_debug.c:1624:2: note: in expansion of macro 'atomic_xchg' atomic_xchg(&devip->stopped, stop); ^~~~~~~~~~~ /kisskb/src/scripts/unifdef.c: In function 'Mpass': /kisskb/src/scripts/unifdef.c:453:28: warning: 'strncpy' output truncated before terminating nul copying 4 bytes from a string of the same length [-Wstringop-truncation] static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); } ^~~~~~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_a500_defconfig_parisc64 # Build took: 0:01:21.976820