# git rev-parse -q --verify 66f93c5a02d5ba6ef17fef459143961382593212^{commit} 66f93c5a02d5ba6ef17fef459143961382593212 already have revision, skipping fetch # git checkout -q -f -B kisskb 66f93c5a02d5ba6ef17fef459143961382593212 # git clean -qxdf # < git log -1 # commit 66f93c5a02d5ba6ef17fef459143961382593212 # Author: Nicholas Piggin # Date: Thu Nov 15 12:34:27 2018 +1000 # # powerpc/64: Fix kernel stack 16-byte alignment # # Commit 4c2de74cc869 ("powerpc/64: Interrupts save PPR on stack rather # than thread_struct") changed sizeof(struct pt_regs) % 16 from 0 to 8, # which causes the interrupt frame allocation on kernel entry to put the # kernel stack out of alignment. # # Quadword (16-byte) alignment for the stack is required by both the # 64-bit v1 ABI (v1.9 § 3.2.2) and the 64-bit v2 ABI (v1.1 § 2.2.2.1). # # Add a pad field to fix alignment, and add a BUILD_BUG_ON to catch this # in future. # # Fixes: 4c2de74cc869 ("powerpc/64: Interrupts save PPR on stack rather than thread_struct") # Signed-off-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 66f93c5a02d5ba6ef17fef459143961382593212 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mpc885_ads_defconfig # Added to kconfig CONFIG_HUGETLBFS=y # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] Image Name: Linux-4.20.0-rc1-g66f93c5a02d5 Created: Thu Nov 15 20:57:59 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 1826860 Bytes = 1784.04 KiB = 1.74 MiB Load Address: 00400000 Entry Point: 004001e8 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc # Build took: 0:00:20.410186