Buildresult: linus/pasemi_defconfig/powerpc-gcc4.6 built on Jan 4 2019, 15:54

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Jan 4 2019, 15:54
Duration:	0:00:04.256118
Builder:	ka2
Revision:	Remove 'type' argument from access_ok() function (`96d4f267e40f9509e8a66e2b39e8b95655617693)`
Target:	linus/pasemi_defconfig/powerpc-gcc4.6
Branch:	linus
Compiler:	powerpc-gcc4.6 (powerpc-linux-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	pasemi_defconfig (download)
Log:	Download original Possible errors arch/powerpc/include/asm/uaccess.h:377:6: error: 'type' undeclared (first use in this function) include/linux/uaccess.h:160:6: error: 'type' undeclared (first use in this function) make[2]: * [scripts/Makefile.build:110: arch/powerpc/kernel/asm-offsets.s] Error 1 make[1]: * [Makefile:1100: prepare0] Error 2 make: * [Makefile:152: sub-make] Error 2 Possible warnings (3) arch/powerpc/include/asm/uaccess.h:377:6: warning: left-hand operand of comma expression has no effect [-Wunused-value] include/linux/uaccess.h:160:6: warning: left-hand operand of comma expression has no effect [-Wunused-value] include/linux/uaccess.h:160:26: warning: left-hand operand of comma expression has no effect [-Wunused-value] Full Log # git rev-parse -q --verify 96d4f267e40f9509e8a66e2b39e8b95655617693^{commit} 96d4f267e40f9509e8a66e2b39e8b95655617693 already have revision, skipping fetch # git checkout -q -f -B kisskb 96d4f267e40f9509e8a66e2b39e8b95655617693 # git clean -qxdf # < git log -1 # commit 96d4f267e40f9509e8a66e2b39e8b95655617693 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Thu Jan 3 18:57:57 2019 -0800 # # Remove 'type' argument from access_ok() function # # Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument # of the user address range verification function since we got rid of the # old racy i386-only code to walk page tables by hand. # # It existed because the original 80386 would not honor the write protect # bit when in kernel mode, so you had to do COW by hand before doing any # user access. But we haven't supported that in a long time, and these # days the 'type' argument is a purely historical artifact. # # A discussion about extending 'user_access_begin()' to do the range # checking resulted this patch, because there is no way we're going to # move the old VERIFY_xyz interface to that model. And it's best done at # the end of the merge window when I've done most of my merges, so let's # just get this done once and for all. # # This patch was mostly done with a sed-script, with manual fix-ups for # the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form. # # There were a couple of notable cases: # # - csky still had the old "verify_area()" name as an alias. # # - the iter_iov code had magical hardcoded knowledge of the actual # values of VERIFY_{READ,WRITE} (not that they mattered, since nothing # really used it) # # - microblaze used the type argument for a debug printout # # but other than those oddities this should be a total no-op patch. # # I tried to fix up all architectures, did fairly extensive grepping for # access_ok() uses, and the changes are trivial, but I may have missed # something. Any missed conversion should be trivially fixable, though. # # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 96d4f267e40f9509e8a66e2b39e8b95655617693 # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pasemi_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pasemi_defconfig # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pasemi_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- In file included from /kisskb/src/include/linux/uaccess.h:11:0, from /kisskb/src/include/linux/crypto.h:26, from /kisskb/src/include/crypto/hash.h:16, from /kisskb/src/include/linux/uio.h:14, from /kisskb/src/include/linux/socket.h:8, from /kisskb/src/include/linux/compat.h:15, from /kisskb/src/arch/powerpc/kernel/asm-offsets.c:16: /kisskb/src/arch/powerpc/include/asm/uaccess.h: In function 'clear_user': /kisskb/src/arch/powerpc/include/asm/uaccess.h:377:6: error: 'type' undeclared (first use in this function) /kisskb/src/arch/powerpc/include/asm/uaccess.h:377:6: note: each undeclared identifier is reported only once for each function it appears in /kisskb/src/arch/powerpc/include/asm/uaccess.h:377:6: warning: left-hand operand of comma expression has no effect [-Wunused-value] In file included from /kisskb/src/include/linux/crypto.h:26:0, from /kisskb/src/include/crypto/hash.h:16, from /kisskb/src/include/linux/uio.h:14, from /kisskb/src/include/linux/socket.h:8, from /kisskb/src/include/linux/compat.h:15, from /kisskb/src/arch/powerpc/kernel/asm-offsets.c:16: /kisskb/src/include/linux/uaccess.h: In function 'copy_in_user': /kisskb/src/include/linux/uaccess.h:160:6: error: 'type' undeclared (first use in this function) /kisskb/src/include/linux/uaccess.h:160:6: warning: left-hand operand of comma expression has no effect [-Wunused-value] /kisskb/src/include/linux/uaccess.h:160:26: warning: left-hand operand of comma expression has no effect [-Wunused-value] make[2]: * [/kisskb/src/scripts/Makefile.build:110: arch/powerpc/kernel/asm-offsets.s] Error 1 make[1]: * [/kisskb/src/Makefile:1100: prepare0] Error 2 make: * [Makefile:152: sub-make] Error 2 Command 'make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_pasemi_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_pasemi_defconfig_powerpc # Build took: 0:00:04.256118

© Michael Ellerman 2006-2018.