# git rev-parse -q --verify 96d4f267e40f9509e8a66e2b39e8b95655617693^{commit} 96d4f267e40f9509e8a66e2b39e8b95655617693 already have revision, skipping fetch # git checkout -q -f -B kisskb 96d4f267e40f9509e8a66e2b39e8b95655617693 # git clean -qxdf # < git log -1 # commit 96d4f267e40f9509e8a66e2b39e8b95655617693 # Author: Linus Torvalds # Date: Thu Jan 3 18:57:57 2019 -0800 # # Remove 'type' argument from access_ok() function # # Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument # of the user address range verification function since we got rid of the # old racy i386-only code to walk page tables by hand. # # It existed because the original 80386 would not honor the write protect # bit when in kernel mode, so you had to do COW by hand before doing any # user access. But we haven't supported that in a long time, and these # days the 'type' argument is a purely historical artifact. # # A discussion about extending 'user_access_begin()' to do the range # checking resulted this patch, because there is no way we're going to # move the old VERIFY_xyz interface to that model. And it's best done at # the end of the merge window when I've done most of my merges, so let's # just get this done once and for all. # # This patch was mostly done with a sed-script, with manual fix-ups for # the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form. # # There were a couple of notable cases: # # - csky still had the old "verify_area()" name as an alias. # # - the iter_iov code had magical hardcoded knowledge of the actual # values of VERIFY_{READ,WRITE} (not that they mattered, since nothing # really used it) # # - microblaze used the type argument for a debug printout # # but other than those oddities this should be a total no-op patch. # # I tried to fix up all architectures, did fairly extensive grepping for # access_ok() uses, and the changes are trivial, but I may have missed # something. Any missed conversion should be trivially fixable, though. # # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 96d4f267e40f9509e8a66e2b39e8b95655617693 # < make -s -j 10 ARCH=arm O=/kisskb/build/linus_ezx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- ezx_defconfig # make -s -j 10 ARCH=arm O=/kisskb/build/linus_ezx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:133:34: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:100:6: note: 'levelspread[]' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec': /kisskb/src/net/bridge/br_netlink.c:652:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c: In function '__ip6_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c:1270:14: note: 'extra_uref' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here Completed OK # rm -rf /kisskb/build/linus_ezx_defconfig_arm # Build took: 0:01:21.243917