# git rev-parse -q --verify 96d4f267e40f9509e8a66e2b39e8b95655617693^{commit} 96d4f267e40f9509e8a66e2b39e8b95655617693 already have revision, skipping fetch # git checkout -q -f -B kisskb 96d4f267e40f9509e8a66e2b39e8b95655617693 # git clean -qxdf # < git log -1 # commit 96d4f267e40f9509e8a66e2b39e8b95655617693 # Author: Linus Torvalds # Date: Thu Jan 3 18:57:57 2019 -0800 # # Remove 'type' argument from access_ok() function # # Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument # of the user address range verification function since we got rid of the # old racy i386-only code to walk page tables by hand. # # It existed because the original 80386 would not honor the write protect # bit when in kernel mode, so you had to do COW by hand before doing any # user access. But we haven't supported that in a long time, and these # days the 'type' argument is a purely historical artifact. # # A discussion about extending 'user_access_begin()' to do the range # checking resulted this patch, because there is no way we're going to # move the old VERIFY_xyz interface to that model. And it's best done at # the end of the merge window when I've done most of my merges, so let's # just get this done once and for all. # # This patch was mostly done with a sed-script, with manual fix-ups for # the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form. # # There were a couple of notable cases: # # - csky still had the old "verify_area()" name as an alias. # # - the iter_iov code had magical hardcoded knowledge of the actual # values of VERIFY_{READ,WRITE} (not that they mattered, since nothing # really used it) # # - microblaze used the type argument for a debug printout # # but other than those oddities this should be a total no-op patch. # # I tried to fix up all architectures, did fairly extensive grepping for # access_ok() uses, and the changes are trivial, but I may have missed # something. Any missed conversion should be trivially fixable, though. # # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 96d4f267e40f9509e8a66e2b39e8b95655617693 # < make -s -j 10 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 10 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/arch/mips/boot/dts/xilfpga/nexys4ddr.dts:109.16-112.8: Warning (i2c_bus_reg): /i2c@10A00000/ad7420@4B: I2C bus unit address format error, expected "4b" /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:152:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:100:6: note: 'levelspread[]' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] FIT description: Linux 4.20.0-g96d4f267e40f Created: Fri Jan 4 17:14:02 2019 Image 0 (kernel@0) Description: Linux 4.20.0-g96d4f267e40f Created: Fri Jan 4 17:14:02 2019 Type: Kernel Image Compression: gzip compressed Data Size: 4325822 Bytes = 4224.44 KiB = 4.13 MiB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8080aab0 Hash algo: sha1 Hash value: b91f6c43935d8d8e58b907ed017775e7d13f554f Image 1 (fdt@boston) Description: img,boston Device Tree Created: Fri Jan 4 17:14:02 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 3793 Bytes = 3.70 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 4799f50d688573234da6e9d7701234d394759ef4 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Fri Jan 4 17:14:02 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Fri Jan 4 17:14:02 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 509ce58e44c561d54539e64e9d4b47054e696fc6 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/linus_mips-defconfig_mips # Build took: 0:01:34.068579