# git rev-parse -q --verify 96d4f267e40f9509e8a66e2b39e8b95655617693^{commit} 96d4f267e40f9509e8a66e2b39e8b95655617693 already have revision, skipping fetch # git checkout -q -f -B kisskb 96d4f267e40f9509e8a66e2b39e8b95655617693 # git clean -qxdf # < git log -1 # commit 96d4f267e40f9509e8a66e2b39e8b95655617693 # Author: Linus Torvalds # Date: Thu Jan 3 18:57:57 2019 -0800 # # Remove 'type' argument from access_ok() function # # Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument # of the user address range verification function since we got rid of the # old racy i386-only code to walk page tables by hand. # # It existed because the original 80386 would not honor the write protect # bit when in kernel mode, so you had to do COW by hand before doing any # user access. But we haven't supported that in a long time, and these # days the 'type' argument is a purely historical artifact. # # A discussion about extending 'user_access_begin()' to do the range # checking resulted this patch, because there is no way we're going to # move the old VERIFY_xyz interface to that model. And it's best done at # the end of the merge window when I've done most of my merges, so let's # just get this done once and for all. # # This patch was mostly done with a sed-script, with manual fix-ups for # the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form. # # There were a couple of notable cases: # # - csky still had the old "verify_area()" name as an alias. # # - the iter_iov code had magical hardcoded knowledge of the actual # values of VERIFY_{READ,WRITE} (not that they mattered, since nothing # really used it) # # - microblaze used the type argument for a debug printout # # but other than those oddities this should be a total no-op patch. # # I tried to fix up all architectures, did fairly extensive grepping for # access_ok() uses, and the changes are trivial, but I may have missed # something. Any missed conversion should be trivially fixable, though. # # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 96d4f267e40f9509e8a66e2b39e8b95655617693 # < make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- randconfig KCONFIG_SEED=0x57578945 # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # yes \n | make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- /kisskb/src/drivers/acpi/nfit/intel.c:316:12: warning: 'intel_security_overwrite' defined but not used [-Wunused-function] static int intel_security_overwrite(struct nvdimm *nvdimm, ^~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/acpi/nfit/intel.c:279:12: warning: 'intel_security_query_overwrite' defined but not used [-Wunused-function] static int intel_security_query_overwrite(struct nvdimm *nvdimm) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/acpi/nfit/intel.c:230:12: warning: 'intel_security_erase' defined but not used [-Wunused-function] static int intel_security_erase(struct nvdimm *nvdimm, ^~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/acpi/nfit/intel.c:149:12: warning: 'intel_security_unlock' defined but not used [-Wunused-function] static int intel_security_unlock(struct nvdimm *nvdimm, ^~~~~~~~~~~~~~~~~~~~~ In function 'ZSTD_copyRawBlock', inlined from 'ZSTD_decompressContinue' at /kisskb/src/lib/zstd/decompress.c:1811:24, inlined from 'ZSTD_decompressStream' at /kisskb/src/lib/zstd/decompress.c:2353:5: /kisskb/src/lib/zstd/decompress.c:416:2: warning: argument 1 null where non-null expected [-Wnonnull] memcpy(dst, src, srcSize); ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/string.h:20, from /kisskb/src/lib/zstd/mem.h:24, from /kisskb/src/lib/zstd/bitstream.h:54, from /kisskb/src/lib/zstd/fse.h:228, from /kisskb/src/lib/zstd/decompress.c:32: /kisskb/src/lib/zstd/decompress.c: In function 'ZSTD_decompressStream': /kisskb/src/arch/arm64/include/asm/string.h:46:14: note: in a call to function 'memcpy' declared here extern void *memcpy(void *, const void *, __kernel_size_t); ^~~~~~ In function 'ZSTD_setRleBlock', inlined from 'ZSTD_decompressContinue' at /kisskb/src/lib/zstd/decompress.c:1812:24, inlined from 'ZSTD_decompressStream' at /kisskb/src/lib/zstd/decompress.c:2353:5: /kisskb/src/lib/zstd/decompress.c:426:2: warning: argument 1 null where non-null expected [-Wnonnull] memset(dst, *(const BYTE *)src, regenSize); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/string.h:20, from /kisskb/src/lib/zstd/mem.h:24, from /kisskb/src/lib/zstd/bitstream.h:54, from /kisskb/src/lib/zstd/fse.h:228, from /kisskb/src/lib/zstd/decompress.c:32: /kisskb/src/lib/zstd/decompress.c: In function 'ZSTD_decompressStream': /kisskb/src/arch/arm64/include/asm/string.h:54:14: note: in a call to function 'memset' declared here extern void *memset(void *, int, __kernel_size_t); ^~~~~~ In function 'ZSTD_copyRawBlock', inlined from 'ZSTD_decompressContinue' at /kisskb/src/lib/zstd/decompress.c:1811:24, inlined from 'ZSTD_decompressStream' at /kisskb/src/lib/zstd/decompress.c:2356:6: /kisskb/src/lib/zstd/decompress.c:416:2: warning: argument 1 null where non-null expected [-Wnonnull] memcpy(dst, src, srcSize); ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/string.h:20, from /kisskb/src/lib/zstd/mem.h:24, from /kisskb/src/lib/zstd/bitstream.h:54, from /kisskb/src/lib/zstd/fse.h:228, from /kisskb/src/lib/zstd/decompress.c:32: /kisskb/src/lib/zstd/decompress.c: In function 'ZSTD_decompressStream': /kisskb/src/arch/arm64/include/asm/string.h:46:14: note: in a call to function 'memcpy' declared here extern void *memcpy(void *, const void *, __kernel_size_t); ^~~~~~ In function 'ZSTD_setRleBlock', inlined from 'ZSTD_decompressContinue' at /kisskb/src/lib/zstd/decompress.c:1812:24, inlined from 'ZSTD_decompressStream' at /kisskb/src/lib/zstd/decompress.c:2356:6: /kisskb/src/lib/zstd/decompress.c:426:2: warning: argument 1 null where non-null expected [-Wnonnull] memset(dst, *(const BYTE *)src, regenSize); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/include/linux/string.h:20, from /kisskb/src/lib/zstd/mem.h:24, from /kisskb/src/lib/zstd/bitstream.h:54, from /kisskb/src/lib/zstd/fse.h:228, from /kisskb/src/lib/zstd/decompress.c:32: /kisskb/src/lib/zstd/decompress.c: In function 'ZSTD_decompressStream': /kisskb/src/arch/arm64/include/asm/string.h:54:14: note: in a call to function 'memset' declared here extern void *memset(void *, int, __kernel_size_t); ^~~~~~ /kisskb/src/drivers/mailbox/tegra-hsp.c:782:12: warning: 'tegra_hsp_resume' defined but not used [-Wunused-function] static int tegra_hsp_resume(struct device *dev) ^~~~~~~~~~~~~~~~ /kisskb/src/drivers/misc/pvpanic.c: In function 'pvpanic_walk_resources': /kisskb/src/drivers/misc/pvpanic.c:73:10: error: implicit declaration of function 'ioport_map'; did you mean 'ioremap'? [-Werror=implicit-function-declaration] base = ioport_map(r.start, resource_size(&r)); ^~~~~~~~~~ ioremap /kisskb/src/drivers/misc/pvpanic.c:73:8: warning: assignment to 'void *' from 'int' makes pointer from integer without a cast [-Wint-conversion] base = ioport_map(r.start, resource_size(&r)); ^ cc1: some warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: drivers/misc/pvpanic.o] Error 1 make[2]: *** [/kisskb/src/scripts/Makefile.build:492: drivers/misc] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1049: drivers] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:152: sub-make] Error 2 Command 'make -s -j 8 ARCH=arm64 O=/kisskb/build/linus-rand_arm64-randconfig_arm64-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/aarch64-linux/bin/aarch64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_arm64-randconfig_arm64-gcc8 # Build took: 0:08:17.049037