# git rev-parse -q --verify 0b2c8f8b6b0c7530e2866c95862546d0da2057b0^{commit} 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 already have revision, skipping fetch # git checkout -q -f -B kisskb 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # git clean -qxdf # < git log -1 # commit 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # Author: Linus Torvalds # Date: Fri Jan 4 10:23:10 2019 -0800 # # i915: fix missing user_access_end() in page fault exception case # # When commit fddcd00a49e9 ("drm/i915: Force the slow path after a # user-write error") unified the error handling for various user access # problems, it didn't do the user_access_end() that is needed for the # unsafe_put_user() case. # # It's not a huge deal: a missed user_access_end() will only mean that # SMAP protection isn't active afterwards, and for the error case we'll be # returning to user mode soon enough anyway. But it's wrong, and adding # the proper user_access_end() is trivial enough (and doing it for the # other error cases where it isn't needed doesn't hurt). # # I noticed it while doing the same prep-work for changing # user_access_begin() that precipitated the access_ok() changes in commit # 96d4f267e40f ("Remove 'type' argument from access_ok() function"). # # Fixes: fddcd00a49e9 ("drm/i915: Force the slow path after a user-write error") # Cc: Chris Wilson # Cc: Joonas Lahtinen # Cc: stable@kernel.org # v4.20 # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # < make -s -j 120 ARCH=arm O=/kisskb/build/linus_assabet_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- assabet_defconfig # make -s -j 120 ARCH=arm O=/kisskb/build/linus_assabet_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here Completed OK # rm -rf /kisskb/build/linus_assabet_defconfig_arm # Build took: 0:00:18.634743