# git rev-parse -q --verify 0b2c8f8b6b0c7530e2866c95862546d0da2057b0^{commit} 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 already have revision, skipping fetch # git checkout -q -f -B kisskb 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # git clean -qxdf # < git log -1 # commit 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # Author: Linus Torvalds # Date: Fri Jan 4 10:23:10 2019 -0800 # # i915: fix missing user_access_end() in page fault exception case # # When commit fddcd00a49e9 ("drm/i915: Force the slow path after a # user-write error") unified the error handling for various user access # problems, it didn't do the user_access_end() that is needed for the # unsafe_put_user() case. # # It's not a huge deal: a missed user_access_end() will only mean that # SMAP protection isn't active afterwards, and for the error case we'll be # returning to user mode soon enough anyway. But it's wrong, and adding # the proper user_access_end() is trivial enough (and doing it for the # other error cases where it isn't needed doesn't hurt). # # I noticed it while doing the same prep-work for changing # user_access_begin() that precipitated the access_ok() changes in commit # 96d4f267e40f ("Remove 'type' argument from access_ok() function"). # # Fixes: fddcd00a49e9 ("drm/i915: Force the slow path after a user-write error") # Cc: Chris Wilson # Cc: Joonas Lahtinen # Cc: stable@kernel.org # v4.20 # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/linus_ppc64_defconfig+UP_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ppc64_defconfig # Added to kconfig CONFIG_SMP=n # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/linus_ppc64_defconfig+UP_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/linus_ppc64_defconfig+UP_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/powerpc/kvm/book3s_64_mmu_radix.c: In function '__kvmhv_copy_tofrom_guest_radix': /kisskb/src/arch/powerpc/kvm/book3s_64_mmu_radix.c:75:3: error: 'old_pid' may be used uninitialized in this function [-Werror=uninitialized] cc1: all warnings being treated as errors make[3]: *** [/kisskb/src/scripts/Makefile.build:277: arch/powerpc/kvm/book3s_64_mmu_radix.o] Error 1 make[3]: *** Waiting for unfinished jobs.... make[2]: *** [/kisskb/src/scripts/Makefile.build:492: arch/powerpc/kvm] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/trace/trace_dynevent.c: In function 'create_dyn_event': /kisskb/src/kernel/trace/trace_dynevent.c:89:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.28': /kisskb/src/net/bridge/br_netlink.c:652:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:341:21: note: 'pdeo' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1434:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] make[1]: *** [/kisskb/src/Makefile:1049: arch/powerpc] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1843:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1753:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] make: *** [Makefile:152: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/linus_ppc64_defconfig+UP_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_ppc64_defconfig+UP_powerpc # Build took: 0:01:16.585610