# git rev-parse -q --verify 0b2c8f8b6b0c7530e2866c95862546d0da2057b0^{commit} 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 already have revision, skipping fetch # git checkout -q -f -B kisskb 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # git clean -qxdf # < git log -1 # commit 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # Author: Linus Torvalds # Date: Fri Jan 4 10:23:10 2019 -0800 # # i915: fix missing user_access_end() in page fault exception case # # When commit fddcd00a49e9 ("drm/i915: Force the slow path after a # user-write error") unified the error handling for various user access # problems, it didn't do the user_access_end() that is needed for the # unsafe_put_user() case. # # It's not a huge deal: a missed user_access_end() will only mean that # SMAP protection isn't active afterwards, and for the error case we'll be # returning to user mode soon enough anyway. But it's wrong, and adding # the proper user_access_end() is trivial enough (and doing it for the # other error cases where it isn't needed doesn't hurt). # # I noticed it while doing the same prep-work for changing # user_access_begin() that precipitated the access_ok() changes in commit # 96d4f267e40f ("Remove 'type' argument from access_ok() function"). # # Fixes: fddcd00a49e9 ("drm/i915: Force the slow path after a user-write error") # Cc: Chris Wilson # Cc: Joonas Lahtinen # Cc: stable@kernel.org # v4.20 # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux-ld --version # < git log --format=%s --max-count=1 0b2c8f8b6b0c7530e2866c95862546d0da2057b0 # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- a500_defconfig # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/arch/parisc/include/asm/atomic.h:10, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/arch/parisc/include/asm/bitops.h:13, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/drivers/scsi/scsi_debug.c:23: /kisskb/src/drivers/scsi/scsi_debug.c: In function 'resp_start_stop': /kisskb/src/arch/parisc/include/asm/cmpxchg.h:48:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))) /kisskb/src/arch/parisc/include/asm/atomic.h:78:30: note: in expansion of macro 'xchg' #define atomic_xchg(v, new) (xchg(&((v)->counter), new)) ^~~~ /kisskb/src/drivers/scsi/scsi_debug.c:1624:2: note: in expansion of macro 'atomic_xchg' atomic_xchg(&devip->stopped, stop); ^~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_a500_defconfig_parisc64 # Build took: 0:00:44.305545