# git rev-parse -q --verify 7b55851367136b1efd84d98fea81ba57a98304cf^{commit} 7b55851367136b1efd84d98fea81ba57a98304cf already have revision, skipping fetch # git checkout -q -f -B kisskb 7b55851367136b1efd84d98fea81ba57a98304cf # git clean -qxdf # < git log -1 # commit 7b55851367136b1efd84d98fea81ba57a98304cf # Author: David Herrmann # Date: Tue Jan 8 13:58:52 2019 +0100 # # fork: record start_time late # # This changes the fork(2) syscall to record the process start_time after # initializing the basic task structure but still before making the new # process visible to user-space. # # Technically, we could record the start_time anytime during fork(2). But # this might lead to scenarios where a start_time is recorded long before # a process becomes visible to user-space. For instance, with # userfaultfd(2) and TLS, user-space can delay the execution of fork(2) # for an indefinite amount of time (and will, if this causes network # access, or similar). # # By recording the start_time late, it much closer reflects the point in # time where the process becomes live and can be observed by other # processes. # # Lastly, this makes it much harder for user-space to predict and control # the start_time they get assigned. Previously, user-space could fork a # process and stall it in copy_thread_tls() before its pid is allocated, # but after its start_time is recorded. This can be misused to later-on # cycle through PIDs and resume the stalled fork(2) yielding a process # that has the same pid and start_time as a process that existed before. # This can be used to circumvent security systems that identify processes # by their pid+start_time combination. # # Even though user-space was always aware that start_time recording is # flaky (but several projects are known to still rely on start_time-based # identification), changing the start_time to be recorded late will help # mitigate existing attacks and make it much harder for user-space to # control the start_time a process gets assigned. # # Reported-by: Jann Horn # Signed-off-by: Tom Gundersen # Signed-off-by: David Herrmann # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 7b55851367136b1efd84d98fea81ba57a98304cf # < make -s -j 8 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- m5272c3_defconfig # make -s -j 8 ARCH=m68k O=/kisskb/build/linus_m5272c3_defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- :1240:2: warning: #warning syscall seccomp not implemented [-Wcpp] :1318:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1321:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1324:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1333:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/arch/m68k/kernel/signal.c: In function 'mangle_kernel_stack': /kisskb/src/arch/m68k/kernel/signal.c:654:3: warning: variable length array 'buf' is used [-Wvla] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_restart': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:912:6: warning: unused variable 'val' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/freescale/fec_main.c: In function 'fec_get_mac': /kisskb/src/drivers/net/ethernet/freescale/fec_main.c:1640:28: warning: unused variable 'pdata' [-Wunused-variable] /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/net/core/filter.c:3469:4: warning: value computed is not used [-Wunused-value] Completed OK # rm -rf /kisskb/build/linus_m5272c3_defconfig_m68k # Build took: 0:00:27.448799