# git rev-parse -q --verify e00d8880481497474792d28c14479a9fb6752046^{commit} e00d8880481497474792d28c14479a9fb6752046 already have revision, skipping fetch # git checkout -q -f -B kisskb e00d8880481497474792d28c14479a9fb6752046 # git clean -qxdf # < git log -1 # commit e00d8880481497474792d28c14479a9fb6752046 # Author: Masahiro Yamada # Date: Tue Jan 15 16:19:00 2019 +0900 # # kbuild: mark prepare0 as PHONY to fix external module build # # Commit c3ff2a5193fa ("powerpc/32: add stack protector support") # caused kernel panic on PowerPC when an external module is used with # CONFIG_STACKPROTECTOR because the 'prepare' target was not executed # for the external module build. # # Commit e07db28eea38 ("kbuild: fix single target build for external # module") turned it into a build error because the 'prepare' target is # now executed but the 'prepare0' target is missing for the external # module build. # # External module on arm/arm64 with CONFIG_STACKPROTECTOR_PER_TASK is # also broken in the same way. # # Move 'PHONY += prepare0' to the common place. GNU Make is fine with # missing rule for phony targets. I also removed the comment which is # wrong irrespective of this commit. # # I minimize the change so it can be easily backported to 4.20.x # # To fix v4.20, please backport e07db28eea38 ("kbuild: fix single target # build for external module"), and then this commit. # # Link: https://bugzilla.kernel.org/show_bug.cgi?id=201891 # Fixes: e07db28eea38 ("kbuild: fix single target build for external module") # Fixes: c3ff2a5193fa ("powerpc/32: add stack protector support") # Fixes: 189af4657186 ("ARM: smp: add support for per-task stack canaries") # Fixes: 0a1213fa7432 ("arm64: enable per-task stack canaries") # Cc: linux-stable # v4.20 # Reported-by: Samuel Holland # Reported-by: Alexey Kardashevskiy # Signed-off-by: Masahiro Yamada # Acked-by: Ard Biesheuvel # Tested-by: Alexey Kardashevskiy # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 e00d8880481497474792d28c14479a9fb6752046 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+KVM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pmac32_defconfig # Added to kconfig CONFIG_VIRTUALIZATION=y # Added to kconfig CONFIG_KVM=y # Added to kconfig CONFIG_KVM_BOOK3S_32=m # Added to kconfig # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+KVM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/kbuild_pmac32_defconfig+KVM_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/trace/trace_dynevent.c: In function 'create_dyn_event': /kisskb/src/kernel/trace/trace_dynevent.c:89:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': /kisskb/src/include/sound/control.h:223:2: warning: 'speaker_vol' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/ppc/awacs.c:886:36: note: 'speaker_vol' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1843:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1753:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1479:6: note: 'pwr_level_cisco' was declared here /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_rf_ctl_override_rev7': /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c:203:21: warning: 'val_addr' may be used uninitialized in this function [-Wuninitialized] INFO: Uncompressed kernel (size 0x8e4114) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) Completed OK # rm -rf /kisskb/build/kbuild_pmac32_defconfig+KVM_powerpc-gcc4.6 # Build took: 0:00:47.455862