# git rev-parse -q --verify 30bac164aca750892b93eef350439a0562a68647^{commit} 30bac164aca750892b93eef350439a0562a68647 already have revision, skipping fetch # git checkout -q -f -B kisskb 30bac164aca750892b93eef350439a0562a68647 # git clean -qxdf # < git log -1 # commit 30bac164aca750892b93eef350439a0562a68647 # Author: Linus Torvalds # Date: Thu Jan 24 09:04:37 2019 +1300 # # Revert "Change mincore() to count "mapped" pages rather than "cached" pages" # # This reverts commit 574823bfab82d9d8fa47f422778043fbb4b4f50e. # # It turns out that my hope that we could just remove the code that # exposes the cache residency status from mincore() was too optimistic. # # There are various random users that want it, and one example would be # the Netflix database cluster maintenance. To quote Josh Snyder: # # "For Netflix, losing accurate information from the mincore syscall # would lengthen database cluster maintenance operations from days to # months. We rely on cross-process mincore to migrate the contents of a # page cache from machine to machine, and across reboots. # # To do this, I wrote and maintain happycache [1], a page cache # dumper/loader tool. It is quite similar in architecture to pgfincore, # except that it is agnostic to workload. The gist of happycache's # operation is "produce a dump of residence status for each page, do # some operation, then reload exactly the same pages which were present # before." happycache is entirely dependent on accurate reporting of the # in-core status of file-backed pages, as accessed by another process. # # We primarily use happycache with Cassandra, which (like Postgres + # pgfincore) relies heavily on OS page cache to reduce disk accesses. # Because our workloads never experience a cold page cache, we are able # to provision hardware for a peak utilization level that is far lower # than the hypothetical "every query is a cache miss" peak. # # A database warmed by happycache can be ready for service in seconds # (bounded only by the performance of the drives and the I/O subsystem), # with no period of in-service degradation. By contrast, putting a # database in service without a page cache entails a potentially # unbounded period of degradation (at Netflix, the time to populate a # single node's cache via natural cache misses varies by workload from # hours to weeks). If a single node upgrade were to take weeks, then # upgrading an entire cluster would take months. Since we want to apply # security upgrades (and other things) on a somewhat tighter schedule, # we would have to develop more complex solutions to provide the same # functionality already provided by mincore. # # At the bottom line, happycache is designed to benignly exploit the # same information leak documented in the paper [2]. I think it makes # perfect sense to remove cross-process mincore functionality from # unprivileged users, but not to remove it entirely" # # We do have an alternate approach that limits the cache residency # reporting only to processes that have write permissions to the file, so # we can fix the original information leak issue that way. It involves # _adding_ code rather than removing it, which is sad, but hey, at least # we haven't found any users that would find the restrictions # unacceptable. # # So revert the optimistic first approach to make room for that alternate # fix instead. # # Reported-by: Josh Snyder # Cc: Jiri Kosina # Cc: Dominique Martinet # Cc: Andy Lutomirski # Cc: Dave Chinner # Cc: Kevin Easton # Cc: Matthew Wilcox # Cc: Cyril Hrubis # Cc: Vlastimil Babka # Cc: Tejun Heo # Cc: Kirill A. Shutemov # Cc: Daniel Gruss # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-ld --version # < git log --format=%s --max-count=1 30bac164aca750892b93eef350439a0562a68647 # < make -s -j 10 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 10 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- oldconfig yes: standard output: Broken pipe # make -s -j 10 ARCH=parisc O=/kisskb/build/linus_parisc-allmodconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux- :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/kernel/trace/trace_hwlat.c: In function 'kthread_fn': /kisskb/src/kernel/trace/trace_hwlat.c:341:1: warning: the frame size of 1696 bytes is larger than 1280 bytes [-Wframe-larger-than=] } ^ /kisskb/src/lib/xxhash.c: In function 'xxh64': /kisskb/src/lib/xxhash.c:236:1: warning: the frame size of 1624 bytes is larger than 1280 bytes [-Wframe-larger-than=] } ^ In file included from /kisskb/src/arch/parisc/include/asm/atomic.h:10, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/arch/parisc/include/asm/bitops.h:13, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/wait.h:7, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/ocfs2/file.c:27: /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/arch/parisc/include/asm/cmpxchg.h:48:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))) ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ocfs2/file.c:2386:3: note: in expansion of macro 'xchg' xchg(&iocb->ki_complete, saved_ki_complete); ^~~~ In file included from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:66: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:40: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:66: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:40: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ /kisskb/src/net/sched/sch_cake.c: In function 'cake_dump_stats': /kisskb/src/net/sched/sch_cake.c:2855:1: warning: the frame size of 1480 bytes is larger than 1280 bytes [-Wframe-larger-than=] } ^ /kisskb/src/drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c: In function 'nvkm_control_mthd_pstate_info': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c:60:21: warning: overflow in conversion from 'int' to '__s8' {aka 'signed char'} changes value from '-251' to '5' [-Woverflow] args->v0.pwrsrc = -ENOSYS; ^ In file included from /kisskb/src/drivers/net/phy/dp83640.c:36: /kisskb/src/drivers/net/phy/dp83640_reg.h:8: warning: "PAGE0" redefined #define PAGE0 0x0000 In file included from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/include/linux/crypto.h:24, from /kisskb/src/include/crypto/hash.h:16, from /kisskb/src/include/linux/uio.h:14, from /kisskb/src/include/linux/socket.h:8, from /kisskb/src/include/linux/compat.h:15, from /kisskb/src/include/linux/ethtool.h:17, from /kisskb/src/drivers/net/phy/dp83640.c:24: /kisskb/src/arch/parisc/include/asm/page.h:184: note: this is the location of the previous definition #define PAGE0 ((struct zeropage *)__PAGE_OFFSET) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:58: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:20: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:58: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:20: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:18: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:12: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:18: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:12: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:22: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:13: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:22: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:13: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:20: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:11: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:20: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:11: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:24: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:14: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:24: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:14: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:19: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:11: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:19: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:11: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:17: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:9: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:17: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:9: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:13: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:10: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:13: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:10: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:21, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:21, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:22: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:10: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:22: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/scatterlist.h:9, from /kisskb/src/include/linux/dma-mapping.h:11, from /kisskb/src/include/linux/skbuff.h:34, from /kisskb/src/include/linux/if_ether.h:23, from /kisskb/src/include/uapi/linux/ethtool.h:19, from /kisskb/src/include/linux/ethtool.h:18, from /kisskb/src/include/linux/netdevice.h:41, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:10: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:15: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654: warning: "writeq" redefined #define writeq(val64, db) \ In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:12: /kisskb/src/arch/parisc/include/asm/io.h:221: note: this is the location of the previous definition #define writeq writeq In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:15: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq In file included from /kisskb/src/include/linux/io.h:25, from /kisskb/src/include/linux/irq.h:20, from /kisskb/src/arch/parisc/include/asm/hardirq.h:13, from /kisskb/src/include/linux/hardirq.h:9, from /kisskb/src/include/linux/interrupt.h:11, from /kisskb/src/include/linux/pci.h:32, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:12: /kisskb/src/arch/parisc/include/asm/io.h:230: note: this is the location of the previous definition #define writeq_relaxed(q, addr) writeq(q, addr) In file included from /kisskb/src/arch/parisc/include/asm/atomic.h:10, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/arch/parisc/include/asm/bitops.h:13, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:11: /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_xdp_setup': /kisskb/src/arch/parisc/include/asm/cmpxchg.h:48:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))) ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4471:4: note: in expansion of macro 'xchg' xchg(&adapter->rx_ring[i]->xdp_prog, adapter->xdp_prog); ^~~~ Completed OK # rm -rf /kisskb/build/linus_parisc-allmodconfig_parisc # Build took: 0:26:33.690639