# git rev-parse -q --verify 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a^{commit} 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a already have revision, skipping fetch # git checkout -q -f -B kisskb 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # git clean -qxdf # < git log -1 # commit 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # Author: Michal Hocko # Date: Fri Jan 25 19:08:58 2019 +0100 # # Revert "mm, memory_hotplug: initialize struct pages for the full memory section" # # This reverts commit 2830bf6f05fb3e05bc4743274b806c821807a684. # # The underlying assumption that one sparse section belongs into a single # numa node doesn't hold really. Robert Shteynfeld has reported a boot # failure. The boot log was not captured but his memory layout is as # follows: # # Early memory node ranges # node 1: [mem 0x0000000000001000-0x0000000000090fff] # node 1: [mem 0x0000000000100000-0x00000000dbdf8fff] # node 1: [mem 0x0000000100000000-0x0000001423ffffff] # node 0: [mem 0x0000001424000000-0x0000002023ffffff] # # This means that node0 starts in the middle of a memory section which is # also in node1. memmap_init_zone tries to initialize padding of a # section even when it is outside of the given pfn range because there are # code paths (e.g. memory hotplug) which assume that the full worth of # memory section is always initialized. # # In this particular case, though, such a range is already intialized and # most likely already managed by the page allocator. Scribbling over # those pages corrupts the internal state and likely blows up when any of # those pages gets used. # # Reported-by: Robert Shteynfeld # Fixes: 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full memory section") # Cc: stable@kernel.org # Signed-off-by: Michal Hocko # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # < make -s -j 48 ARCH=arm O=/kisskb/build/linus_eseries_pxa_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- eseries_pxa_defconfig # make -s -j 48 ARCH=arm O=/kisskb/build/linus_eseries_pxa_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1479:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/linus_eseries_pxa_defconfig_arm # Build took: 0:00:35.574623