# git rev-parse -q --verify 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a^{commit} 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a already have revision, skipping fetch # git checkout -q -f -B kisskb 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # git clean -qxdf # < git log -1 # commit 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # Author: Michal Hocko # Date: Fri Jan 25 19:08:58 2019 +0100 # # Revert "mm, memory_hotplug: initialize struct pages for the full memory section" # # This reverts commit 2830bf6f05fb3e05bc4743274b806c821807a684. # # The underlying assumption that one sparse section belongs into a single # numa node doesn't hold really. Robert Shteynfeld has reported a boot # failure. The boot log was not captured but his memory layout is as # follows: # # Early memory node ranges # node 1: [mem 0x0000000000001000-0x0000000000090fff] # node 1: [mem 0x0000000000100000-0x00000000dbdf8fff] # node 1: [mem 0x0000000100000000-0x0000001423ffffff] # node 0: [mem 0x0000001424000000-0x0000002023ffffff] # # This means that node0 starts in the middle of a memory section which is # also in node1. memmap_init_zone tries to initialize padding of a # section even when it is outside of the given pfn range because there are # code paths (e.g. memory hotplug) which assume that the full worth of # memory section is always initialized. # # In this particular case, though, such a range is already intialized and # most likely already managed by the page allocator. Scribbling over # those pages corrupts the internal state and likely blows up when any of # those pages gets used. # # Reported-by: Robert Shteynfeld # Fixes: 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full memory section") # Cc: stable@kernel.org # Signed-off-by: Michal Hocko # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/ia64-linux/bin/ia64-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/ia64-linux/bin/ia64-linux-ld --version # < git log --format=%s --max-count=1 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # < make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/ia64-linux/bin/ia64-linux- defconfig # make -s -j 48 ARCH=ia64 O=/kisskb/build/linus_ia64-defconfig_ia64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/ia64-linux/bin/ia64-linux- :1186:2: warning: #warning syscall perf_event_open not implemented [-Wcpp] :1240:2: warning: #warning syscall seccomp not implemented [-Wcpp] :1318:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1321:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1324:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1327:2: warning: #warning syscall statx not implemented [-Wcpp] :1333:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/fork.c:766:13: warning: 'task_struct_whitelist' defined but not used [-Wunused-function] /kisskb/src/mm/vmstat.c: In function 'sysctl_vm_numa_stat_handler': /kisskb/src/mm/vmstat.c:89:5: warning: 'oldval' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1434:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] No errors detected in 21243 functions. Kernel: vmlinux.gz is ready Completed OK # rm -rf /kisskb/build/linus_ia64-defconfig_ia64 # Build took: 0:01:50.226326