# git rev-parse -q --verify 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a^{commit} 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a already have revision, skipping fetch # git checkout -q -f -B kisskb 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # git clean -qxdf # < git log -1 # commit 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # Author: Michal Hocko # Date: Fri Jan 25 19:08:58 2019 +0100 # # Revert "mm, memory_hotplug: initialize struct pages for the full memory section" # # This reverts commit 2830bf6f05fb3e05bc4743274b806c821807a684. # # The underlying assumption that one sparse section belongs into a single # numa node doesn't hold really. Robert Shteynfeld has reported a boot # failure. The boot log was not captured but his memory layout is as # follows: # # Early memory node ranges # node 1: [mem 0x0000000000001000-0x0000000000090fff] # node 1: [mem 0x0000000000100000-0x00000000dbdf8fff] # node 1: [mem 0x0000000100000000-0x0000001423ffffff] # node 0: [mem 0x0000001424000000-0x0000002023ffffff] # # This means that node0 starts in the middle of a memory section which is # also in node1. memmap_init_zone tries to initialize padding of a # section even when it is outside of the given pfn range because there are # code paths (e.g. memory hotplug) which assume that the full worth of # memory section is always initialized. # # In this particular case, though, such a range is already intialized and # most likely already managed by the page allocator. Scribbling over # those pages corrupts the internal state and likely blows up when any of # those pages gets used. # # Reported-by: Robert Shteynfeld # Fixes: 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full memory section") # Cc: stable@kernel.org # Signed-off-by: Michal Hocko # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld --version # < git log --format=%s --max-count=1 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # < make -s -j 48 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- allmodconfig # make -s -j 48 ARCH=nds32 O=/kisskb/build/linus_nds32-allmodconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized] if (ret == -EOPNOTSUPP) ^ /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^~~~~~~ WARNING: EXPORT symbol "clear_page" [vmlinux] version generation failed, symbol will not be versioned. WARNING: EXPORT symbol "copy_page" [vmlinux] version generation failed, symbol will not be versioned. WARNING: "clear_page" [fs/ocfs2/dlm/ocfs2_dlm.ko] has no CRC! WARNING: "clear_page" [fs/ntfs/ntfs.ko] has no CRC! WARNING: "copy_page" [fs/nilfs2/nilfs2.ko] has no CRC! WARNING: "clear_page" [fs/gfs2/gfs2.ko] has no CRC! WARNING: "copy_page" [fs/fuse/fuse.ko] has no CRC! WARNING: "clear_page" [fs/fuse/fuse.ko] has no CRC! WARNING: "clear_page" [fs/exofs/libore.ko] has no CRC! WARNING: "clear_page" [fs/exofs/exofs.ko] has no CRC! WARNING: "copy_page" [fs/cachefiles/cachefiles.ko] has no CRC! WARNING: "copy_page" [fs/btrfs/btrfs.ko] has no CRC! WARNING: "clear_page" [fs/btrfs/btrfs.ko] has no CRC! WARNING: "clear_page" [drivers/scsi/sd_mod.ko] has no CRC! WARNING: "clear_page" [drivers/md/raid456.ko] has no CRC! WARNING: "clear_page" [drivers/md/dm-integrity.ko] has no CRC! WARNING: "copy_page" [drivers/gpu/drm/ttm/ttm.ko] has no CRC! WARNING: "clear_page" [drivers/gpu/drm/ttm/ttm.ko] has no CRC! WARNING: "copy_page" [drivers/block/drbd/drbd.ko] has no CRC! Completed OK # rm -rf /kisskb/build/linus_nds32-allmodconfig_nds32le # Build took: 0:09:49.741771