# git rev-parse -q --verify 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a^{commit} 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a already have revision, skipping fetch # git checkout -q -f -B kisskb 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # git clean -qxdf # < git log -1 # commit 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # Author: Michal Hocko # Date: Fri Jan 25 19:08:58 2019 +0100 # # Revert "mm, memory_hotplug: initialize struct pages for the full memory section" # # This reverts commit 2830bf6f05fb3e05bc4743274b806c821807a684. # # The underlying assumption that one sparse section belongs into a single # numa node doesn't hold really. Robert Shteynfeld has reported a boot # failure. The boot log was not captured but his memory layout is as # follows: # # Early memory node ranges # node 1: [mem 0x0000000000001000-0x0000000000090fff] # node 1: [mem 0x0000000000100000-0x00000000dbdf8fff] # node 1: [mem 0x0000000100000000-0x0000001423ffffff] # node 0: [mem 0x0000001424000000-0x0000002023ffffff] # # This means that node0 starts in the middle of a memory section which is # also in node1. memmap_init_zone tries to initialize padding of a # section even when it is outside of the given pfn range because there are # code paths (e.g. memory hotplug) which assume that the full worth of # memory section is always initialized. # # In this particular case, though, such a range is already intialized and # most likely already managed by the page allocator. Scribbling over # those pages corrupts the internal state and likely blows up when any of # those pages gets used. # # Reported-by: Robert Shteynfeld # Fixes: 2830bf6f05fb ("mm, memory_hotplug: initialize struct pages for the full memory section") # Cc: stable@kernel.org # Signed-off-by: Michal Hocko # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 4aa9fc2a435abe95a1e8d7f8c7b3d6356514b37a # < make -s -j 80 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 80 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/arch/mips/boot/dts/xilfpga/nexys4ddr.dts:109.16-112.8: Warning (i2c_bus_reg): /i2c@10A00000/ad7420@4B: I2C bus unit address format error, expected "4b" /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:152:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:100:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/arch/mips/vdso/Makefile:38: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] FIT description: Linux 5.0.0-rc4-g4aa9fc2a435a Created: Tue Jan 29 07:58:31 2019 Image 0 (kernel@0) Description: Linux 5.0.0-rc4-g4aa9fc2a435a Created: Tue Jan 29 07:58:31 2019 Type: Kernel Image Compression: gzip compressed Data Size: 4329397 Bytes = 4227.93 KiB = 4.13 MiB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8080c210 Hash algo: sha1 Hash value: 5242fe2dcad57fd49c8e100b28bc2f9e150afd84 Image 1 (fdt@boston) Description: img,boston Device Tree Created: Tue Jan 29 07:58:31 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 3793 Bytes = 3.70 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 4799f50d688573234da6e9d7701234d394759ef4 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Tue Jan 29 07:58:31 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Tue Jan 29 07:58:31 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 509ce58e44c561d54539e64e9d4b47054e696fc6 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/linus_mips-defconfig_mips # Build took: 0:01:29.529402