# git rev-parse -q --verify c228d294f2040c3a5f5965ff04d4947d0bf6e7da^{commit} c228d294f2040c3a5f5965ff04d4947d0bf6e7da already have revision, skipping fetch # git checkout -q -f -B kisskb c228d294f2040c3a5f5965ff04d4947d0bf6e7da # git clean -qxdf # < git log -1 # commit c228d294f2040c3a5f5965ff04d4947d0bf6e7da # Author: Linus Torvalds # Date: Thu Jan 31 11:10:20 2019 -0800 # # x86: explicitly align IO accesses in memcpy_{to,from}io # # In commit 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # I made our copy from IO space use a separate copy routine rather than # rely on the generic memcpy. I did that because our generic memory copy # isn't actually well-defined when it comes to internal access ordering or # alignment, and will in fact depend on various CPUID flags. # # In particular, the default memcpy() for a modern Intel CPU will # generally be just a "rep movsb", which works reasonably well for # medium-sized memory copies of regular RAM, since the CPU will turn it # into fairly optimized microcode. # # However, for non-cached memory and IO, "rep movs" ends up being # horrendously slow and will just do the architectural "one byte at a # time" accesses implied by the movsb. # # At the other end of the spectrum, if you _don't_ end up using the "rep # movsb" code, you'd likely fall back to the software copy, which does # overlapping accesses for the tail, and may copy things backwards. # Again, for regular memory that's fine, for IO memory not so much. # # The thinking was that clearly nobody really cared (because things # worked), but some people had seen horrible performance due to the byte # accesses, so let's just revert back to our long ago version that dod # "rep movsl" for the bulk of the copy, and then fixed up the potentially # last few bytes of the tail with "movsw/b". # # Interestingly (and perhaps not entirely surprisingly), while that was # our original memory copy implementation, and had been used before for # IO, in the meantime many new users of memcpy_*io() had come about. And # while the access patterns for the memory copy weren't well-defined (so # arguably _any_ access pattern should work), in practice the "rep movsb" # case had been very common for the last several years. # # In particular Jarkko Sakkinen reported that the memcpy_*io() change # resuled in weird errors from his Geminilake NUC TPM module. # # And it turns out that the TPM TCG accesses according to spec require # that the accesses be # # (a) done strictly sequentially # # (b) be naturally aligned # # otherwise the TPM chip will abort the PCI transaction. # # And, in fact, the tpm_crb.c driver did this: # # memcpy_fromio(buf, priv->rsp, 6); # ... # memcpy_fromio(&buf[6], &priv->rsp[6], expected - 6); # # which really should never have worked in the first place, but back # before commit 170d13ca3a2f it *happened* to work, because the # memcpy_fromio() would be expanded to a regular memcpy, and # # (a) gcc would expand the first memcpy in-line, and turn it into a # 4-byte and a 2-byte read, and they happened to be in the right # order, and the alignment was right. # # (b) gcc would call "memcpy()" for the second one, and the machines that # had this TPM chip also apparently ended up always having ERMS # ("Enhanced REP MOVSB/STOSB instructions"), so we'd use the "rep # movbs" for that copy. # # In other words, basically by pure luck, the code happened to use the # right access sizes in the (two different!) memcpy() implementations to # make it all work. # # But after commit 170d13ca3a2f, both of the memcpy_fromio() calls # resulted in a call to the routine with the consistent memory accesses, # and in both cases it started out transferring with 4-byte accesses. # Which worked for the first copy, but resulted in the second copy doing a # 32-bit read at an address that was only 2-byte aligned. # # Jarkko is actually fixing the fragile code in the TPM driver, but since # this is an excellent example of why we absolutely must not use a generic # memcpy for IO accesses, _and_ an IO-specific one really should strive to # align the IO accesses, let's do exactly that. # # Side note: Jarkko also noted that the driver had been used on ARM # platforms, and had worked. That was because on 32-bit ARM, memcpy_*io() # ends up always doing byte accesses, and on 64-bit ARM it first does byte # accesses to align to 8-byte boundaries, and then does 8-byte accesses # for the bulk. # # So ARM actually worked by design, and the x86 case worked by pure luck. # # We *might* want to make x86-64 do the 8-byte case too. That should be a # pretty straightforward extension, but let's do one thing at a time. And # generally MMIO accesses aren't really all that performance-critical, as # shown by the fact that for a long time we just did them a byte at a # time, and very few people ever noticed. # # Reported-and-tested-by: Jarkko Sakkinen # Tested-by: Jerry Snitselaar # Cc: David Laight # Fixes: 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux-ld --version # < git log --format=%s --max-count=1 c228d294f2040c3a5f5965ff04d4947d0bf6e7da # < make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=s390 O=/kisskb/build/linus_s390-allmodconfig_s390x CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/s390x-linux/bin/s390x-linux- /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/events/core.c: In function 'perf_log_throttle': /kisskb/src/kernel/events/core.c:7651:1: warning: 'perf_log_throttle' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_swevent_hrtimer': /kisskb/src/kernel/events/core.c:9163:1: warning: 'perf_swevent_hrtimer' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_log_itrace_start': /kisskb/src/kernel/events/core.c:7692:1: warning: 'perf_log_itrace_start' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_read_event': /kisskb/src/kernel/events/core.c:6581:1: warning: 'perf_event_read_event' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_task_output': /kisskb/src/kernel/events/core.c:6860:1: warning: 'perf_event_task_output' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_mmap_output': /kisskb/src/kernel/events/core.c:7216:1: warning: 'perf_event_mmap_output' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_namespaces_output': /kisskb/src/kernel/events/core.c:7053:1: warning: 'perf_event_namespaces_output' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_comm_output': /kisskb/src/kernel/events/core.c:6954:1: warning: 'perf_event_comm_output' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_switch_output': /kisskb/src/kernel/events/core.c:7580:1: warning: 'perf_event_switch_output' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_event_aux_event': /kisskb/src/kernel/events/core.c:7488:1: warning: 'perf_event_aux_event' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_log_lost_samples': /kisskb/src/kernel/events/core.c:7521:1: warning: 'perf_log_lost_samples' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function 'perf_tp_event': /kisskb/src/kernel/events/core.c:8331:1: warning: 'perf_tp_event' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/core.c: In function '___perf_sw_event': /kisskb/src/kernel/events/core.c:8017:1: warning: '___perf_sw_event' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin_forward': /kisskb/src/kernel/events/ring_buffer.c:238:1: warning: 'perf_output_begin_forward' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin_backward': /kisskb/src/kernel/events/ring_buffer.c:244:1: warning: 'perf_output_begin_backward' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/events/ring_buffer.c: In function 'perf_output_begin': /kisskb/src/kernel/events/ring_buffer.c:252:1: warning: 'perf_output_begin' uses dynamic stack allocation [enabled by default] /kisskb/src/arch/s390/kernel/perf_cpum_sf.c: In function 'perf_push_sample': /kisskb/src/arch/s390/kernel/perf_cpum_sf.c:1075:1: warning: 'perf_push_sample' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/atm/ambassador.c: In function 'do_loader_command': /kisskb/src/drivers/atm/ambassador.c:1762:3: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct loader_block *' /kisskb/src/kernel/smp.c: In function 'smp_call_function_single': /kisskb/src/kernel/smp.c:307:1: warning: 'smp_call_function_single' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': /kisskb/src/include/asm-generic/io.h:232:15: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here /kisskb/src/include/asm-generic/io.h:232:15: warning: 'px_cmd' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1434:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dynroot.c: In function 'afs_lookup_atcell': /kisskb/src/fs/afs/dynroot.c:126:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/slub.c: In function 'deactivate_slab.isra.50': /kisskb/src/mm/slub.c:2167:1: warning: 'deactivate_slab.isra.50' uses dynamic stack allocation [enabled by default] /kisskb/src/mm/slub.c: In function 'unfreeze_partials.isra.51': /kisskb/src/mm/slub.c:2235:1: warning: 'unfreeze_partials.isra.51' uses dynamic stack allocation [enabled by default] /kisskb/src/mm/slub.c: In function 'get_partial_node.isra.52': /kisskb/src/mm/slub.c:1874:1: warning: 'get_partial_node.isra.52' uses dynamic stack allocation [enabled by default] /kisskb/src/mm/slub.c: In function '___slab_alloc': /kisskb/src/mm/slub.c:2620:1: warning: '___slab_alloc' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/rseq.c: In function 'rseq_ip_fixup': /kisskb/src/kernel/rseq.c:249:1: warning: 'rseq_ip_fixup' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/rseq.c: In function 'rseq_syscall': /kisskb/src/kernel/rseq.c:301:1: warning: 'rseq_syscall' uses dynamic stack allocation [enabled by default] /kisskb/src/mm/slub.c: In function '__slab_free': /kisskb/src/mm/slub.c:2921:1: warning: '__slab_free' uses dynamic stack allocation [enabled by default] /kisskb/src/kernel/trace/trace_dynevent.c: In function 'create_dyn_event': /kisskb/src/kernel/trace/trace_dynevent.c:89:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/netfilter/ebtables.c: In function 'compat_copy_everything_to_user': /kisskb/src/net/bridge/netfilter/ebtables.c:1908:1: warning: 'compat_copy_everything_to_user' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_device.c: In function 'br_get_stats64': /kisskb/src/net/bridge/br_device.c:232:1: warning: 'br_get_stats64' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/scsi/zfcp_erp.c: In function 'zfcp_erp_setup_act': /kisskb/src/drivers/s390/scsi/zfcp_erp.c:262:2: warning: 'erp_action' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'query_info': /kisskb/src/drivers/s390/net/ism_drv.c:84:1: warning: 'query_info' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'register_sba': /kisskb/src/drivers/s390/net/ism_drv.c:111:1: warning: 'register_sba' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'register_ieq': /kisskb/src/drivers/s390/net/ism_drv.c:140:1: warning: 'register_ieq' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_query_rgid': /kisskb/src/drivers/s390/net/ism_drv.c:209:1: warning: 'ism_query_rgid' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_unregister_dmb': /kisskb/src/drivers/s390/net/ism_drv.c:296:1: warning: 'ism_unregister_dmb' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_add_vlan_id': /kisskb/src/drivers/s390/net/ism_drv.c:310:1: warning: 'ism_add_vlan_id' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_del_vlan_id': /kisskb/src/drivers/s390/net/ism_drv.c:324:1: warning: 'ism_del_vlan_id' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_signal_ieq': /kisskb/src/drivers/s390/net/ism_drv.c:352:1: warning: 'ism_signal_ieq' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_dev_init': /kisskb/src/drivers/s390/net/ism_drv.c:486:1: warning: 'ism_dev_init' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/s390/net/ism_drv.c: In function 'ism_register_dmb': /kisskb/src/drivers/s390/net/ism_drv.c:275:1: warning: 'ism_register_dmb' uses dynamic stack allocation [enabled by default] /kisskb/src/net/bridge/br_netlink.c: In function 'br_process_vlan_info': /kisskb/src/net/bridge/br_netlink.c:591:10: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ncsi/ncsi-manage.c: In function 'set_one_vid': /kisskb/src/net/ncsi/ncsi-manage.c:676:19: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'wait_for_states.constprop.23': /kisskb/src/drivers/crypto/chelsio/chtls/chtls_cm.c:405:1: warning: 'wait_for_states.constprop.23' uses dynamic stack allocation [enabled by default] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c: In function 'amdgpu_set_pp_od_clk_voltage': /kisskb/src/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:593:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_extent_item.isra.2': /kisskb/src/fs/btrfs/ref-verify.c:503:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_leaf.isra.3': /kisskb/src/fs/btrfs/ref-verify.c:555:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c: In function 'arizona_hw_params': /kisskb/src/sound/soc/codecs/arizona.c:1893:3: warning: 'aif_rx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c:1890:3: warning: 'aif_tx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/stats.c: In function 'rpc_clnt_show_stats': /kisskb/src/net/sunrpc/stats.c:268:1: warning: 'rpc_clnt_show_stats' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function 'gmc_v8_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1474:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1474:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work': /kisskb/src/sound/soc/codecs/da7219-aad.c:321:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function 'gmc_v9_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:323:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:323:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/lib/test_ubsan.c: In function 'test_ubsan_out_of_bounds': /kisskb/src/lib/test_ubsan.c:67:1: warning: 'test_ubsan_out_of_bounds' uses dynamic stack allocation [enabled by default] /kisskb/src/lib/test_ubsan.c: In function 'test_ubsan_vla_bound_not_positive': /kisskb/src/lib/test_ubsan.c:51:1: warning: 'test_ubsan_vla_bound_not_positive' uses dynamic stack allocation [enabled by default] /kisskb/src/lib/test_ubsan.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/fs/f2fs/file.c: In function 'f2fs_precache_extents': /kisskb/src/fs/f2fs/file.c:2937:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c: In function '__arm_v7s_map.constprop.7': /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:438:7: warning: 'cptep' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c: In function 'rt5665_i2s_pin_event': /kisskb/src/sound/soc/codecs/rt5665.c:2666:33: warning: 'val2' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c:2663:33: warning: 'val1' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_do_flip': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4589:9: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4589:9: warning: (near initialization for 'stream_update.src') [-Wmissing-braces] /kisskb/src/fs/nfs/super.c: In function 'nfs_show_stats': /kisskb/src/fs/nfs/super.c:890:1: warning: 'nfs_show_stats' uses dynamic stack allocation [enabled by default] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c:2081:42: warning: 'end' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/soc/qcom/rpmh.c: In function 'rpmh_write_batch': /kisskb/src/drivers/soc/qcom/rpmh.c:355:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach': /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c:922:2: warning: value computed is not used [-Wunused-value] /kisskb/src/drivers/target/iscsi/cxgbit/cxgbit_target.c: In function 'cxgbit_tx_datain_iso.isra.32': /kisskb/src/drivers/target/iscsi/cxgbit/cxgbit_target.c:501:1: warning: 'cxgbit_tx_datain_iso.isra.32' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/target/iscsi/iscsi_target.c: In function 'iscsit_send_datain': /kisskb/src/drivers/target/iscsi/iscsi_target.c:2846:1: warning: 'iscsit_send_datain' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c: In function 'hclgevf_bind_ring_to_vector': /kisskb/src/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c:896:16: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c: In function 'mvpp2_setup_bm_pool': /kisskb/src/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:551:41: warning: overflow in implicit constant conversion [-Woverflow] /kisskb/src/drivers/net/ethernet/neterion/vxge/vxge-config.c: In function 'vxge_hw_device_hw_info_get': /kisskb/src/drivers/net/ethernet/neterion/vxge/vxge-config.c:1089:1: warning: 'vxge_hw_device_hw_info_get' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c: In function 'cudbg_collect_qdesc': /kisskb/src/drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c:2962:6: warning: 'rc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c: In function 'rvu_mbox_handler_npc_mcam_shift_entry': /kisskb/src/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c:1815:15: warning: 'rc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wan/lmc/lmc_main.c: In function 'lmc_softreset': /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1852:9: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1861:9: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1863:5: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1874:9: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1876:5: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/wan/lmc/lmc_main.c:1877:5: warning: passing argument 1 of 'virt_to_bus' discards 'volatile' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/io.h:1074:29: note: expected 'void *' but argument is of type 'volatile struct tulip_desc_t *' /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1846:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1756:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/veth.c: In function 'veth_get_stats64': /kisskb/src/drivers/net/veth.c:364:1: warning: 'veth_get_stats64' uses dynamic stack allocation [enabled by default] /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c: In function 'update_root_ft_create': /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:835:5: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/events.c: In function 'port_module': /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/events.c:238:3: warning: 'error_str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/s390/boot/mem_detect.c: In function 'detect_memory': /kisskb/src/arch/s390/boot/mem_detect.c:182:1: warning: 'detect_memory' uses dynamic stack allocation [enabled by default] Completed OK # rm -rf /kisskb/build/linus_s390-allmodconfig_s390x # Build took: 0:10:06.682824