# git rev-parse -q --verify c228d294f2040c3a5f5965ff04d4947d0bf6e7da^{commit} c228d294f2040c3a5f5965ff04d4947d0bf6e7da already have revision, skipping fetch # git checkout -q -f -B kisskb c228d294f2040c3a5f5965ff04d4947d0bf6e7da # git clean -qxdf # < git log -1 # commit c228d294f2040c3a5f5965ff04d4947d0bf6e7da # Author: Linus Torvalds # Date: Thu Jan 31 11:10:20 2019 -0800 # # x86: explicitly align IO accesses in memcpy_{to,from}io # # In commit 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # I made our copy from IO space use a separate copy routine rather than # rely on the generic memcpy. I did that because our generic memory copy # isn't actually well-defined when it comes to internal access ordering or # alignment, and will in fact depend on various CPUID flags. # # In particular, the default memcpy() for a modern Intel CPU will # generally be just a "rep movsb", which works reasonably well for # medium-sized memory copies of regular RAM, since the CPU will turn it # into fairly optimized microcode. # # However, for non-cached memory and IO, "rep movs" ends up being # horrendously slow and will just do the architectural "one byte at a # time" accesses implied by the movsb. # # At the other end of the spectrum, if you _don't_ end up using the "rep # movsb" code, you'd likely fall back to the software copy, which does # overlapping accesses for the tail, and may copy things backwards. # Again, for regular memory that's fine, for IO memory not so much. # # The thinking was that clearly nobody really cared (because things # worked), but some people had seen horrible performance due to the byte # accesses, so let's just revert back to our long ago version that dod # "rep movsl" for the bulk of the copy, and then fixed up the potentially # last few bytes of the tail with "movsw/b". # # Interestingly (and perhaps not entirely surprisingly), while that was # our original memory copy implementation, and had been used before for # IO, in the meantime many new users of memcpy_*io() had come about. And # while the access patterns for the memory copy weren't well-defined (so # arguably _any_ access pattern should work), in practice the "rep movsb" # case had been very common for the last several years. # # In particular Jarkko Sakkinen reported that the memcpy_*io() change # resuled in weird errors from his Geminilake NUC TPM module. # # And it turns out that the TPM TCG accesses according to spec require # that the accesses be # # (a) done strictly sequentially # # (b) be naturally aligned # # otherwise the TPM chip will abort the PCI transaction. # # And, in fact, the tpm_crb.c driver did this: # # memcpy_fromio(buf, priv->rsp, 6); # ... # memcpy_fromio(&buf[6], &priv->rsp[6], expected - 6); # # which really should never have worked in the first place, but back # before commit 170d13ca3a2f it *happened* to work, because the # memcpy_fromio() would be expanded to a regular memcpy, and # # (a) gcc would expand the first memcpy in-line, and turn it into a # 4-byte and a 2-byte read, and they happened to be in the right # order, and the alignment was right. # # (b) gcc would call "memcpy()" for the second one, and the machines that # had this TPM chip also apparently ended up always having ERMS # ("Enhanced REP MOVSB/STOSB instructions"), so we'd use the "rep # movbs" for that copy. # # In other words, basically by pure luck, the code happened to use the # right access sizes in the (two different!) memcpy() implementations to # make it all work. # # But after commit 170d13ca3a2f, both of the memcpy_fromio() calls # resulted in a call to the routine with the consistent memory accesses, # and in both cases it started out transferring with 4-byte accesses. # Which worked for the first copy, but resulted in the second copy doing a # 32-bit read at an address that was only 2-byte aligned. # # Jarkko is actually fixing the fragile code in the TPM driver, but since # this is an excellent example of why we absolutely must not use a generic # memcpy for IO accesses, _and_ an IO-specific one really should strive to # align the IO accesses, let's do exactly that. # # Side note: Jarkko also noted that the driver had been used on ARM # platforms, and had worked. That was because on 32-bit ARM, memcpy_*io() # ends up always doing byte accesses, and on 64-bit ARM it first does byte # accesses to align to 8-byte boundaries, and then does 8-byte accesses # for the bulk. # # So ARM actually worked by design, and the x86 case worked by pure luck. # # We *might* want to make x86-64 do the 8-byte case too. That should be a # pretty straightforward extension, but let's do one thing at a time. And # generally MMIO accesses aren't really all that performance-critical, as # shown by the fact that for a long time we just did them a byte at a # time, and very few people ever noticed. # # Reported-and-tested-by: Jarkko Sakkinen # Tested-by: Jerry Snitselaar # Cc: David Laight # Fixes: 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version # < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-ld --version # < git log --format=%s --max-count=1 c228d294f2040c3a5f5965ff04d4947d0bf6e7da # < make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MIPS_CPS_NS16550_BASE=0x1b0003f8 # Added to kconfig CONFIG_MIPS_CPS_NS16550_SHIFT=0 # Added to kconfig # yes \n | make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=mips O=/kisskb/build/linus_mips-allmodconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux- /kisskb/src/arch/mips/boot/dts/xilfpga/nexys4ddr.dts:109.16-112.8: Warning (i2c_bus_reg): /i2c@10A00000/ad7420@4B: I2C bus unit address format error, expected "4b" /kisskb/src/net/core/sysctl_net_core.c:285:1: warning: 'proc_dointvec_minmax_bpf_restricted' defined but not used [-Wunused-function] proc_dointvec_minmax_bpf_restricted(struct ctl_table *table, int write, ^ /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^ In file included from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:66:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:39: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:66:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/infiniband/hw/bnxt_re/main.c:39: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ /kisskb/src/drivers/spi/spi-sh-msiof.c:74:0: warning: "STR" redefined #define STR 0x40 /* Status Register */ ^ In file included from /kisskb/src/arch/mips/include/asm/mach-generic/spaces.h:15:0, from /kisskb/src/arch/mips/include/asm/addrspace.h:13, from /kisskb/src/arch/mips/include/asm/barrier.h:11, from /kisskb/src/include/linux/compiler.h:250, from /kisskb/src/arch/mips/include/asm/bitops.h:16, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/bitmap.h:8, from /kisskb/src/drivers/spi/spi-sh-msiof.c:10: /kisskb/src/arch/mips/include/asm/mipsregs.h:30:0: note: this is the location of the previous definition #define STR(x) __STR(x) ^ In file included from /kisskb/src/include/linux/rwsem.h:16:0, from /kisskb/src/include/linux/notifier.h:15, from /kisskb/src/include/linux/clk.h:17, from /kisskb/src/drivers/tty/serial/sh-sci.c:24: /kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_submit_rx': /kisskb/src/include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] _raw_spin_unlock_irqrestore(lock, flags); \ ^ /kisskb/src/drivers/tty/serial/sh-sci.c:1338:16: note: 'flags' was declared here unsigned long flags; ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:58:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:58:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.c:11: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:41:0, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/bcm1480_scd.h:274:0: warning: "M_SPC_CFG_CLEAR" redefined #define M_SPC_CFG_CLEAR M_BCM1480_SPC_CFG_CLEAR ^ In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:40:0, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/sb1250_scd.h:405:0: note: this is the location of the previous definition #define M_SPC_CFG_CLEAR _SB_MAKEMASK1(32) ^ In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:41:0, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/bcm1480_scd.h:275:0: warning: "M_SPC_CFG_ENABLE" redefined #define M_SPC_CFG_ENABLE M_BCM1480_SPC_CFG_ENABLE ^ In file included from /kisskb/src/arch/mips/include/asm/sibyte/sb1250.h:40:0, from /kisskb/src/drivers/watchdog/sb_wdog.c:58: /kisskb/src/arch/mips/include/asm/sibyte/sb1250_scd.h:406:0: note: this is the location of the previous definition #define M_SPC_CFG_ENABLE _SB_MAKEMASK1(33) ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:18:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:11: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:18:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c:11: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:22:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/workqueue.h:9, from /kisskb/src/include/linux/rhashtable-types.h:15, from /kisskb/src/include/linux/ipc.h:7, from /kisskb/src/include/uapi/linux/sem.h:5, from /kisskb/src/include/linux/sem.h:5, from /kisskb/src/include/linux/compat.h:14, from /kisskb/src/include/linux/ethtool.h:17, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:13: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:22:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/workqueue.h:9, from /kisskb/src/include/linux/rhashtable-types.h:15, from /kisskb/src/include/linux/ipc.h:7, from /kisskb/src/include/uapi/linux/sem.h:5, from /kisskb/src/include/linux/sem.h:5, from /kisskb/src/include/linux/compat.h:14, from /kisskb/src/include/linux/ethtool.h:17, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:13: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:20:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/netdevice.h:28, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:11: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:20:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/netdevice.h:28, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c:11: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:24:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:10: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:24:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c:10: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:19:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:11: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:19:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c:11: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:17:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:9: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:17:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c:9: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:13:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:10: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:13:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/idr.h:15, from /kisskb/src/include/linux/kernfs.h:14, from /kisskb/src/include/linux/sysfs.h:16, from /kisskb/src/include/linux/kobject.h:20, from /kisskb/src/include/linux/pci.h:29, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c:10: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/include/linux/net_dim.h:37, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:10: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:12:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/umh.h:4, from /kisskb/src/include/linux/kmod.h:22, from /kisskb/src/include/linux/module.h:13, from /kisskb/src/include/linux/net_dim.h:37, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_dim.c:10: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:22:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/netdevice.h:28, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:10: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:22:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/arch/mips/include/asm/mips-cps.h:14, from /kisskb/src/arch/mips/include/asm/smp-ops.h:16, from /kisskb/src/arch/mips/include/asm/smp.h:21, from /kisskb/src/include/linux/smp.h:68, from /kisskb/src/arch/mips/include/asm/cpu-type.h:12, from /kisskb/src/arch/mips/include/asm/timex.h:19, from /kisskb/src/include/linux/timex.h:65, from /kisskb/src/include/linux/jiffies.h:10, from /kisskb/src/include/linux/ktime.h:25, from /kisskb/src/include/linux/timer.h:6, from /kisskb/src/include/linux/netdevice.h:28, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c:10: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:15:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1654:0: warning: "writeq" redefined #define writeq(val64, db) \ ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/fs.h:15, from /kisskb/src/include/linux/debugfs.h:15, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:10: /kisskb/src/arch/mips/include/asm/io.h:523:0: note: this is the location of the previous definition #define writeq writeq ^ In file included from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:15:0: /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt.h:1662:0: warning: "writeq_relaxed" redefined #define writeq_relaxed writeq ^ In file included from /kisskb/src/arch/mips/include/asm/page.h:200:0, from /kisskb/src/include/linux/mmzone.h:21, from /kisskb/src/include/linux/gfp.h:6, from /kisskb/src/include/linux/xarray.h:14, from /kisskb/src/include/linux/radix-tree.h:31, from /kisskb/src/include/linux/fs.h:15, from /kisskb/src/include/linux/debugfs.h:15, from /kisskb/src/drivers/net/ethernet/broadcom/bnxt/bnxt_debugfs.c:10: /kisskb/src/arch/mips/include/asm/io.h:499:0: note: this is the location of the previous definition #define writeq_relaxed __relaxed_writeq ^ /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'mlx5e_grp_sw_update_stats': /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:217:1: warning: the frame size of 1528 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ FIT description: Linux 5.0.0-rc4+ Created: Sat Feb 2 07:35:18 2019 Image 0 (kernel@0) Description: Linux 5.0.0-rc4+ Created: Sat Feb 2 07:35:18 2019 Type: Kernel Image Compression: gzip compressed Data Size: 6260375 Bytes = 6113.65 KiB = 5.97 MiB Architecture: MIPS OS: Linux Load Address: 0x84000000 Entry Point: 0x8499b738 Hash algo: sha1 Hash value: 00558b6af76397194c0cb2027d84ff7e466c5b28 Image 1 (fdt@boston) Description: img,boston Device Tree Created: Sat Feb 2 07:35:18 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 3793 Bytes = 3.70 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 4799f50d688573234da6e9d7701234d394759ef4 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Sat Feb 2 07:35:18 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@ocelot_pcb123) Description: MSCC Ocelot PCB123 Device Tree Created: Sat Feb 2 07:35:18 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 4603 Bytes = 4.50 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 33e429f316125d86bb863c2fe8d9c42fbcf90bfb Image 4 (fdt@ocelot_pcb120) Description: MSCC Ocelot PCB120 Device Tree Created: Sat Feb 2 07:35:18 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 5162 Bytes = 5.04 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 0c5db3f23ba8b80fafd8c8e4eacfcb8ad62a91ae Image 5 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Sat Feb 2 07:35:18 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 509ce58e44c561d54539e64e9d4b47054e696fc6 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@ocelot_pcb123) Description: Ocelot Linux kernel Kernel: kernel@0 FDT: fdt@ocelot_pcb123 Configuration 4 (conf@ocelot_pcb120) Description: Ocelot Linux kernel Kernel: kernel@0 FDT: fdt@ocelot_pcb120 Configuration 5 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/linus_mips-allmodconfig_mipsel # Build took: 0:14:50.106699