# git rev-parse -q --verify c228d294f2040c3a5f5965ff04d4947d0bf6e7da^{commit} c228d294f2040c3a5f5965ff04d4947d0bf6e7da already have revision, skipping fetch # git checkout -q -f -B kisskb c228d294f2040c3a5f5965ff04d4947d0bf6e7da # git clean -qxdf # < git log -1 # commit c228d294f2040c3a5f5965ff04d4947d0bf6e7da # Author: Linus Torvalds # Date: Thu Jan 31 11:10:20 2019 -0800 # # x86: explicitly align IO accesses in memcpy_{to,from}io # # In commit 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # I made our copy from IO space use a separate copy routine rather than # rely on the generic memcpy. I did that because our generic memory copy # isn't actually well-defined when it comes to internal access ordering or # alignment, and will in fact depend on various CPUID flags. # # In particular, the default memcpy() for a modern Intel CPU will # generally be just a "rep movsb", which works reasonably well for # medium-sized memory copies of regular RAM, since the CPU will turn it # into fairly optimized microcode. # # However, for non-cached memory and IO, "rep movs" ends up being # horrendously slow and will just do the architectural "one byte at a # time" accesses implied by the movsb. # # At the other end of the spectrum, if you _don't_ end up using the "rep # movsb" code, you'd likely fall back to the software copy, which does # overlapping accesses for the tail, and may copy things backwards. # Again, for regular memory that's fine, for IO memory not so much. # # The thinking was that clearly nobody really cared (because things # worked), but some people had seen horrible performance due to the byte # accesses, so let's just revert back to our long ago version that dod # "rep movsl" for the bulk of the copy, and then fixed up the potentially # last few bytes of the tail with "movsw/b". # # Interestingly (and perhaps not entirely surprisingly), while that was # our original memory copy implementation, and had been used before for # IO, in the meantime many new users of memcpy_*io() had come about. And # while the access patterns for the memory copy weren't well-defined (so # arguably _any_ access pattern should work), in practice the "rep movsb" # case had been very common for the last several years. # # In particular Jarkko Sakkinen reported that the memcpy_*io() change # resuled in weird errors from his Geminilake NUC TPM module. # # And it turns out that the TPM TCG accesses according to spec require # that the accesses be # # (a) done strictly sequentially # # (b) be naturally aligned # # otherwise the TPM chip will abort the PCI transaction. # # And, in fact, the tpm_crb.c driver did this: # # memcpy_fromio(buf, priv->rsp, 6); # ... # memcpy_fromio(&buf[6], &priv->rsp[6], expected - 6); # # which really should never have worked in the first place, but back # before commit 170d13ca3a2f it *happened* to work, because the # memcpy_fromio() would be expanded to a regular memcpy, and # # (a) gcc would expand the first memcpy in-line, and turn it into a # 4-byte and a 2-byte read, and they happened to be in the right # order, and the alignment was right. # # (b) gcc would call "memcpy()" for the second one, and the machines that # had this TPM chip also apparently ended up always having ERMS # ("Enhanced REP MOVSB/STOSB instructions"), so we'd use the "rep # movbs" for that copy. # # In other words, basically by pure luck, the code happened to use the # right access sizes in the (two different!) memcpy() implementations to # make it all work. # # But after commit 170d13ca3a2f, both of the memcpy_fromio() calls # resulted in a call to the routine with the consistent memory accesses, # and in both cases it started out transferring with 4-byte accesses. # Which worked for the first copy, but resulted in the second copy doing a # 32-bit read at an address that was only 2-byte aligned. # # Jarkko is actually fixing the fragile code in the TPM driver, but since # this is an excellent example of why we absolutely must not use a generic # memcpy for IO accesses, _and_ an IO-specific one really should strive to # align the IO accesses, let's do exactly that. # # Side note: Jarkko also noted that the driver had been used on ARM # platforms, and had worked. That was because on 32-bit ARM, memcpy_*io() # ends up always doing byte accesses, and on 64-bit ARM it first does byte # accesses to align to 8-byte boundaries, and then does 8-byte accesses # for the bulk. # # So ARM actually worked by design, and the x86 case worked by pure luck. # # We *might* want to make x86-64 do the 8-byte case too. That should be a # pretty straightforward extension, but let's do one thing at a time. And # generally MMIO accesses aren't really all that performance-critical, as # shown by the fact that for a long time we just did them a byte at a # time, and very few people ever noticed. # # Reported-and-tested-by: Jarkko Sakkinen # Tested-by: Jerry Snitselaar # Cc: David Laight # Fixes: 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 c228d294f2040c3a5f5965ff04d4947d0bf6e7da # < make -s -j 80 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 80 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- oldconfig yes: standard output: Broken pipe # make -s -j 80 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1318:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1321:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1324:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1327:2: warning: #warning syscall statx not implemented [-Wcpp] :1333:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:85: Warning: overflow in branch to __restore_all; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:204: Warning: overflow in branch to syscall_call; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:352: Warning: overflow in branch to syscall_trace_entry; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:354: Warning: overflow in branch to syscall_trace_entry; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:385: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh2/../../entry-common.S:388: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/clock.c: In function 'clk_init': /kisskb/src/arch/sh/kernel/cpu/clock.c:22:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] In file included from /kisskb/src/arch/sh/math-emu/math.c:23:0: /kisskb/src/include/math-emu/single.h:50:21: warning: "__BIG_ENDIAN" is not defined [-Wundef] In file included from /kisskb/src/arch/sh/math-emu/math.c:24:0: /kisskb/src/include/math-emu/double.h:59:21: warning: "__BIG_ENDIAN" is not defined [-Wundef] /kisskb/src/arch/sh/math-emu/math.c:54:0: warning: "WRITE" redefined [enabled by default] /kisskb/src/include/linux/kernel.h:66:0: note: this is the location of the previous definition /kisskb/src/arch/sh/math-emu/math.c:55:0: warning: "READ" redefined [enabled by default] /kisskb/src/include/linux/kernel.h:65:0: note: this is the location of the previous definition /kisskb/src/arch/sh/math-emu/math.c: In function 'ffloat': /kisskb/src/arch/sh/math-emu/math.c:294:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:294:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:296:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:296:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c: In function 'ftrc': /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c: At top level: /kisskb/src/arch/sh/math-emu/math.c:505:12: warning: 'ieee_fpe_handler' defined but not used [-Wunused-function] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dynroot.c: In function 'afs_lookup_atcell': /kisskb/src/fs/afs/dynroot.c:126:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/drivers/serial-u16550.c: In function 'snd_serial_probe': /kisskb/src/sound/drivers/serial-u16550.c:959:6: warning: 'uart' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/pci/hda/patch_ca0132.c: In function 'ca0132_free': /kisskb/src/sound/pci/hda/patch_ca0132.c:8455:3: error: implicit declaration of function 'pci_iounmap' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:277: sound/pci/hda/patch_ca0132.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [/kisskb/src/scripts/Makefile.build:492: sound/pci/hda] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:492: sound/pci] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/fs/f2fs/file.c: In function 'f2fs_precache_extents': /kisskb/src/fs/f2fs/file.c:2937:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c: In function 'arizona_hw_params': /kisskb/src/sound/soc/codecs/arizona.c:1893:3: warning: 'aif_rx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c:1890:3: warning: 'aif_tx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_extent_item': /kisskb/src/fs/btrfs/ref-verify.c:503:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_leaf': /kisskb/src/fs/btrfs/ref-verify.c:555:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/clk/sunxi-ng/ccu_mux.c: In function 'ccu_mux_helper_determine_rate': /kisskb/src/drivers/clk/sunxi-ng/ccu_mux.c:153:22: warning: 'best_parent' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work': /kisskb/src/sound/soc/codecs/da7219-aad.c:321:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/trace/trace_dynevent.c: In function 'create_dyn_event': /kisskb/src/kernel/trace/trace_dynevent.c:89:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/net/bridge/br_netlink.c: In function 'br_process_vlan_info': /kisskb/src/net/bridge/br_netlink.c:591:10: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ncsi/ncsi-manage.c: In function 'set_one_vid': /kisskb/src/net/ncsi/ncsi-manage.c:676:19: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/sound/soc/codecs/rt5665.c: In function 'rt5665_i2s_pin_event': /kisskb/src/sound/soc/codecs/rt5665.c:2666:33: warning: 'val2' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c:2663:33: warning: 'val1' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_handle_pwr_constr': /kisskb/src/net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/fs/ocfs2/file.c:2386:3: warning: value computed is not used [-Wunused-value] /kisskb/src/net/mac80211/mesh_pathtbl.c: In function 'mesh_path_add': /kisskb/src/net/mac80211/mesh_pathtbl.c:417:28: warning: 'new_mpath' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c: In function '__ip6_append_data.isra.4': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c:1270:14: note: 'extra_uref' was declared here /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] make[1]: *** [/kisskb/src/Makefile:1043: sound] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/hwmon/w83627ehf.c: In function 'sensors_w83627ehf_init': /kisskb/src/drivers/hwmon/w83627ehf.c:2835:30: warning: 'address' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mfd/htc-pasic3.c: In function 'pasic3_remove': /kisskb/src/drivers/mfd/htc-pasic3.c:189:22: warning: unused variable 'asic' [-Wunused-variable] /kisskb/src/drivers/net/arcnet/arc-rimi.c: In function 'arc_rimi_exit': /kisskb/src/drivers/net/arcnet/arc-rimi.c:346:23: warning: unused variable 'lp' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/8390/ax88796.c: In function 'ax_remove': /kisskb/src/drivers/net/ethernet/8390/ax88796.c:811:20: warning: unused variable 'ei_local' [-Wunused-variable] /kisskb/src/drivers/net/can/cc770/cc770_platform.c: In function 'cc770_platform_remove': /kisskb/src/drivers/net/can/cc770/cc770_platform.c:244:21: warning: unused variable 'priv' [-Wunused-variable] /kisskb/src/drivers/thermal/broadcom/ns-thermal.c: In function 'ns_thermal_remove': /kisskb/src/drivers/thermal/broadcom/ns-thermal.c:81:21: warning: unused variable 'ns_thermal' [-Wunused-variable] /kisskb/src/drivers/soc/qcom/rpmh.c: In function 'rpmh_write_batch': /kisskb/src/drivers/soc/qcom/rpmh.c:355:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/fujitsu/fmvj18x_cs.c: In function 'fjn_start_xmit': /kisskb/src/drivers/net/ethernet/fujitsu/fmvj18x_cs.c:818:17: warning: unused variable 'buf' [-Wunused-variable] /kisskb/src/drivers/staging/iio/adc/ad7606_par.c: In function 'ad7606_par16_read_block': /kisskb/src/drivers/staging/iio/adc/ad7606_par.c:22:23: warning: unused variable 'st' [-Wunused-variable] /kisskb/src/drivers/staging/iio/adc/ad7606_par.c: In function 'ad7606_par8_read_block': /kisskb/src/drivers/staging/iio/adc/ad7606_par.c:37:23: warning: unused variable 'st' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/freescale/fsl_pq_mdio.c: In function 'fsl_pq_mdio_remove': /kisskb/src/drivers/net/ethernet/freescale/fsl_pq_mdio.c:523:27: warning: unused variable 'priv' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/smsc/smc91c92_cs.c: In function 'smc91c92_release': /kisskb/src/drivers/net/ethernet/smsc/smc91c92_cs.c:958:23: warning: unused variable 'smc' [-Wunused-variable] /kisskb/src/drivers/net/ethernet/smsc/smc911x.c: In function 'smc911x_drv_remove': /kisskb/src/drivers/net/ethernet/smsc/smc911x.c:2128:24: warning: unused variable 'lp' [-Wunused-variable] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1846:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1536:34: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1756:46: note: 'linear' was declared here /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach': /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c:922:2: warning: value computed is not used [-Wunused-value] /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_rf_ctl_override_rev7': /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c:203:21: warning: 'val_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c: In function 'airo_read_stats': /kisskb/src/drivers/net/wireless/cisco/airo.c:2250:48: warning: '*((void *)&stats_rid+180)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2250:48: warning: '*((void *)&stats_rid+176)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2250:72: warning: '*((void *)&stats_rid+184)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2252:48: warning: '*((void *)&stats_rid+160)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2252:48: warning: '*((void *)&stats_rid+164)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2252:72: warning: '*((void *)&stats_rid+168)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2254:22: warning: '*((void *)&stats_rid+372)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2255:22: warning: '*((void *)&stats_rid+368)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2256:46: warning: '*((void *)&stats_rid+4)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2256:46: warning: '*((void *)&stats_rid+12)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2256:69: warning: '*((void *)&stats_rid+16)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2257:31: warning: '*((void *)&stats_rid+20)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2258:47: warning: '*((void *)&stats_rid+172)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2261:24: warning: '*((void *)&stats_rid+360)' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c: In function 'airo_get_freq': /kisskb/src/drivers/net/wireless/cisco/airo.c:5826:5: warning: 'status_rid.channel' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c: In function 'airo_read_wireless_stats': /kisskb/src/drivers/net/wireless/cisco/airo.c:7707:23: warning: 'status_rid.mode' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:7712:20: warning: 'status_rid.sigQuality' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:7715:27: warning: 'status_rid.normalizedSignalStrength' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:5736:6: warning: 'status_rid.signalQuality' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:7690:12: note: 'status_rid.signalQuality' was declared here /kisskb/src/drivers/net/wireless/cisco/airo.c:7722:5: warning: 'status_rid.len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:7723:28: warning: 'status_rid.noisedBm' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c: In function '_init_airo_card.constprop.31': /kisskb/src/drivers/net/wireless/cisco/airo.c:2865:37: warning: 'cap_rid.softCap' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2868:2: warning: 'cap_rid.softVer' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c:2868:2: warning: 'cap_rid.softSubVer' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/cisco/airo.c: In function 'get_wep_tx_idx': /kisskb/src/drivers/net/wireless/cisco/airo.c:5186:6: warning: 'wkr.kindex' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8723a_phy_lc_calibrate': /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3485:23: warning: 'rf_amode' may be used uninitialized in this function [-Wuninitialized] make: *** [Makefile:152: sub-make] Error 2 Command 'make -s -j 80 ARCH=sh O=/kisskb/build/linus_sh-allmodconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_sh-allmodconfig_sh4 # Build took: 0:06:39.420963