# git rev-parse -q --verify c228d294f2040c3a5f5965ff04d4947d0bf6e7da^{commit} c228d294f2040c3a5f5965ff04d4947d0bf6e7da already have revision, skipping fetch # git checkout -q -f -B kisskb c228d294f2040c3a5f5965ff04d4947d0bf6e7da # git clean -qxdf # < git log -1 # commit c228d294f2040c3a5f5965ff04d4947d0bf6e7da # Author: Linus Torvalds # Date: Thu Jan 31 11:10:20 2019 -0800 # # x86: explicitly align IO accesses in memcpy_{to,from}io # # In commit 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # I made our copy from IO space use a separate copy routine rather than # rely on the generic memcpy. I did that because our generic memory copy # isn't actually well-defined when it comes to internal access ordering or # alignment, and will in fact depend on various CPUID flags. # # In particular, the default memcpy() for a modern Intel CPU will # generally be just a "rep movsb", which works reasonably well for # medium-sized memory copies of regular RAM, since the CPU will turn it # into fairly optimized microcode. # # However, for non-cached memory and IO, "rep movs" ends up being # horrendously slow and will just do the architectural "one byte at a # time" accesses implied by the movsb. # # At the other end of the spectrum, if you _don't_ end up using the "rep # movsb" code, you'd likely fall back to the software copy, which does # overlapping accesses for the tail, and may copy things backwards. # Again, for regular memory that's fine, for IO memory not so much. # # The thinking was that clearly nobody really cared (because things # worked), but some people had seen horrible performance due to the byte # accesses, so let's just revert back to our long ago version that dod # "rep movsl" for the bulk of the copy, and then fixed up the potentially # last few bytes of the tail with "movsw/b". # # Interestingly (and perhaps not entirely surprisingly), while that was # our original memory copy implementation, and had been used before for # IO, in the meantime many new users of memcpy_*io() had come about. And # while the access patterns for the memory copy weren't well-defined (so # arguably _any_ access pattern should work), in practice the "rep movsb" # case had been very common for the last several years. # # In particular Jarkko Sakkinen reported that the memcpy_*io() change # resuled in weird errors from his Geminilake NUC TPM module. # # And it turns out that the TPM TCG accesses according to spec require # that the accesses be # # (a) done strictly sequentially # # (b) be naturally aligned # # otherwise the TPM chip will abort the PCI transaction. # # And, in fact, the tpm_crb.c driver did this: # # memcpy_fromio(buf, priv->rsp, 6); # ... # memcpy_fromio(&buf[6], &priv->rsp[6], expected - 6); # # which really should never have worked in the first place, but back # before commit 170d13ca3a2f it *happened* to work, because the # memcpy_fromio() would be expanded to a regular memcpy, and # # (a) gcc would expand the first memcpy in-line, and turn it into a # 4-byte and a 2-byte read, and they happened to be in the right # order, and the alignment was right. # # (b) gcc would call "memcpy()" for the second one, and the machines that # had this TPM chip also apparently ended up always having ERMS # ("Enhanced REP MOVSB/STOSB instructions"), so we'd use the "rep # movbs" for that copy. # # In other words, basically by pure luck, the code happened to use the # right access sizes in the (two different!) memcpy() implementations to # make it all work. # # But after commit 170d13ca3a2f, both of the memcpy_fromio() calls # resulted in a call to the routine with the consistent memory accesses, # and in both cases it started out transferring with 4-byte accesses. # Which worked for the first copy, but resulted in the second copy doing a # 32-bit read at an address that was only 2-byte aligned. # # Jarkko is actually fixing the fragile code in the TPM driver, but since # this is an excellent example of why we absolutely must not use a generic # memcpy for IO accesses, _and_ an IO-specific one really should strive to # align the IO accesses, let's do exactly that. # # Side note: Jarkko also noted that the driver had been used on ARM # platforms, and had worked. That was because on 32-bit ARM, memcpy_*io() # ends up always doing byte accesses, and on 64-bit ARM it first does byte # accesses to align to 8-byte boundaries, and then does 8-byte accesses # for the bulk. # # So ARM actually worked by design, and the x86 case worked by pure luck. # # We *might* want to make x86-64 do the 8-byte case too. That should be a # pretty straightforward extension, but let's do one thing at a time. And # generally MMIO accesses aren't really all that performance-critical, as # shown by the fact that for a long time we just did them a byte at a # time, and very few people ever noticed. # # Reported-and-tested-by: Jarkko Sakkinen # Tested-by: Jerry Snitselaar # Cc: David Laight # Fixes: 170d13ca3a2f ("x86: re-introduce non-generic memcpy_{to,from}io") # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld --version # < git log --format=%s --max-count=1 c228d294f2040c3a5f5965ff04d4947d0bf6e7da # < make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- allmodconfig WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_SAMPLES=n # yes \n | make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m68k-allmodconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux- WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES Depends on [n]: DISCONTIGMEM [=n] || NUMA Selected by [y]: - SINGLE_MEMORY_CHUNK [=y] && MMU [=y] :1240:2: warning: #warning syscall seccomp not implemented [-Wcpp] :1318:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1321:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1324:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1333:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1336:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/arch/m68k/atari/config.c: In function 'atari_switches_setup': /kisskb/src/arch/m68k/atari/config.c:151:2: warning: variable length array 'switches' is used [-Wvla] /kisskb/src/arch/m68k/kernel/signal.c: In function 'mangle_kernel_stack': /kisskb/src/arch/m68k/kernel/signal.c:654:3: warning: variable length array 'buf' is used [-Wvla] /kisskb/src/arch/m68k/mvme147/config.c: In function 'mvme147_hwclk': /kisskb/src/arch/m68k/mvme147/config.c:150:2: warning: #warning check me! [-Wcpp] /kisskb/src/arch/m68k/mvme16x/config.c: In function 'mvme16x_hwclk': /kisskb/src/arch/m68k/mvme16x/config.c:397:2: warning: #warning check me! [-Wcpp] /kisskb/src/arch/m68k/mvme16x/config.c:397:2: warning: #warning check me! [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dynroot.c: In function 'afs_lookup_atcell': /kisskb/src/fs/afs/dynroot.c:126:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] ./usr/include/asm/bootinfo-amiga.h:18: found __[us]{8,16,32,64} type without #include /kisskb/src/kernel/acct.c: In function 'acct_pin_kill': /kisskb/src/kernel/acct.c:177:2: warning: value computed is not used [-Wunused-value] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/memcontrol.c: In function 'invalidate_reclaim_iterators': /kisskb/src/mm/memcontrol.c:1047:5: warning: value computed is not used [-Wunused-value] In file included from /kisskb/src/drivers/block/paride/bpck6.c:33:0: /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_select': /kisskb/src/drivers/block/paride/ppc6lnx.c:131:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:142:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:144:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:145:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:146:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:147:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:162:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:201:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_deselect': /kisskb/src/drivers/block/paride/ppc6lnx.c:217:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_send_cmd': /kisskb/src/drivers/block/paride/ppc6lnx.c:235:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_wr_data_byte': /kisskb/src/drivers/block/paride/ppc6lnx.c:266:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_rd_data_byte': /kisskb/src/drivers/block/paride/ppc6lnx.c:329:11: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_rd_data_blk': /kisskb/src/drivers/block/paride/ppc6lnx.c:430:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c: In function 'ppc6_wr_data_blk': /kisskb/src/drivers/block/paride/ppc6lnx.c:537:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:560:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/block/paride/ppc6lnx.c:575:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/fs/btrfs/qgroup.c: In function 'adjust_slots_upwards': /kisskb/src/fs/btrfs/qgroup.c:1715:18: warning: array subscript is below array bounds [-Warray-bounds] /kisskb/src/fs/btrfs/qgroup.c:1716:17: warning: array subscript is below array bounds [-Warray-bounds] /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/net/core/filter.c:3470:4: warning: value computed is not used [-Wunused-value] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_extent_item.isra.6': /kisskb/src/fs/btrfs/ref-verify.c:503:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/btrfs/ref-verify.c: In function 'process_leaf': /kisskb/src/fs/btrfs/ref-verify.c:555:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_process_vlan_info': /kisskb/src/net/bridge/br_netlink.c:591:10: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ncsi/ncsi-manage.c: In function 'set_one_vid': /kisskb/src/net/ncsi/ncsi-manage.c:661:5: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c: In function 'arizona_hw_params': /kisskb/src/sound/soc/codecs/arizona.c:1893:3: warning: 'aif_rx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c:1890:3: warning: 'aif_tx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/file.c: In function 'f2fs_precache_extents': /kisskb/src/fs/f2fs/file.c:2937:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_handle_pwr_constr.isra.34': /kisskb/src/net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work': /kisskb/src/sound/soc/codecs/da7219-aad.c:321:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/joystick/analog.c:172:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c: In function '__arm_v7s_map': /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:473:2: warning: 'cptep' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c: In function 'rt5665_i2s_pin_event': /kisskb/src/sound/soc/codecs/rt5665.c:2666:33: warning: 'val2' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c:2663:33: warning: 'val1' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/fs/nfs/nfs3acl.c: In function 'nfs3_abort_get_acl': /kisskb/src/fs/nfs/nfs3acl.c:44:2: warning: value computed is not used [-Wunused-value] /kisskb/src/drivers/hwmon/sch56xx-common.c: In function 'sch56xx_send_cmd': /kisskb/src/drivers/hwmon/sch56xx-common.c:145:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/hwmon/smsc47b397.c: In function 'smsc47b397_read_value': /kisskb/src/drivers/hwmon/smsc47b397.c:119:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_write': /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:34:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c: In function 'byteblaster_read': /kisskb/src/drivers/misc/altera-stapl/altera-lpt.c:40:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/fs/reiserfs/stree.c: In function 'search_by_key': /kisskb/src/fs/reiserfs/stree.c:812:1: warning: the frame size of 1052 bytes is larger than 1024 bytes [-Wframe-larger-than=] /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/fs/ocfs2/file.c:2386:3: warning: value computed is not used [-Wunused-value] /kisskb/src/fs/posix_acl.c: In function 'get_acl': /kisskb/src/fs/posix_acl.c:147:3: warning: value computed is not used [-Wunused-value] /kisskb/src/drivers/soc/qcom/rpmh.c: In function 'rpmh_write_batch': /kisskb/src/drivers/soc/qcom/rpmh.c:355:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/8390/wd.c: In function 'wd_probe1': /kisskb/src/drivers/net/ethernet/8390/wd.c:289:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/net/ethernet/8390/wd.c:296:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:201:12: warning: '__ei_open' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:230:12: warning: '__ei_close' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:254:13: warning: '__ei_tx_timeout' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:300:20: warning: '__ei_start_xmit' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:509:13: warning: '__ei_poll' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:850:33: warning: '__ei_get_stats' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:950:13: warning: '__ei_set_multicast_list' defined but not used [-Wunused-function] /kisskb/src/drivers/net/ethernet/8390/lib8390.c:988:27: warning: '____alloc_ei_netdev' defined but not used [-Wunused-function] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1846:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1756:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_rf_ctl_override_rev7': /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c:203:21: warning: 'val_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_byte_out': /kisskb/src/drivers/scsi/ppa.c:245:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_byte_in': /kisskb/src/drivers/scsi/ppa.c:257:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_d_pulse': /kisskb/src/drivers/scsi/ppa.c:379:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_c_pulse': /kisskb/src/drivers/scsi/ppa.c:399:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/ppa.c: In function 'ppa_select': /kisskb/src/drivers/scsi/ppa.c:436:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/ppa.c:439:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c: In function 'imm_negotiate': /kisskb/src/drivers/scsi/imm.c:247:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c: In function 'imm_byte_out': /kisskb/src/drivers/scsi/imm.c:303:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:305:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c: In function 'imm_byte_in': /kisskb/src/drivers/scsi/imm.c:341:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c: In function 'imm_cpp': /kisskb/src/drivers/scsi/imm.c:461:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:463:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:465:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:467:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:470:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:473:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:486:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c:494:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/scsi/imm.c: In function 'imm_select': /kisskb/src/drivers/scsi/imm.c:563:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] In file included from /kisskb/src/drivers/tty/rocket.c:81:0: /kisskb/src/drivers/tty/rocket_int.h: In function 'sOutB': /kisskb/src/drivers/tty/rocket_int.h:46:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h: In function 'sOutW': /kisskb/src/drivers/tty/rocket_int.h:54:2: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h: In function 'sInB': /kisskb/src/drivers/tty/rocket_int.h:68:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h: In function 'sInW': /kisskb/src/drivers/tty/rocket_int.h:73:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h:73:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h:73:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/tty/rocket_int.h:73:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8723a_phy_lc_calibrate': /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3485:23: warning: 'rf_amode' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/media/platform/fsl-viu.c:41:0: warning: "out_be32" redefined [enabled by default] /kisskb/src/arch/m68k/include/asm/raw_io.h:32:0: note: this is the location of the previous definition /kisskb/src/drivers/media/platform/fsl-viu.c:42:0: warning: "in_be32" redefined [enabled by default] /kisskb/src/arch/m68k/include/asm/raw_io.h:23:0: note: this is the location of the previous definition /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach': /kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c:922:2: warning: value computed is not used [-Wunused-value] Completed OK # rm -rf /kisskb/build/linus_m68k-allmodconfig_m68k # Build took: 0:06:01.418621