# git rev-parse -q --verify bc13f05ffaf016d42536571c2e9173f85cefd47a^{commit}
bc13f05ffaf016d42536571c2e9173f85cefd47a
already have revision, skipping fetch
# git checkout -q -f -B kisskb bc13f05ffaf016d42536571c2e9173f85cefd47a
# git clean -qxdf
# < git log -1
# commit bc13f05ffaf016d42536571c2e9173f85cefd47a
# Author: Michael Ellerman <mpe@ellerman.id.au>
# Date:   Thu Feb 14 11:08:29 2019 +1100
# 
#     powerpc/ptrace: Simplify vr_get/set() to avoid GCC warning
#     
#     GCC 8 warns about the logic in vr_get/set(), which with -Werror breaks
#     the build:
#     
#       In function ‘user_regset_copyin’,
#           inlined from ‘vr_set’ at arch/powerpc/kernel/ptrace.c:628:9:
#       include/linux/regset.h:295:4: error: ‘memcpy’ offset [-527, -529] is
#       out of the bounds [0, 16] of object ‘vrsave’ with type ‘union
#       <anonymous>’ [-Werror=array-bounds]
#       arch/powerpc/kernel/ptrace.c: In function ‘vr_set’:
#       arch/powerpc/kernel/ptrace.c:623:5: note: ‘vrsave’ declared here
#          } vrsave;
#     
#     This has been identified as a regression in GCC, see GCC bug 88273.
#     
#     However we can avoid the warning and also simplify the logic and make
#     it more robust.
#     
#     Currently we pass -1 as end_pos to user_regset_copyout(). This says
#     "copy up to the end of the regset".
#     
#     The definition of the regset is:
#             [REGSET_VMX] = {
#                     .core_note_type = NT_PPC_VMX, .n = 34,
#                     .size = sizeof(vector128), .align = sizeof(vector128),
#                     .active = vr_active, .get = vr_get, .set = vr_set
#             },
#     
#     The end is calculated as (n * size), ie. 34 * sizeof(vector128).
#     
#     In vr_get/set() we pass start_pos as 33 * sizeof(vector128), meaning
#     we can copy up to sizeof(vector128) into/out-of vrsave.
#     
#     The on-stack vrsave is defined as:
#       union {
#               elf_vrreg_t reg;
#               u32 word;
#       } vrsave;
#     
#     And elf_vrreg_t is:
#       typedef __vector128 elf_vrreg_t;
#     
#     So there is no bug, but we rely on all those sizes lining up,
#     otherwise we would have a kernel stack exposure/overwrite on our
#     hands.
#     
#     Rather than relying on that we can pass an explict end_pos based on
#     the sizeof(vrsave). The result should be exactly the same but it's
#     more obviously not over-reading/writing the stack and it avoids the
#     compiler warning.
#     
#     Reported-by: Meelis Roos <mroos@linux.ee>
#     Reported-by: Mathieu Malaterre <malat@debian.org>
#     Cc: stable@vger.kernel.org
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version
# < git log --format=%s --max-count=1 bc13f05ffaf016d42536571c2e9173f85cefd47a
# < make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_socrates_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  85xx/socrates_defconfig
# make -s -j 24 ARCH=powerpc O=/kisskb/build/powerpc-next_85xx_socrates_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read':
/kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write':
/kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here
/kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery':
/kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq':
/kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here
INFO: Uncompressed kernel (size 0x5957ac) overlaps the address of the wrapper(0x400000)
INFO: Fixing the link_address of wrapper to (0x600000)
Image Name:   Linux-5.0.0-rc2-gbc13f05ffaf0
Created:      Thu Feb 14 19:56:48 2019
Image Type:   PowerPC Linux Kernel Image (gzip compressed)
Data Size:    2833117 Bytes = 2766.72 KiB = 2.70 MiB
Load Address: 00000000
Entry Point:  00000000
Completed OK
# rm -rf /kisskb/build/powerpc-next_85xx_socrates_defconfig_powerpc-gcc4.6
# Build took: 0:00:34.337215