# git rev-parse -q --verify a58007621be33e9f7c7bed5d5ff8ecb914e1044a^{commit} a58007621be33e9f7c7bed5d5ff8ecb914e1044a already have revision, skipping fetch # git checkout -q -f -B kisskb a58007621be33e9f7c7bed5d5ff8ecb914e1044a # git clean -qxdf # < git log -1 # commit a58007621be33e9f7c7bed5d5ff8ecb914e1044a # Author: Michael Ellerman # Date: Thu Feb 14 15:00:36 2019 +1100 # # powerpc/64s: Fix possible corruption on big endian due to pgd/pud_present() # # In v4.20 we changed our pgd/pud_present() to check for _PAGE_PRESENT # rather than just checking that the value is non-zero, e.g.: # # static inline int pgd_present(pgd_t pgd) # { # - return !pgd_none(pgd); # + return (pgd_raw(pgd) & cpu_to_be64(_PAGE_PRESENT)); # } # # Unfortunately this is broken on big endian, as the result of the # bitwise & is truncated to int, which is always zero because # _PAGE_PRESENT is 0x8000000000000000ul. This means pgd_present() and # pud_present() are always false at compile time, and the compiler # elides the subsequent code. # # Remarkably with that bug present we are still able to boot and run # with few noticeable effects. However under some work loads we are able # to trigger a warning in the ext4 code: # # WARNING: CPU: 11 PID: 29593 at fs/ext4/inode.c:3927 .ext4_set_page_dirty+0x70/0xb0 # CPU: 11 PID: 29593 Comm: debugedit Not tainted 4.20.0-rc1 #1 # ... # NIP .ext4_set_page_dirty+0x70/0xb0 # LR .set_page_dirty+0xa0/0x150 # Call Trace: # .set_page_dirty+0xa0/0x150 # .unmap_page_range+0xbf0/0xe10 # .unmap_vmas+0x84/0x130 # .unmap_region+0xe8/0x190 # .__do_munmap+0x2f0/0x510 # .__vm_munmap+0x80/0x110 # .__se_sys_munmap+0x14/0x30 # system_call+0x5c/0x70 # # The fix is simple, we need to convert the result of the bitwise & to # an int before returning it. # # Thanks to Erhard, Jan Kara and Aneesh for help with debugging. # # Fixes: da7ad366b497 ("powerpc/mm/book3s: Update pmd_present to look at _PAGE_PRESENT bit") # Cc: stable@vger.kernel.org # v4.20+ # Reported-by: Erhard F. # Reviewed-by: Aneesh Kumar K.V # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-gcc --version # < /opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux-ld --version # < git log --format=%s --max-count=1 a58007621be33e9f7c7bed5d5ff8ecb914e1044a # < make -s -j 120 ARCH=arm64 O=/kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- defconfig # make -s -j 120 ARCH=arm64 O=/kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4 CROSS_COMPILE=/opt/cross/kisskb/br-aarch64-glibc-2016.08-613-ge98b4dd/bin/aarch64-linux- arch/arm64/Makefile:27: ld does not support --fix-cortex-a53-843419; kernel may be susceptible to erratum arch/arm64/Makefile:40: LSE atomics not supported by binutils /kisskb/src/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts:46.9-50.5: Warning (graph_port): /edp-panel/ports: graph port node name should be 'port' /kisskb/src/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts:25.9-29.5: Warning (graph_port): /edp-panel/ports: graph port node name should be 'port' /kisskb/src/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts:94.9-98.5: Warning (graph_port): /edp-panel/ports: graph port node name should be 'port' In file included from /kisskb/src/include/linux/rwsem.h:16:0, from /kisskb/src/include/linux/notifier.h:15, from /kisskb/src/include/linux/clk.h:17, from /kisskb/src/drivers/tty/serial/sh-sci.c:24: /kisskb/src/drivers/tty/serial/sh-sci.c: In function 'sci_submit_rx': /kisskb/src/include/linux/spinlock.h:279:3: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized] _raw_spin_unlock_irqrestore(lock, flags); \ ^ /kisskb/src/drivers/tty/serial/sh-sci.c:1338:16: note: 'flags' was declared here unsigned long flags; ^ Completed OK # rm -rf /kisskb/build/powerpc-fixes_arm64-defconfig_arm64-gcc5.4 # Build took: 0:02:22.842537