Buildresult: powerpc-next-rand/powerpc-randconfig/powerpc-gcc4.6 built on Feb 24 2019, 05:25

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Feb 24 2019, 05:25
Duration:	0:04:23.671227
Builder:	ka1
Revision:	powerpc: clean stack pointers naming (`d608898abc749424e26aa0e451d39e33cf3f4adc)`
Target:	powerpc-next-rand/powerpc-randconfig/powerpc-gcc4.6
Branch:	powerpc-next-rand
Compiler:	powerpc-gcc4.6 (powerpc-linux-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	randconfig (download)
Log:	Download original Possible warnings (64) arch/powerpc/xmon/dis-asm.h:20:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] arch/powerpc/xmon/dis-asm.h:26:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] mm/ksm.c:1393:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] arch/powerpc/include/asm/io.h:162:1: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized] arch/powerpc/include/asm/io.h:162:1: warning: 'px_cmd' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] include/linux/list.h:93:12: warning: 'head' may be used uninitialized in this function [-Wuninitialized] lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] net/ncsi/ncsi-manage.c:676:19: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] lib/rhashtable.c:264:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] include/linux/compiler.h:191:2: warning: 'sk' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] net/tipc/socket.c:1734:27: warning: 'copy' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] net/mac80211/tx.c:2502:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] net/sched/cls_flower.c:1409:1: warning: the frame size of 1104 bytes is larger than 1024 bytes [-Wframe-larger-than=] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/char/tpm/tpm-sysfs.c:37:16: warning: 'tpm_buf.data' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/misc/cxl/native.c:1248:2: warning: 'ph' may be used uninitialized in this function [-Wuninitialized] drivers/misc/cxl/native.c:1248:2: warning: 'dsisr' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/tty/serial/8250/8250_core.c:242:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/staging/erofs/data.c:237:18: warning: 'last_block' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/mtd/ubi/eba.c:1001:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/usb/misc/usbtest.c:2128:1: warning: the frame size of 1248 bytes is larger than 1024 bytes [-Wframe-larger-than=] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/usb/serial/f81534.c:247:3: warning: 'status' may be used uninitialized in this function [-Wuninitialized] drivers/usb/serial/f81534.c:286:3: warning: 'status' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/gpu/drm/drm_atomic.c:420:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized] drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized] cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] Full Log # git rev-parse -q --verify d608898abc749424e26aa0e451d39e33cf3f4adc^{commit} d608898abc749424e26aa0e451d39e33cf3f4adc already have revision, skipping fetch # git checkout -q -f -B kisskb d608898abc749424e26aa0e451d39e33cf3f4adc # git clean -qxdf # < git log -1 # commit d608898abc749424e26aa0e451d39e33cf3f4adc # Author: Christophe Leroy <christophe.leroy@c-s.fr> # Date: Sat Jan 12 09:55:53 2019 +0000 # # powerpc: clean stack pointers naming # # Some stack pointers used to also be thread_info pointers # and were called tp. Now that they are only stack pointers, # rename them sp. # # Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr> # Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 d608898abc749424e26aa0e451d39e33cf3f4adc # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0x39617EE6 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n \| make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- In file included from /kisskb/src/arch/powerpc/xmon/xmon.c:67:0: /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_powerpc': /kisskb/src/arch/powerpc/xmon/dis-asm.h:20:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_spu': /kisskb/src/arch/powerpc/xmon/dis-asm.h:26:2: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/mm/ksm.c: In function 'stable_node_dup': /kisskb/src/mm/ksm.c:1393:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/ksm.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': /kisskb/src/arch/powerpc/include/asm/io.h:162:1: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here /kisskb/src/arch/powerpc/include/asm/io.h:162:1: warning: 'px_cmd' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here /kisskb/src/drivers/ata/ahci_qoriq.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/fs/f2fs/node.c: In function '__set_nat_cache_dirty': /kisskb/src/include/linux/list.h:93:12: warning: 'head' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/node.c:237:24: note: 'head' was declared here /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/core/gen_stats.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/fs/f2fs/node.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data.isra.37': /kisskb/src/include/linux/skbuff.h:1338:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/net/ipv4/ip_output.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ncsi/ncsi-manage.c: In function 'set_one_vid': /kisskb/src/net/ncsi/ncsi-manage.c:676:19: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/ncsi/ncsi-manage.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/fs/proc/inode.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/lib/rhashtable.c: In function 'rhashtable_rehash_one': /kisskb/src/lib/rhashtable.c:264:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/sctp/output.c: In function 'sctp_packet_config': /kisskb/src/include/linux/compiler.h:191:2: warning: 'sk' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sctp/output.c:94:15: note: 'sk' was declared here /kisskb/src/net/sctp/output.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/tipc/socket.c: In function 'tipc_recvmsg': /kisskb/src/net/tipc/socket.c:1734:27: warning: 'copy' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/tipc/socket.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2502:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/tx.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/sched/cls_flower.c: In function 'fl_change': /kisskb/src/net/sched/cls_flower.c:1409:1: warning: the frame size of 1104 bytes is larger than 1024 bytes [-Wframe-larger-than=] /kisskb/src/net/sched/cls_flower.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/char/tpm/tpm-sysfs.c: In function 'pubek_show': /kisskb/src/drivers/char/tpm/tpm-sysfs.c:37:16: warning: 'tpm_buf.data' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/char/tpm/tpm-sysfs.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_handle_pwr_constr.isra.15': /kisskb/src/net/mac80211/mlme.c:1522:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/misc/cxl/native.c: In function 'native_irq_wait': /kisskb/src/drivers/misc/cxl/native.c:1248:2: warning: 'ph' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/misc/cxl/native.c:1248:2: warning: 'dsisr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/misc/cxl/native.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain': /kisskb/src/drivers/tty/serial/8250/8250_core.c:242:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/staging/erofs/data.c: In function 'erofs_raw_access_readpages': /kisskb/src/drivers/staging/erofs/data.c:237:18: warning: 'last_block' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/staging/erofs/data.c:378:14: note: 'last_block' was declared here /kisskb/src/drivers/staging/erofs/data.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:1001:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mtd/ubi/eba.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/usb/misc/usbtest.c: In function 'test_queue': /kisskb/src/drivers/usb/misc/usbtest.c:2128:1: warning: the frame size of 1248 bytes is larger than 1024 bytes [-Wframe-larger-than=] /kisskb/src/drivers/usb/misc/usbtest.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/usb/serial/f81534.c: In function 'f81534_set_register': /kisskb/src/drivers/usb/serial/f81534.c:247:3: warning: 'status' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/serial/f81534.c: In function 'f81534_get_register': /kisskb/src/drivers/usb/serial/f81534.c:286:3: warning: 'status' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/serial/f81534.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c: In function 'g94_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c: In function 'gm200_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_connector_check': /kisskb/src/drivers/gpu/drm/drm_atomic.c:420:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: At top level: cc1: warning: unrecognized command line option "-Wno-maybe-uninitialized" [enabled by default] Completed OK # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 # Build took: 0:04:23.671227

© Michael Ellerman 2006-2018.