# git rev-parse -q --verify e7140639b1de65bba435a6bd772d134901141f86^{commit} e7140639b1de65bba435a6bd772d134901141f86 already have revision, skipping fetch # git checkout -q -f -B kisskb e7140639b1de65bba435a6bd772d134901141f86 # git clean -qxdf # < git log -1 # commit e7140639b1de65bba435a6bd772d134901141f86 # Author: Nathan Chancellor # Date: Mon Feb 25 22:38:55 2019 -0700 # # powerpc/xmon: Fix opcode being uninitialized in print_insn_powerpc # # When building with -Wsometimes-uninitialized, Clang warns: # # arch/powerpc/xmon/ppc-dis.c:157:7: warning: variable 'opcode' is used # uninitialized whenever 'if' condition is false # [-Wsometimes-uninitialized] # if (cpu_has_feature(CPU_FTRS_POWER9)) # ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # arch/powerpc/xmon/ppc-dis.c:167:7: note: uninitialized use occurs here # if (opcode == NULL) # ^~~~~~ # arch/powerpc/xmon/ppc-dis.c:157:3: note: remove the 'if' if its # condition is always true # if (cpu_has_feature(CPU_FTRS_POWER9)) # ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # arch/powerpc/xmon/ppc-dis.c:132:38: note: initialize the variable # 'opcode' to silence this warning # const struct powerpc_opcode *opcode; # ^ # = NULL # 1 warning generated. # # This warning seems to make no sense on the surface because opcode is set # to NULL right below this statement. However, there is a comma instead of # semicolon to end the dialect assignment, meaning that the opcode # assignment only happens in the if statement. Properly terminate that # line so that Clang no longer warns. # # Fixes: 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation changes)") # Signed-off-by: Nathan Chancellor # Reviewed-by: Nick Desaulniers # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 e7140639b1de65bba435a6bd772d134901141f86 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ppc40x_defconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here INFO: Uncompressed kernel (size 0x53f594) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x53f594) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x53f594) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x53f594) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x52ef20) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-5.0.0-rc2-ge7140639b1de Created: Wed Feb 27 01:11:33 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2673875 Bytes = 2611.21 KiB = 2.55 MiB Load Address: 00600000 Entry Point: 006019cc Image Name: Linux-5.0.0-rc2-ge7140639b1de Created: Wed Feb 27 01:11:33 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2638107 Bytes = 2576.28 KiB = 2.52 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.0.0-rc2-ge7140639b1de Created: Wed Feb 27 01:11:33 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2672048 Bytes = 2609.42 KiB = 2.55 MiB Load Address: 00600000 Entry Point: 00601758 Completed OK # rm -rf /kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-gcc4.6 # Build took: 0:00:24.294830