# git rev-parse -q --verify e7140639b1de65bba435a6bd772d134901141f86^{commit} e7140639b1de65bba435a6bd772d134901141f86 already have revision, skipping fetch # git checkout -q -f -B kisskb e7140639b1de65bba435a6bd772d134901141f86 # git clean -qxdf # < git log -1 # commit e7140639b1de65bba435a6bd772d134901141f86 # Author: Nathan Chancellor # Date: Mon Feb 25 22:38:55 2019 -0700 # # powerpc/xmon: Fix opcode being uninitialized in print_insn_powerpc # # When building with -Wsometimes-uninitialized, Clang warns: # # arch/powerpc/xmon/ppc-dis.c:157:7: warning: variable 'opcode' is used # uninitialized whenever 'if' condition is false # [-Wsometimes-uninitialized] # if (cpu_has_feature(CPU_FTRS_POWER9)) # ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # arch/powerpc/xmon/ppc-dis.c:167:7: note: uninitialized use occurs here # if (opcode == NULL) # ^~~~~~ # arch/powerpc/xmon/ppc-dis.c:157:3: note: remove the 'if' if its # condition is always true # if (cpu_has_feature(CPU_FTRS_POWER9)) # ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ # arch/powerpc/xmon/ppc-dis.c:132:38: note: initialize the variable # 'opcode' to silence this warning # const struct powerpc_opcode *opcode; # ^ # = NULL # 1 warning generated. # # This warning seems to make no sense on the surface because opcode is set # to NULL right below this statement. However, there is a comma instead of # semicolon to end the dialect assignment, meaning that the opcode # assignment only happens in the if statement. Properly terminate that # line so that Clang no longer warns. # # Fixes: 5b102782c7f4 ("powerpc/xmon: Enable disassembly files (compilation changes)") # Signed-off-by: Nathan Chancellor # Reviewed-by: Nick Desaulniers # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 e7140639b1de65bba435a6bd772d134901141f86 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0x7735E1E4 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1263:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dir.c: In function 'afs_dir_set_page_dirty': /kisskb/src/fs/afs/dir.c:52:1: warning: no return statement in function returning non-void [-Wreturn-type] /kisskb/src/fs/afs/dynroot.c: In function 'afs_dynroot_lookup': /kisskb/src/fs/afs/dynroot.c:126:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dynroot.c:100:6: note: 'len' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1434:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.36': /kisskb/src/net/bridge/br_netlink.c:652:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/soc/qcom/rpmh.c: In function 'rpmh_write_batch': /kisskb/src/drivers/soc/qcom/rpmh.c:355:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/soc/qcom/wcnss_ctrl.c: In function 'wcnss_async_probe': /kisskb/src/drivers/soc/qcom/wcnss_ctrl.c:307:5: warning: 'expect_cbc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/string.c: In function 'strim': /kisskb/src/lib/string.c:479:8: sorry, unimplemented: inlining failed in call to 'strlen': redefined extern inline functions are not considered for inlining /kisskb/src/lib/string.c:461:7: sorry, unimplemented: called from here make[2]: *** [/kisskb/src/scripts/Makefile.build:276: lib/string.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/kisskb/src/Makefile:1042: lib] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:152: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next-rand_powerpc-randconfig_powerpc-gcc4.6 # Build took: 0:01:02.438410