# git rev-parse -q --verify a3ac7917b73070010c05b4485b8582a6c9cd69b6^{commit} a3ac7917b73070010c05b4485b8582a6c9cd69b6 already have revision, skipping fetch # git checkout -q -f -B kisskb a3ac7917b73070010c05b4485b8582a6c9cd69b6 # git clean -qxdf # < git log -1 # commit a3ac7917b73070010c05b4485b8582a6c9cd69b6 # Author: Linus Torvalds # Date: Mon Mar 25 14:49:00 2019 -0700 # # Revert "parport: daisy: use new parport device model" # # This reverts commit 1aec4211204d9463d1fd209eb50453de16254599. # # Steven Rostedt reports that it causes a hang at bootup and bisected it # to this commit. # # The troigger is apparently a module alias for "parport_lowlevel" that # points to "parport_pc", which causes a hang with # # modprobe -q -- parport_lowlevel # # blocking forever with a backtrace like this: # # wait_for_completion_killable+0x1c/0x28 # call_usermodehelper_exec+0xa7/0x108 # __request_module+0x351/0x3d8 # get_lowlevel_driver+0x28/0x41 [parport] # __parport_register_driver+0x39/0x1f4 [parport] # daisy_drv_init+0x31/0x4f [parport] # parport_bus_init+0x5d/0x7b [parport] # parport_default_proc_register+0x26/0x1000 [parport] # do_one_initcall+0xc2/0x1e0 # do_init_module+0x50/0x1d4 # load_module+0x1c2e/0x21b3 # sys_init_module+0xef/0x117 # # Supid says: # "Due to the new device model daisy driver will now try to find the # parallel ports while trying to register its driver so that it can bind # with them. Now, since daisy driver is loaded while parport bus is # initialising the list of parport is still empty and it tries to load # the lowlevel driver, which has an alias set to parport_pc, now causes # a deadlock" # # But I don't think the daisy driver should be loaded by the parport # initialization in the first place, so let's revert the whole change. # # If the daisy driver can just initialize separately on its own (like a # driver should), instead of hooking into the parport init sequence # directly, this issue probably would go away. # # Reported-and-bisected-by: Steven Rostedt (VMware) # Reported-by: Michal Kubecek # Acked-by: Greg Kroah-Hartman # Cc: Sudip Mukherjee # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-ld --version # < git log --format=%s --max-count=1 a3ac7917b73070010c05b4485b8582a6c9cd69b6 # < make -s -j 8 ARCH=arm O=/kisskb/build/linus_tct_hammer_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- tct_hammer_defconfig # make -s -j 8 ARCH=arm O=/kisskb/build/linus_tct_hammer_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/fs/fs_parser.c:413:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat] Completed OK # rm -rf /kisskb/build/linus_tct_hammer_defconfig_arm # Build took: 0:00:33.581630