# git rev-parse -q --verify a3ac7917b73070010c05b4485b8582a6c9cd69b6^{commit} a3ac7917b73070010c05b4485b8582a6c9cd69b6 already have revision, skipping fetch # git checkout -q -f -B kisskb a3ac7917b73070010c05b4485b8582a6c9cd69b6 # git clean -qxdf # < git log -1 # commit a3ac7917b73070010c05b4485b8582a6c9cd69b6 # Author: Linus Torvalds # Date: Mon Mar 25 14:49:00 2019 -0700 # # Revert "parport: daisy: use new parport device model" # # This reverts commit 1aec4211204d9463d1fd209eb50453de16254599. # # Steven Rostedt reports that it causes a hang at bootup and bisected it # to this commit. # # The troigger is apparently a module alias for "parport_lowlevel" that # points to "parport_pc", which causes a hang with # # modprobe -q -- parport_lowlevel # # blocking forever with a backtrace like this: # # wait_for_completion_killable+0x1c/0x28 # call_usermodehelper_exec+0xa7/0x108 # __request_module+0x351/0x3d8 # get_lowlevel_driver+0x28/0x41 [parport] # __parport_register_driver+0x39/0x1f4 [parport] # daisy_drv_init+0x31/0x4f [parport] # parport_bus_init+0x5d/0x7b [parport] # parport_default_proc_register+0x26/0x1000 [parport] # do_one_initcall+0xc2/0x1e0 # do_init_module+0x50/0x1d4 # load_module+0x1c2e/0x21b3 # sys_init_module+0xef/0x117 # # Supid says: # "Due to the new device model daisy driver will now try to find the # parallel ports while trying to register its driver so that it can bind # with them. Now, since daisy driver is loaded while parport bus is # initialising the list of parport is still empty and it tries to load # the lowlevel driver, which has an alias set to parport_pc, now causes # a deadlock" # # But I don't think the daisy driver should be loaded by the parport # initialization in the first place, so let's revert the whole change. # # If the daisy driver can just initialize separately on its own (like a # driver should), instead of hooking into the parport init sequence # directly, this issue probably would go away. # # Reported-and-bisected-by: Steven Rostedt (VMware) # Reported-by: Michal Kubecek # Acked-by: Greg Kroah-Hartman # Cc: Sudip Mukherjee # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 a3ac7917b73070010c05b4485b8582a6c9cd69b6 # < make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ps3_defconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:140:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[]' was declared here /kisskb/src/net/bluetooth/hidp/core.c: In function 'hidp_connection_add': /kisskb/src/net/bluetooth/hidp/core.c:1381:18: warning: 'session' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:264:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:229:28: note: 'next' was declared here /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data.isra.41': /kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/net/ipv6/ip6_output.c: In function '__ip6_append_data.isra.36': /kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c:1276:14: note: 'extra_uref' was declared here /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2515:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1581:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1538:6: note: 'pwr_level_cisco' was declared here /kisskb/src/net/sunrpc/xprtsock.c: In function 'xs_read_stream.constprop.24': /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'read' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c:498:15: note: 'read' was declared here /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c:499:10: note: 'ret' was declared here /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 # Build took: 0:01:34.268235