# git rev-parse -q --verify a3ac7917b73070010c05b4485b8582a6c9cd69b6^{commit} a3ac7917b73070010c05b4485b8582a6c9cd69b6 already have revision, skipping fetch # git checkout -q -f -B kisskb a3ac7917b73070010c05b4485b8582a6c9cd69b6 # git clean -qxdf # < git log -1 # commit a3ac7917b73070010c05b4485b8582a6c9cd69b6 # Author: Linus Torvalds # Date: Mon Mar 25 14:49:00 2019 -0700 # # Revert "parport: daisy: use new parport device model" # # This reverts commit 1aec4211204d9463d1fd209eb50453de16254599. # # Steven Rostedt reports that it causes a hang at bootup and bisected it # to this commit. # # The troigger is apparently a module alias for "parport_lowlevel" that # points to "parport_pc", which causes a hang with # # modprobe -q -- parport_lowlevel # # blocking forever with a backtrace like this: # # wait_for_completion_killable+0x1c/0x28 # call_usermodehelper_exec+0xa7/0x108 # __request_module+0x351/0x3d8 # get_lowlevel_driver+0x28/0x41 [parport] # __parport_register_driver+0x39/0x1f4 [parport] # daisy_drv_init+0x31/0x4f [parport] # parport_bus_init+0x5d/0x7b [parport] # parport_default_proc_register+0x26/0x1000 [parport] # do_one_initcall+0xc2/0x1e0 # do_init_module+0x50/0x1d4 # load_module+0x1c2e/0x21b3 # sys_init_module+0xef/0x117 # # Supid says: # "Due to the new device model daisy driver will now try to find the # parallel ports while trying to register its driver so that it can bind # with them. Now, since daisy driver is loaded while parport bus is # initialising the list of parport is still empty and it tries to load # the lowlevel driver, which has an alias set to parport_pc, now causes # a deadlock" # # But I don't think the daisy driver should be loaded by the parport # initialization in the first place, so let's revert the whole change. # # If the daisy driver can just initialize separately on its own (like a # driver should), instead of hooking into the parport init sequence # directly, this issue probably would go away. # # Reported-and-bisected-by: Steven Rostedt (VMware) # Reported-by: Michal Kubecek # Acked-by: Greg Kroah-Hartman # Cc: Sudip Mukherjee # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-ld --version # < git log --format=%s --max-count=1 a3ac7917b73070010c05b4485b8582a6c9cd69b6 # < make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- axs101_defconfig # Added to kconfig CONFIG_INITRAMFS_SOURCE="" # yes \n | make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- oldconfig yes: standard output: Broken pipe # make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- /kisskb/src/arch/arc/mm/tlb.c: In function 'do_tlb_overlap_fault': /kisskb/src/arch/arc/mm/tlb.c:914:2: warning: variable length array 'pd0' is used [-Wvla] unsigned int pd0[mmu->ways]; ^ In file included from /kisskb/src/arch/arc/include/asm/atomic.h:16:0, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/asm-generic/bitops/lock.h:5, from /kisskb/src/arch/arc/include/asm/bitops.h:429, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/wait.h:7, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/nfs/nfs3acl.c:2: /kisskb/src/fs/nfs/nfs3acl.c: In function 'nfs3_abort_get_acl': /kisskb/src/arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value] #define cmpxchg(ptr, o, n) ((typeof(*(ptr)))__cmpxchg((ptr), \ ^ /kisskb/src/fs/nfs/nfs3acl.c:44:2: note: in expansion of macro 'cmpxchg' cmpxchg(p, sentinel, ACL_NOT_CACHED); ^ /kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue': /kisskb/src/net/ipv4/tcp_input.c:4315:49: warning: array subscript is above array bounds [-Warray-bounds] tp->selective_acks[i-1] = tp->selective_acks[i]; ^ In file included from /kisskb/src/arch/arc/include/asm/atomic.h:16:0, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/asm-generic/bitops/lock.h:5, from /kisskb/src/arch/arc/include/asm/bitops.h:429, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/net/core/filter.c:24: /kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map': /kisskb/src/arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value] #define cmpxchg(ptr, o, n) ((typeof(*(ptr)))__cmpxchg((ptr), \ ^ /kisskb/src/net/core/filter.c:3481:4: note: in expansion of macro 'cmpxchg' cmpxchg(&ri->map, map, NULL); ^ /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/fs/fs_parser.c:413:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] pr_err("VALIDATE %s: e[%lu] enum val for %s\n", ^ In file included from /kisskb/src/arch/arc/include/asm/atomic.h:16:0, from /kisskb/src/include/linux/atomic.h:7, from /kisskb/src/include/asm-generic/bitops/lock.h:5, from /kisskb/src/arch/arc/include/asm/bitops.h:429, from /kisskb/src/include/linux/bitops.h:19, from /kisskb/src/include/linux/kernel.h:12, from /kisskb/src/fs/posix_acl.c:13: /kisskb/src/fs/posix_acl.c: In function 'get_acl': /kisskb/src/arch/arc/include/asm/cmpxchg.h:95:29: warning: value computed is not used [-Wunused-value] #define cmpxchg(ptr, o, n) ((typeof(*(ptr)))__cmpxchg((ptr), \ ^ /kisskb/src/fs/posix_acl.c:147:3: note: in expansion of macro 'cmpxchg' cmpxchg(p, sentinel, ACL_NOT_CACHED); ^ Completed OK # rm -rf /kisskb/build/linus_axs101_defconfig_arcompact # Build took: 0:01:46.989927