# git rev-parse -q --verify a3ac7917b73070010c05b4485b8582a6c9cd69b6^{commit} a3ac7917b73070010c05b4485b8582a6c9cd69b6 already have revision, skipping fetch # git checkout -q -f -B kisskb a3ac7917b73070010c05b4485b8582a6c9cd69b6 # git clean -qxdf # < git log -1 # commit a3ac7917b73070010c05b4485b8582a6c9cd69b6 # Author: Linus Torvalds # Date: Mon Mar 25 14:49:00 2019 -0700 # # Revert "parport: daisy: use new parport device model" # # This reverts commit 1aec4211204d9463d1fd209eb50453de16254599. # # Steven Rostedt reports that it causes a hang at bootup and bisected it # to this commit. # # The troigger is apparently a module alias for "parport_lowlevel" that # points to "parport_pc", which causes a hang with # # modprobe -q -- parport_lowlevel # # blocking forever with a backtrace like this: # # wait_for_completion_killable+0x1c/0x28 # call_usermodehelper_exec+0xa7/0x108 # __request_module+0x351/0x3d8 # get_lowlevel_driver+0x28/0x41 [parport] # __parport_register_driver+0x39/0x1f4 [parport] # daisy_drv_init+0x31/0x4f [parport] # parport_bus_init+0x5d/0x7b [parport] # parport_default_proc_register+0x26/0x1000 [parport] # do_one_initcall+0xc2/0x1e0 # do_init_module+0x50/0x1d4 # load_module+0x1c2e/0x21b3 # sys_init_module+0xef/0x117 # # Supid says: # "Due to the new device model daisy driver will now try to find the # parallel ports while trying to register its driver so that it can bind # with them. Now, since daisy driver is loaded while parport bus is # initialising the list of parport is still empty and it tries to load # the lowlevel driver, which has an alias set to parport_pc, now causes # a deadlock" # # But I don't think the daisy driver should be loaded by the parport # initialization in the first place, so let's revert the whole change. # # If the daisy driver can just initialize separately on its own (like a # driver should), instead of hooking into the parport init sequence # directly, this issue probably would go away. # # Reported-and-bisected-by: Steven Rostedt (VMware) # Reported-by: Michal Kubecek # Acked-by: Greg Kroah-Hartman # Cc: Sudip Mukherjee # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 a3ac7917b73070010c05b4485b8582a6c9cd69b6 # < make -s -j 10 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 10 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mips-gcc8 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/mips-linux/bin/mips-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] In file included from /kisskb/src/include/linux/printk.h:7, from /kisskb/src/include/linux/kernel.h:15, from /kisskb/src/include/linux/fs_context.h:15, from /kisskb/src/fs/fs_parser.c:13: /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of Header */ ^~~~~~ /kisskb/src/include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" /* error conditions */ ^~~~~~~~ /kisskb/src/include/linux/printk.h:302:9: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^~~~~~~~ /kisskb/src/fs/fs_parser.c:413:6: note: in expansion of macro 'pr_err' pr_err("VALIDATE %s: e[%lu] enum val for %s\n", ^~~~~~ /kisskb/src/fs/fs_parser.c:413:31: note: format string is defined here pr_err("VALIDATE %s: e[%lu] enum val for %s\n", ~~^ %u :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] FIT description: Linux 5.1.0-rc2-ga3ac7917b730 Created: Tue Mar 26 17:44:57 2019 Image 0 (kernel@0) Description: Linux 5.1.0-rc2-ga3ac7917b730 Created: Tue Mar 26 17:44:57 2019 Type: Kernel Image Compression: gzip compressed Data Size: 4529768 Bytes = 4423.60 KiB = 4.32 MiB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x80865f10 Hash algo: sha1 Hash value: d45dbceee956ab2f1aab1c339e009ad0399cc07c Image 1 (fdt@boston) Description: img,boston Device Tree Created: Tue Mar 26 17:44:57 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 3793 Bytes = 3.70 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 4799f50d688573234da6e9d7701234d394759ef4 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Tue Mar 26 17:44:57 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Tue Mar 26 17:44:57 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 63d058b780f65e22da30f0a183433765f1807f1d Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/linus_mips-defconfig_mips-gcc8 # Build took: 0:03:28.435964