# git rev-parse -q --verify a3ac7917b73070010c05b4485b8582a6c9cd69b6^{commit} a3ac7917b73070010c05b4485b8582a6c9cd69b6 already have revision, skipping fetch # git checkout -q -f -B kisskb a3ac7917b73070010c05b4485b8582a6c9cd69b6 # git clean -qxdf # < git log -1 # commit a3ac7917b73070010c05b4485b8582a6c9cd69b6 # Author: Linus Torvalds # Date: Mon Mar 25 14:49:00 2019 -0700 # # Revert "parport: daisy: use new parport device model" # # This reverts commit 1aec4211204d9463d1fd209eb50453de16254599. # # Steven Rostedt reports that it causes a hang at bootup and bisected it # to this commit. # # The troigger is apparently a module alias for "parport_lowlevel" that # points to "parport_pc", which causes a hang with # # modprobe -q -- parport_lowlevel # # blocking forever with a backtrace like this: # # wait_for_completion_killable+0x1c/0x28 # call_usermodehelper_exec+0xa7/0x108 # __request_module+0x351/0x3d8 # get_lowlevel_driver+0x28/0x41 [parport] # __parport_register_driver+0x39/0x1f4 [parport] # daisy_drv_init+0x31/0x4f [parport] # parport_bus_init+0x5d/0x7b [parport] # parport_default_proc_register+0x26/0x1000 [parport] # do_one_initcall+0xc2/0x1e0 # do_init_module+0x50/0x1d4 # load_module+0x1c2e/0x21b3 # sys_init_module+0xef/0x117 # # Supid says: # "Due to the new device model daisy driver will now try to find the # parallel ports while trying to register its driver so that it can bind # with them. Now, since daisy driver is loaded while parport bus is # initialising the list of parport is still empty and it tries to load # the lowlevel driver, which has an alias set to parport_pc, now causes # a deadlock" # # But I don't think the daisy driver should be loaded by the parport # initialization in the first place, so let's revert the whole change. # # If the daisy driver can just initialize separately on its own (like a # driver should), instead of hooking into the parport init sequence # directly, this issue probably would go away. # # Reported-and-bisected-by: Steven Rostedt (VMware) # Reported-by: Michal Kubecek # Acked-by: Greg Kroah-Hartman # Cc: Sudip Mukherjee # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-ld --version # < git log --format=%s --max-count=1 a3ac7917b73070010c05b4485b8582a6c9cd69b6 # < make -s -j 10 ARCH=sh O=/kisskb/build/linus_polaris_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- polaris_defconfig # make -s -j 10 ARCH=sh O=/kisskb/build/linus_polaris_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] In file included from /kisskb/src/arch/sh/math-emu/math.c:23:0: /kisskb/src/include/math-emu/single.h:50:21: warning: "__BIG_ENDIAN" is not defined [-Wundef] In file included from /kisskb/src/arch/sh/math-emu/math.c:24:0: /kisskb/src/include/math-emu/double.h:59:21: warning: "__BIG_ENDIAN" is not defined [-Wundef] /kisskb/src/arch/sh/math-emu/math.c:54:0: warning: "WRITE" redefined [enabled by default] /kisskb/src/include/linux/kernel.h:40:0: note: this is the location of the previous definition /kisskb/src/arch/sh/math-emu/math.c:55:0: warning: "READ" redefined [enabled by default] /kisskb/src/include/linux/kernel.h:39:0: note: this is the location of the previous definition /kisskb/src/arch/sh/math-emu/math.c: In function 'ffloat': /kisskb/src/arch/sh/math-emu/math.c:294:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:294:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:296:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:296:3: warning: right shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c: In function 'ftrc': /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c:310:1: warning: left shift count >= width of type [enabled by default] /kisskb/src/arch/sh/math-emu/math.c: At top level: /kisskb/src/arch/sh/math-emu/math.c:505:12: warning: 'ieee_fpe_handler' defined but not used [-Wunused-function] /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S:385: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S:388: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:121:34: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[]' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/mm/mprotect.c: In function 'change_pte_range': /kisskb/src/mm/mprotect.c:42:20: warning: unused variable 'mm' [-Wunused-variable] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data': /kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/drivers/sh/clk/cpg.c: In function 'r8': /kisskb/src/drivers/sh/clk/cpg.c:41:2: warning: passing argument 1 of 'ioread8' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:29:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r16': /kisskb/src/drivers/sh/clk/cpg.c:46:2: warning: passing argument 1 of 'ioread16' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:30:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r32': /kisskb/src/drivers/sh/clk/cpg.c:51:2: warning: passing argument 1 of 'ioread32' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:32:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/net/sunrpc/xprtsock.c: In function 'xs_stream_data_receive_workfn': /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c:499:10: note: 'ret' was declared here /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'read' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c:498:15: note: 'read' was declared here /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/fs/fs_parser.c:413:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat] Kernel: arch/sh/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_polaris_defconfig_sh4 # Build took: 0:00:55.302834