# git rev-parse -q --verify 8c7ae38d1ce12a0eaeba655df8562552b3596c7f^{commit} 8c7ae38d1ce12a0eaeba655df8562552b3596c7f already have revision, skipping fetch # git checkout -q -f -B kisskb 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # git clean -qxdf # < git log -1 # commit 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # Author: David Howells # Date: Wed Mar 27 22:48:02 2019 +0000 # # afs: Fix StoreData op marshalling # # The marshalling of AFS.StoreData, AFS.StoreData64 and YFS.StoreData64 calls # generated by ->setattr() ops for the purpose of expanding a file is # incorrect due to older documentation incorrectly describing the way the RPC # 'FileLength' parameter is meant to work. # # The older documentation says that this is the length the file is meant to # end up at the end of the operation; however, it was never implemented this # way in any of the servers, but rather the file is truncated down to this # before the write operation is effected, and never expanded to it (and, # indeed, it was renamed to 'TruncPos' in 2014). # # Fix this by setting the position parameter to the new file length and doing # a zero-lengh write there. # # The bug causes Xwayland to SIGBUS due to unexpected non-expansion of a file # it then mmaps. This can be tested by giving the following test program a # filename in an AFS directory: # # #include # #include # #include # #include # #include # int main(int argc, char *argv[]) # { # char *p; # int fd; # if (argc != 2) { # fprintf(stderr, # "Format: test-trunc-mmap \n"); # exit(2); # } # fd = open(argv[1], O_RDWR | O_CREAT | O_TRUNC); # if (fd < 0) { # perror(argv[1]); # exit(1); # } # if (ftruncate(fd, 0x140008) == -1) { # perror("ftruncate"); # exit(1); # } # p = mmap(NULL, 4096, PROT_READ | PROT_WRITE, # MAP_SHARED, fd, 0); # if (p == MAP_FAILED) { # perror("mmap"); # exit(1); # } # p[0] = 'a'; # if (munmap(p, 4096) < 0) { # perror("munmap"); # exit(1); # } # if (close(fd) < 0) { # perror("close"); # exit(1); # } # exit(0); # } # # Fixes: 31143d5d515e ("AFS: implement basic file write support") # Reported-by: Jonathan Billings # Tested-by: Jonathan Billings # Signed-off-by: David Howells # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # < make -s -j 80 ARCH=powerpc O=/kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ps3_defconfig # make -s -j 80 ARCH=powerpc O=/kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:140:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bluetooth/hidp/core.c: In function 'hidp_connection_add': /kisskb/src/net/bluetooth/hidp/core.c:1381:18: warning: 'session' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:264:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:229:28: note: 'next' was declared here /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c: In function '__ip6_append_data.isra.36': /kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv6/ip6_output.c:1276:14: note: 'extra_uref' was declared here /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data.isra.41': /kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2515:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1581:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1538:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/linus_ps3_defconfig_powerpc-gcc4.6 # Build took: 0:01:28.350962