# git rev-parse -q --verify 8c7ae38d1ce12a0eaeba655df8562552b3596c7f^{commit}
8c7ae38d1ce12a0eaeba655df8562552b3596c7f
already have revision, skipping fetch
# git checkout -q -f -B kisskb 8c7ae38d1ce12a0eaeba655df8562552b3596c7f
# git clean -qxdf
# < git log -1
# commit 8c7ae38d1ce12a0eaeba655df8562552b3596c7f
# Author: David Howells <dhowells@redhat.com>
# Date:   Wed Mar 27 22:48:02 2019 +0000
# 
#     afs: Fix StoreData op marshalling
#     
#     The marshalling of AFS.StoreData, AFS.StoreData64 and YFS.StoreData64 calls
#     generated by ->setattr() ops for the purpose of expanding a file is
#     incorrect due to older documentation incorrectly describing the way the RPC
#     'FileLength' parameter is meant to work.
#     
#     The older documentation says that this is the length the file is meant to
#     end up at the end of the operation; however, it was never implemented this
#     way in any of the servers, but rather the file is truncated down to this
#     before the write operation is effected, and never expanded to it (and,
#     indeed, it was renamed to 'TruncPos' in 2014).
#     
#     Fix this by setting the position parameter to the new file length and doing
#     a zero-lengh write there.
#     
#     The bug causes Xwayland to SIGBUS due to unexpected non-expansion of a file
#     it then mmaps.  This can be tested by giving the following test program a
#     filename in an AFS directory:
#     
#             #include <stdio.h>
#             #include <stdlib.h>
#             #include <unistd.h>
#             #include <fcntl.h>
#             #include <sys/mman.h>
#             int main(int argc, char *argv[])
#             {
#                     char *p;
#                     int fd;
#                     if (argc != 2) {
#                             fprintf(stderr,
#                                     "Format: test-trunc-mmap <file>\n");
#                             exit(2);
#                     }
#                     fd = open(argv[1], O_RDWR | O_CREAT | O_TRUNC);
#                     if (fd < 0) {
#                             perror(argv[1]);
#                             exit(1);
#                     }
#                     if (ftruncate(fd, 0x140008) == -1) {
#                             perror("ftruncate");
#                             exit(1);
#                     }
#                     p = mmap(NULL, 4096, PROT_READ | PROT_WRITE,
#                              MAP_SHARED, fd, 0);
#                     if (p == MAP_FAILED) {
#                             perror("mmap");
#                             exit(1);
#                     }
#                     p[0] = 'a';
#                     if (munmap(p, 4096) < 0) {
#                             perror("munmap");
#                             exit(1);
#                     }
#                     if (close(fd) < 0) {
#                             perror("close");
#                             exit(1);
#                     }
#                     exit(0);
#             }
#     
#     Fixes: 31143d5d515e ("AFS: implement basic file write support")
#     Reported-by: Jonathan Billings <jsbillin@umich.edu>
#     Tested-by: Jonathan Billings <jsbillin@umich.edu>
#     Signed-off-by: David Howells <dhowells@redhat.com>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-gcc --version
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-ld --version
# < git log --format=%s --max-count=1 8c7ae38d1ce12a0eaeba655df8562552b3596c7f
# < make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-  defconfig
arch/m68k/configs/multi_defconfig:333:warning: symbol value 'm' invalid for NET_DEVLINK
arch/m68k/configs/multi_defconfig:534:warning: symbol value 'm' invalid for FS_ENCRYPTION
# make -s -j 48 ARCH=m68k O=/kisskb/build/linus_m68k-defconfig_m68k CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/m68k-linux/bin/m68k-linux-  
<stdin>:1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp]
<stdin>:1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp]
<stdin>:1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp]
<stdin>:1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp]
/kisskb/src/arch/m68k/mvme16x/config.c: In function 'mvme16x_hwclk':
/kisskb/src/arch/m68k/mvme16x/config.c:397:2: warning: #warning check me! [-Wcpp]
/kisskb/src/arch/m68k/mvme147/config.c: In function 'mvme147_hwclk':
/kisskb/src/arch/m68k/mvme147/config.c:150:2: warning: #warning check me! [-Wcpp]
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/ipc/shm.c: In function 'ksys_shmdt':
/kisskb/src/ipc/shm.c:1712:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/mprotect.c: In function 'change_pte_range':
/kisskb/src/mm/mprotect.c:42:20: warning: unused variable 'mm' [-Wunused-variable]
/kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl':
/kisskb/src/lib/mpi/mpicoder.c:336:12: warning: 'buff' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic':
/kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list':
/kisskb/src/net/core/dev.c:3405:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c: In function 'proc_reg_open':
/kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here
/kisskb/src/kernel/acct.c: In function 'acct_pin_kill':
/kisskb/src/kernel/acct.c:177:2: warning: value computed is not used [-Wunused-value]
/kisskb/src/fs/ocfs2/alloc.c: In function 'ocfs2_trim_mainbm':
/kisskb/src/fs/ocfs2/alloc.c:7604:17: warning: 'first_bit' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/core/filter.c: In function 'bpf_clear_redirect_map':
/kisskb/src/net/core/filter.c:3479:4: warning: value computed is not used [-Wunused-value]
/kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter':
/kisskb/src/fs/ocfs2/file.c:2386:3: warning: value computed is not used [-Wunused-value]
/kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char':
/kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/ipv4/ip_output.c: In function '__ip_append_data.isra.40':
/kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/ipv4/ip_output.c:885:14: note: 'extra_uref' was declared here
/kisskb/src/net/ipv6/ip6_output.c: In function '__ip6_append_data.isra.38':
/kisskb/src/include/linux/skbuff.h:1397:6: warning: 'extra_uref' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/ipv6/ip6_output.c:1276:14: note: 'extra_uref' was declared here
/kisskb/src/net/sctp/output.c: In function 'sctp_packet_config':
/kisskb/src/include/net/sock.h:1949:19: warning: 'sk' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/sctp/output.c:94:15: note: 'sk' was declared here
/kisskb/src/fs/fs_parser.c: In function 'fs_validate_description':
/kisskb/src/fs/fs_parser.c:413:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat]
/kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker':
/kisskb/src/lib/rhashtable.c:264:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/lib/rhashtable.c:229:28: note: 'next' was declared here
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:201:12: warning: '__ei_open' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:230:12: warning: '__ei_close' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:254:13: warning: '__ei_tx_timeout' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:300:20: warning: '__ei_start_xmit' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:509:13: warning: '__ei_poll' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:850:33: warning: '__ei_get_stats' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:950:13: warning: '__ei_set_multicast_list' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/ethernet/8390/lib8390.c:988:27: warning: '____alloc_ei_netdev' defined but not used [-Wunused-function]
/kisskb/src/drivers/net/macsec.c: In function 'macsec_del_rxsa':
/kisskb/src/drivers/net/macsec.c:1926:2: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c:1926:2: warning: 'rx_sc' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c: In function 'macsec_del_txsa':
/kisskb/src/drivers/net/macsec.c:2003:2: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c:2003:2: warning: 'tx_sc' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c: In function 'macsec_upd_txsa':
/kisskb/src/drivers/net/macsec.c:2068:5: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c:2068:24: warning: 'tx_sc' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/macsec.c:2069:21: warning: 'secy' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/posix_acl.c: In function 'get_acl':
/kisskb/src/fs/posix_acl.c:147:3: warning: value computed is not used [-Wunused-value]
/kisskb/src/drivers/net/tun.c: In function 'tun_get_user':
/kisskb/src/drivers/net/tun.c:1842:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1535:31: warning: 'linear' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1755:46: note: 'linear' was declared here
Completed OK
# rm -rf /kisskb/build/linus_m68k-defconfig_m68k
# Build took: 0:01:30.544724