# git rev-parse -q --verify 8c7ae38d1ce12a0eaeba655df8562552b3596c7f^{commit} 8c7ae38d1ce12a0eaeba655df8562552b3596c7f already have revision, skipping fetch # git checkout -q -f -B kisskb 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # git clean -qxdf # < git log -1 # commit 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # Author: David Howells # Date: Wed Mar 27 22:48:02 2019 +0000 # # afs: Fix StoreData op marshalling # # The marshalling of AFS.StoreData, AFS.StoreData64 and YFS.StoreData64 calls # generated by ->setattr() ops for the purpose of expanding a file is # incorrect due to older documentation incorrectly describing the way the RPC # 'FileLength' parameter is meant to work. # # The older documentation says that this is the length the file is meant to # end up at the end of the operation; however, it was never implemented this # way in any of the servers, but rather the file is truncated down to this # before the write operation is effected, and never expanded to it (and, # indeed, it was renamed to 'TruncPos' in 2014). # # Fix this by setting the position parameter to the new file length and doing # a zero-lengh write there. # # The bug causes Xwayland to SIGBUS due to unexpected non-expansion of a file # it then mmaps. This can be tested by giving the following test program a # filename in an AFS directory: # # #include # #include # #include # #include # #include # int main(int argc, char *argv[]) # { # char *p; # int fd; # if (argc != 2) { # fprintf(stderr, # "Format: test-trunc-mmap \n"); # exit(2); # } # fd = open(argv[1], O_RDWR | O_CREAT | O_TRUNC); # if (fd < 0) { # perror(argv[1]); # exit(1); # } # if (ftruncate(fd, 0x140008) == -1) { # perror("ftruncate"); # exit(1); # } # p = mmap(NULL, 4096, PROT_READ | PROT_WRITE, # MAP_SHARED, fd, 0); # if (p == MAP_FAILED) { # perror("mmap"); # exit(1); # } # p[0] = 'a'; # if (munmap(p, 4096) < 0) { # perror("munmap"); # exit(1); # } # if (close(fd) < 0) { # perror("close"); # exit(1); # } # exit(0); # } # # Fixes: 31143d5d515e ("AFS: implement basic file write support") # Reported-by: Jonathan Billings # Tested-by: Jonathan Billings # Signed-off-by: David Howells # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # < make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_ppc64le_defconfig_ppc64le-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc64le_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/linus_ppc64le_defconfig_ppc64le-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/net/netfilter/nf_nat_masquerade.c:15:21: warning: 'masq_refcnt6' defined but not used [-Wunused-variable] static unsigned int masq_refcnt6 __read_mostly; ^ WARNING: vmlinux.o(.text+0x3084): Section mismatch in reference from the variable __boot_from_prom to the function .init.text:prom_init() The function __boot_from_prom() references the function __init prom_init(). This is often because __boot_from_prom lacks a __init annotation or the annotation of prom_init is wrong. WARNING: vmlinux.o(.text+0x3334): Section mismatch in reference from the variable start_here_multiplatform to the function .init.text:early_setup() The function start_here_multiplatform() references the function __init early_setup(). This is often because start_here_multiplatform lacks a __init annotation or the annotation of early_setup is wrong. WARNING: vmlinux.o(.text+0x3368): Section mismatch in reference from the variable start_here_common to the function .init.text:start_kernel() The function start_here_common() references the function __init start_kernel(). This is often because start_here_common lacks a __init annotation or the annotation of start_kernel is wrong. Completed OK # rm -rf /kisskb/build/linus_ppc64le_defconfig_ppc64le-gcc5 # Build took: 0:03:01.698848