Buildresult: linus/or1ksim_defconfig/or32-gcc9 built on Mar 29 2019, 09:19

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Mar 29 2019, 09:19
Duration:	0:00:28.260739
Builder:	ka4
Revision:	afs: Fix StoreData op marshalling (`8c7ae38d1ce12a0eaeba655df8562552b3596c7f)`
Target:	linus/or1ksim_defconfig/or32-gcc9
Branch:	linus
Compiler:	or32-gcc9 (or1k-linux-gcc (GCC) 5.4.0 / GNU ld (GNU Binutils) 2.26.20160125)
Config:	or1ksim_defconfig (download)
Log:	Download original Possible warnings (2) mm/mprotect.c:42:20: warning: unused variable 'mm' [-Wunused-variable] include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] Full Log # git rev-parse -q --verify 8c7ae38d1ce12a0eaeba655df8562552b3596c7f^{commit} 8c7ae38d1ce12a0eaeba655df8562552b3596c7f already have revision, skipping fetch # git checkout -q -f -B kisskb 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # git clean -qxdf # < git log -1 # commit 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # Author: David Howells <dhowells@redhat.com> # Date: Wed Mar 27 22:48:02 2019 +0000 # # afs: Fix StoreData op marshalling # # The marshalling of AFS.StoreData, AFS.StoreData64 and YFS.StoreData64 calls # generated by ->setattr() ops for the purpose of expanding a file is # incorrect due to older documentation incorrectly describing the way the RPC # 'FileLength' parameter is meant to work. # # The older documentation says that this is the length the file is meant to # end up at the end of the operation; however, it was never implemented this # way in any of the servers, but rather the file is truncated down to this # before the write operation is effected, and never expanded to it (and, # indeed, it was renamed to 'TruncPos' in 2014). # # Fix this by setting the position parameter to the new file length and doing # a zero-lengh write there. # # The bug causes Xwayland to SIGBUS due to unexpected non-expansion of a file # it then mmaps. This can be tested by giving the following test program a # filename in an AFS directory: # # #include <stdio.h> # #include <stdlib.h> # #include <unistd.h> # #include <fcntl.h> # #include <sys/mman.h> # int main(int argc, char argv[]) # { # char p; # int fd; # if (argc != 2) { # fprintf(stderr, # "Format: test-trunc-mmap <file>\n"); # exit(2); # } # fd = open(argv[1], O_RDWR \| O_CREAT \| O_TRUNC); # if (fd < 0) { # perror(argv[1]); # exit(1); # } # if (ftruncate(fd, 0x140008) == -1) { # perror("ftruncate"); # exit(1); # } # p = mmap(NULL, 4096, PROT_READ \| PROT_WRITE, # MAP_SHARED, fd, 0); # if (p == MAP_FAILED) { # perror("mmap"); # exit(1); # } # p[0] = 'a'; # if (munmap(p, 4096) < 0) { # perror("munmap"); # exit(1); # } # if (close(fd) < 0) { # perror("close"); # exit(1); # } # exit(0); # } # # Fixes: 31143d5d515e ("AFS: implement basic file write support") # Reported-by: Jonathan Billings <jsbillin@umich.edu> # Tested-by: Jonathan Billings <jsbillin@umich.edu> # Signed-off-by: David Howells <dhowells@redhat.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/or1k-linux-5.4.0-20170218/or1k-linux/bin/or1k-linux-gcc --version # < /opt/cross/kisskb/or1k-linux-5.4.0-20170218/or1k-linux/bin/or1k-linux-ld --version # < git log --format=%s --max-count=1 8c7ae38d1ce12a0eaeba655df8562552b3596c7f # < make -s -j 10 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32 CROSS_COMPILE=/opt/cross/kisskb/or1k-linux-5.4.0-20170218/or1k-linux/bin/or1k-linux- or1ksim_defconfig # make -s -j 10 ARCH=openrisc O=/kisskb/build/linus_or1ksim_defconfig_or32 CROSS_COMPILE=/opt/cross/kisskb/or1k-linux-5.4.0-20170218/or1k-linux/bin/or1k-linux- /kisskb/src/mm/mprotect.c: In function 'change_pte_range': /kisskb/src/mm/mprotect.c:42:20: warning: unused variable 'mm' [-Wunused-variable] struct mm_struct mm = vma->vm_mm; ^ In file included from /kisskb/src/include/linux/printk.h:7:0, from /kisskb/src/include/linux/kernel.h:15, from /kisskb/src/include/linux/fs_context.h:15, from /kisskb/src/fs/fs_parser.c:13: /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/include/linux/kern_levels.h:5:18: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat=] #define KERN_SOH "\001" / ASCII Start Of Header / ^ /kisskb/src/include/linux/kern_levels.h:11:18: note: in expansion of macro 'KERN_SOH' #define KERN_ERR KERN_SOH "3" / error conditions */ ^ /kisskb/src/include/linux/printk.h:302:9: note: in expansion of macro 'KERN_ERR' printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__) ^ /kisskb/src/fs/fs_parser.c:413:6: note: in expansion of macro 'pr_err' pr_err("VALIDATE %s: e[%lu] enum val for %s\n", ^ Completed OK # rm -rf /kisskb/build/linus_or1ksim_defconfig_or32 # Build took: 0:00:28.260739

© Michael Ellerman 2006-2018.