# git rev-parse -q --verify 10dce8af34226d90fa56746a934f8da5dcdba3df^{commit} 10dce8af34226d90fa56746a934f8da5dcdba3df already have revision, skipping fetch # git checkout -q -f -B kisskb 10dce8af34226d90fa56746a934f8da5dcdba3df # git clean -qxdf # < git log -1 # commit 10dce8af34226d90fa56746a934f8da5dcdba3df # Author: Kirill Smelkov # Date: Tue Mar 26 22:20:43 2019 +0000 # # fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock # # Commit 9c225f2655e3 ("vfs: atomic f_pos accesses as per POSIX") added # locking for file.f_pos access and in particular made concurrent read and # write not possible - now both those functions take f_pos lock for the # whole run, and so if e.g. a read is blocked waiting for data, write will # deadlock waiting for that read to complete. # # This caused regression for stream-like files where previously read and # write could run simultaneously, but after that patch could not do so # anymore. See e.g. commit 581d21a2d02a ("xenbus: fix deadlock on writes # to /proc/xen/xenbus") which fixes such regression for particular case of # /proc/xen/xenbus. # # The patch that added f_pos lock in 2014 did so to guarantee POSIX thread # safety for read/write/lseek and added the locking to file descriptors of # all regular files. In 2014 that thread-safety problem was not new as it # was already discussed earlier in 2006. # # However even though 2006'th version of Linus's patch was adding f_pos # locking "only for files that are marked seekable with FMODE_LSEEK (thus # avoiding the stream-like objects like pipes and sockets)", the 2014 # version - the one that actually made it into the tree as 9c225f2655e3 - # is doing so irregardless of whether a file is seekable or not. # # See # # https://lore.kernel.org/lkml/53022DB1.4070805@gmail.com/ # https://lwn.net/Articles/180387 # https://lwn.net/Articles/180396 # # for historic context. # # The reason that it did so is, probably, that there are many files that # are marked non-seekable, but e.g. their read implementation actually # depends on knowing current position to correctly handle the read. Some # examples: # # kernel/power/user.c snapshot_read # fs/debugfs/file.c u32_array_read # fs/fuse/control.c fuse_conn_waiting_read + ... # drivers/hwmon/asus_atk0110.c atk_debugfs_ggrp_read # arch/s390/hypfs/inode.c hypfs_read_iter # ... # # Despite that, many nonseekable_open users implement read and write with # pure stream semantics - they don't depend on passed ppos at all. And for # those cases where read could wait for something inside, it creates a # situation similar to xenbus - the write could be never made to go until # read is done, and read is waiting for some, potentially external, event, # for potentially unbounded time -> deadlock. # # Besides xenbus, there are 14 such places in the kernel that I've found # with semantic patch (see below): # # drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write() # drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write() # drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write() # drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write() # net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write() # drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write() # drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write() # drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write() # net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write() # drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write() # drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write() # drivers/input/misc/uinput.c:400:1-17: ERROR: uinput_fops: .read() can deadlock .write() # drivers/infiniband/core/user_mad.c:985:7-23: ERROR: umad_fops: .read() can deadlock .write() # drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write() # # In addition to the cases above another regression caused by f_pos # locking is that now FUSE filesystems that implement open with # FOPEN_NONSEEKABLE flag, can no longer implement bidirectional # stream-like files - for the same reason as above e.g. read can deadlock # write locking on file.f_pos in the kernel. # # FUSE's FOPEN_NONSEEKABLE was added in 2008 in a7c1b990f715 ("fuse: # implement nonseekable open") to support OSSPD. OSSPD implements /dev/dsp # in userspace with FOPEN_NONSEEKABLE flag, with corresponding read and # write routines not depending on current position at all, and with both # read and write being potentially blocking operations: # # See # # https://github.com/libfuse/osspd # https://lwn.net/Articles/308445 # # https://github.com/libfuse/osspd/blob/14a9cff0/osspd.c#L1406 # https://github.com/libfuse/osspd/blob/14a9cff0/osspd.c#L1438-L1477 # https://github.com/libfuse/osspd/blob/14a9cff0/osspd.c#L1479-L1510 # # Corresponding libfuse example/test also describes FOPEN_NONSEEKABLE as # "somewhat pipe-like files ..." with read handler not using offset. # However that test implements only read without write and cannot exercise # the deadlock scenario: # # https://github.com/libfuse/libfuse/blob/fuse-3.4.2-3-ga1bff7d/example/poll.c#L124-L131 # https://github.com/libfuse/libfuse/blob/fuse-3.4.2-3-ga1bff7d/example/poll.c#L146-L163 # https://github.com/libfuse/libfuse/blob/fuse-3.4.2-3-ga1bff7d/example/poll.c#L209-L216 # # I've actually hit the read vs write deadlock for real while implementing # my FUSE filesystem where there is /head/watch file, for which open # creates separate bidirectional socket-like stream in between filesystem # and its user with both read and write being later performed # simultaneously. And there it is semantically not easy to split the # stream into two separate read-only and write-only channels: # # https://lab.nexedi.com/kirr/wendelin.core/blob/f13aa600/wcfs/wcfs.go#L88-169 # # Let's fix this regression. The plan is: # # 1. We can't change nonseekable_open to include &~FMODE_ATOMIC_POS - # doing so would break many in-kernel nonseekable_open users which # actually use ppos in read/write handlers. # # 2. Add stream_open() to kernel to open stream-like non-seekable file # descriptors. Read and write on such file descriptors would never use # nor change ppos. And with that property on stream-like files read and # write will be running without taking f_pos lock - i.e. read and write # could be running simultaneously. # # 3. With semantic patch search and convert to stream_open all in-kernel # nonseekable_open users for which read and write actually do not # depend on ppos and where there is no other methods in file_operations # which assume @offset access. # # 4. Add FOPEN_STREAM to fs/fuse/ and open in-kernel file-descriptors via # steam_open if that bit is present in filesystem open reply. # # It was tempting to change fs/fuse/ open handler to use stream_open # instead of nonseekable_open on just FOPEN_NONSEEKABLE flags, but # grepping through Debian codesearch shows users of FOPEN_NONSEEKABLE, # and in particular GVFS which actually uses offset in its read and # write handlers # # https://codesearch.debian.net/search?q=-%3Enonseekable+%3D # https://gitlab.gnome.org/GNOME/gvfs/blob/1.40.0-6-gcbc54396/client/gvfsfusedaemon.c#L1080 # https://gitlab.gnome.org/GNOME/gvfs/blob/1.40.0-6-gcbc54396/client/gvfsfusedaemon.c#L1247-1346 # https://gitlab.gnome.org/GNOME/gvfs/blob/1.40.0-6-gcbc54396/client/gvfsfusedaemon.c#L1399-1481 # # so if we would do such a change it will break a real user. # # 5. Add stream_open and FOPEN_STREAM handling to stable kernels starting # from v3.14+ (the kernel where 9c225f2655 first appeared). # # This will allow to patch OSSPD and other FUSE filesystems that # provide stream-like files to return FOPEN_STREAM | FOPEN_NONSEEKABLE # in their open handler and this way avoid the deadlock on all kernel # versions. This should work because fs/fuse/ ignores unknown open # flags returned from a filesystem and so passing FOPEN_STREAM to a # kernel that is not aware of this flag cannot hurt. In turn the kernel # that is not aware of FOPEN_STREAM will be < v3.14 where just # FOPEN_NONSEEKABLE is sufficient to implement streams without read vs # write deadlock. # # This patch adds stream_open, converts /proc/xen/xenbus to it and adds # semantic patch to automatically locate in-kernel places that are either # required to be converted due to read vs write deadlock, or that are just # safe to be converted because read and write do not use ppos and there # are no other funky methods in file_operations. # # Regarding semantic patch I've verified each generated change manually - # that it is correct to convert - and each other nonseekable_open instance # left - that it is either not correct to convert there, or that it is not # converted due to current stream_open.cocci limitations. # # The script also does not convert files that should be valid to convert, # but that currently have .llseek = noop_llseek or generic_file_llseek for # unknown reason despite file being opened with nonseekable_open (e.g. # drivers/input/mousedev.c) # # Cc: Michael Kerrisk # Cc: Yongzhi Pan # Cc: Jonathan Corbet # Cc: David Vrabel # Cc: Juergen Gross # Cc: Miklos Szeredi # Cc: Tejun Heo # Cc: Kirill Tkhai # Cc: Arnd Bergmann # Cc: Christoph Hellwig # Cc: Greg Kroah-Hartman # Cc: Julia Lawall # Cc: Nikolaus Rath # Cc: Han-Wen Nienhuys # Signed-off-by: Kirill Smelkov # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 10dce8af34226d90fa56746a934f8da5dcdba3df # < make -s -j 120 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0xE8A3EAB0 WARNING: unmet direct dependencies detected for FSL_EMB_PERFMON Depends on [n]: E500 [=n] || PPC_83xx [=n] Selected by [y]: - PPC_FSL_BOOK3E [=y] WARNING: unmet direct dependencies detected for SND_SOC_MAX98927 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [m]: - SND_SOC_SDM845 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=m] && MFD_CROS_EC [=m] WARNING: unmet direct dependencies detected for FSL_EMB_PERFMON Depends on [n]: E500 [=n] || PPC_83xx [=n] Selected by [y]: - PPC_FSL_BOOK3E [=y] WARNING: unmet direct dependencies detected for SND_SOC_MAX98927 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [m]: - SND_SOC_SDM845 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=m] && MFD_CROS_EC [=m] # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe # make -s -j 120 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- WARNING: unmet direct dependencies detected for SND_SOC_MAX98927 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [m]: - SND_SOC_SDM845 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=m] && MFD_CROS_EC [=m] WARNING: unmet direct dependencies detected for SND_SOC_MAX98927 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [m]: - SND_SOC_SDM845 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=m] && MFD_CROS_EC [=m] WARNING: unmet direct dependencies detected for SND_SOC_MAX98927 Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=n] Selected by [m]: - SND_SOC_SDM845 [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && QCOM_APR [=m] && MFD_CROS_EC [=m] :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] In file included from /kisskb/src/arch/powerpc/xmon/xmon.c:67:0: /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_powerpc': /kisskb/src/arch/powerpc/xmon/dis-asm.h:20:9: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] printf("%.8x", insn); ^ /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_spu': /kisskb/src/arch/powerpc/xmon/dis-asm.h:26:9: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] printf("%.8x", insn); ^ /kisskb/src/arch/powerpc/kernel/eeh.c:1792:12: warning: 'proc_eeh_show' defined but not used [-Wunused-function] static int proc_eeh_show(struct seq_file *m, void *v) ^ /kisskb/src/sound/soc/codecs/max98927.c:962:1: warning: return type defaults to 'int' [-Wreturn-type] module_i2c_driver(max98927_i2c_driver) ^ /kisskb/src/sound/soc/codecs/max98927.c:962:1: error: function declaration isn't a prototype [-Werror=strict-prototypes] In file included from :0:0: /kisskb/src/sound/soc/codecs/max98927.c: In function 'module_i2c_driver': /kisskb/src/include/linux/compiler-gcc.h:71:45: error: storage class specified for parameter '__UNIQUE_ID_description16' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:224:42: note: in expansion of macro 'MODULE_INFO' #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description) ^ /kisskb/src/sound/soc/codecs/max98927.c:964:1: note: in expansion of macro 'MODULE_DESCRIPTION' MODULE_DESCRIPTION("ALSA SoC MAX98927 driver"); ^ /kisskb/src/sound/soc/codecs/max98927.c:964:1: error: parameter '__UNIQUE_ID_description16' is initialized /kisskb/src/sound/soc/codecs/max98927.c:964:1: warning: '__used__' attribute ignored [-Wattributes] In file included from :0:0: /kisskb/src/include/linux/compiler-gcc.h:71:45: error: section attribute not allowed for '__UNIQUE_ID_description16' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:224:42: note: in expansion of macro 'MODULE_INFO' #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description) ^ /kisskb/src/sound/soc/codecs/max98927.c:964:1: note: in expansion of macro 'MODULE_DESCRIPTION' MODULE_DESCRIPTION("ALSA SoC MAX98927 driver"); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: alignment may not be specified for '__UNIQUE_ID_description16' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:224:42: note: in expansion of macro 'MODULE_INFO' #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description) ^ /kisskb/src/sound/soc/codecs/max98927.c:964:1: note: in expansion of macro 'MODULE_DESCRIPTION' MODULE_DESCRIPTION("ALSA SoC MAX98927 driver"); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: storage class specified for parameter '__UNIQUE_ID_author17' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:221:32: note: in expansion of macro 'MODULE_INFO' #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) ^ /kisskb/src/sound/soc/codecs/max98927.c:965:1: note: in expansion of macro 'MODULE_AUTHOR' MODULE_AUTHOR("Ryan Lee "); ^ /kisskb/src/sound/soc/codecs/max98927.c:965:1: error: parameter '__UNIQUE_ID_author17' is initialized /kisskb/src/sound/soc/codecs/max98927.c:965:1: warning: '__used__' attribute ignored [-Wattributes] In file included from :0:0: /kisskb/src/include/linux/compiler-gcc.h:71:45: error: section attribute not allowed for '__UNIQUE_ID_author17' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:221:32: note: in expansion of macro 'MODULE_INFO' #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) ^ /kisskb/src/sound/soc/codecs/max98927.c:965:1: note: in expansion of macro 'MODULE_AUTHOR' MODULE_AUTHOR("Ryan Lee "); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: alignment may not be specified for '__UNIQUE_ID_author17' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:221:32: note: in expansion of macro 'MODULE_INFO' #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) ^ /kisskb/src/sound/soc/codecs/max98927.c:965:1: note: in expansion of macro 'MODULE_AUTHOR' MODULE_AUTHOR("Ryan Lee "); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: storage class specified for parameter '__UNIQUE_ID_license18' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:215:34: note: in expansion of macro 'MODULE_INFO' #define MODULE_LICENSE(_license) MODULE_INFO(license, _license) ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: note: in expansion of macro 'MODULE_LICENSE' MODULE_LICENSE("GPL"); ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: error: parameter '__UNIQUE_ID_license18' is initialized /kisskb/src/sound/soc/codecs/max98927.c:966:1: warning: '__used__' attribute ignored [-Wattributes] In file included from :0:0: /kisskb/src/include/linux/compiler-gcc.h:71:45: error: section attribute not allowed for '__UNIQUE_ID_license18' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:215:34: note: in expansion of macro 'MODULE_INFO' #define MODULE_LICENSE(_license) MODULE_INFO(license, _license) ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: note: in expansion of macro 'MODULE_LICENSE' MODULE_LICENSE("GPL"); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: alignment may not be specified for '__UNIQUE_ID_license18' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:215:34: note: in expansion of macro 'MODULE_INFO' #define MODULE_LICENSE(_license) MODULE_INFO(license, _license) ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: note: in expansion of macro 'MODULE_LICENSE' MODULE_LICENSE("GPL"); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: declaration for parameter '__UNIQUE_ID_license18' but no such parameter #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:215:34: note: in expansion of macro 'MODULE_INFO' #define MODULE_LICENSE(_license) MODULE_INFO(license, _license) ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: note: in expansion of macro 'MODULE_LICENSE' MODULE_LICENSE("GPL"); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: declaration for parameter '__UNIQUE_ID_author17' but no such parameter #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:221:32: note: in expansion of macro 'MODULE_INFO' #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) ^ /kisskb/src/sound/soc/codecs/max98927.c:965:1: note: in expansion of macro 'MODULE_AUTHOR' MODULE_AUTHOR("Ryan Lee "); ^ /kisskb/src/include/linux/compiler-gcc.h:71:45: error: declaration for parameter '__UNIQUE_ID_description16' but no such parameter #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:53:23: note: in definition of macro '___PASTE' #define ___PASTE(a,b) a##b ^ /kisskb/src/include/linux/compiler-gcc.h:71:29: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/compiler_types.h:54:22: note: in expansion of macro '___PASTE' #define __PASTE(a,b) ___PASTE(a,b) ^ /kisskb/src/include/linux/compiler-gcc.h:71:37: note: in expansion of macro '__PASTE' #define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__) ^ /kisskb/src/include/linux/moduleparam.h:22:19: note: in expansion of macro '__UNIQUE_ID' static const char __UNIQUE_ID(name)[] \ ^ /kisskb/src/include/linux/module.h:161:32: note: in expansion of macro '__MODULE_INFO' #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info) ^ /kisskb/src/include/linux/module.h:224:42: note: in expansion of macro 'MODULE_INFO' #define MODULE_DESCRIPTION(_description) MODULE_INFO(description, _description) ^ /kisskb/src/sound/soc/codecs/max98927.c:964:1: note: in expansion of macro 'MODULE_DESCRIPTION' MODULE_DESCRIPTION("ALSA SoC MAX98927 driver"); ^ /kisskb/src/sound/soc/codecs/max98927.c:966:1: error: expected '{' at end of input MODULE_LICENSE("GPL"); ^ /kisskb/src/sound/soc/codecs/max98927.c: At top level: /kisskb/src/sound/soc/codecs/max98927.c:951:26: warning: 'max98927_i2c_driver' defined but not used [-Wunused-variable] static struct i2c_driver max98927_i2c_driver = { ^ /kisskb/src/sound/soc/codecs/max98927.c: In function 'module_i2c_driver': /kisskb/src/sound/soc/codecs/max98927.c:966:1: warning: control reaches end of non-void function [-Wreturn-type] MODULE_LICENSE("GPL"); ^ cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:275: sound/soc/codecs/max98927.o] Error 1 make[4]: *** Waiting for unfinished jobs.... /kisskb/src/sound/soc/codecs/rt5663.c:3740:1: warning: data definition has no type or storage class module_i2c_driver(rt5663_i2c_driver); ^ /kisskb/src/sound/soc/codecs/rt5663.c:3740:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int] /kisskb/src/sound/soc/codecs/rt5663.c:3740:1: warning: parameter names (without types) in function declaration /kisskb/src/sound/soc/codecs/rt5663.c:3729:26: warning: 'rt5663_i2c_driver' defined but not used [-Wunused-variable] static struct i2c_driver rt5663_i2c_driver = { ^ cc1: some warnings being treated as errors make[4]: *** [/kisskb/src/scripts/Makefile.build:276: sound/soc/codecs/rt5663.o] Error 1 make[3]: *** [/kisskb/src/scripts/Makefile.build:486: sound/soc/codecs] Error 2 make[2]: *** [/kisskb/src/scripts/Makefile.build:486: sound/soc] Error 2 make[1]: *** [/kisskb/src/Makefile:1051: sound] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/lib/test_objagg.c: In function 'test_hints_case.constprop': /kisskb/src/lib/test_objagg.c:994:1: warning: the frame size of 1056 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ make: *** [Makefile:169: sub-make] Error 2 Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-gcc5 # Build took: 0:00:46.908272