Buildresult: crypto/x86_64-allnoconfig/x86_64-gcc4.6 built on Apr 8 2019, 21:24

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Apr 8 2019, 21:24
Duration:	0:00:17.160892
Builder:	ka3
Revision:	crypto: x86/poly1305 - fix overflow during partial reduction (`678cce4019d746da6c680c48ba9e6d417803e127)`
Target:	crypto/x86_64-allnoconfig/x86_64-gcc4.6
Branch:	crypto
Compiler:	x86_64-gcc4.6 (x86_64-linux-gcc (GCC) 4.6.3 / GNU ld (GNU Binutils) 2.22)
Config:	allnoconfig (download)
Log:	Download original Possible warnings (3) kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] arch/x86/kernel/apic/io_apic.c:1036:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] arch/x86/kernel/e820.c:651:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Full Log # git rev-parse -q --verify 678cce4019d746da6c680c48ba9e6d417803e127^{commit} 678cce4019d746da6c680c48ba9e6d417803e127 already have revision, skipping fetch # git checkout -q -f -B kisskb 678cce4019d746da6c680c48ba9e6d417803e127 # git clean -qxdf # < git log -1 # commit 678cce4019d746da6c680c48ba9e6d417803e127 # Author: Eric Biggers <ebiggers@google.com> # Date: Sun Mar 31 13:04:11 2019 -0700 # # crypto: x86/poly1305 - fix overflow during partial reduction # # The x86_64 implementation of Poly1305 produces the wrong result on some # inputs because poly1305_4block_avx2() incorrectly assumes that when # partially reducing the accumulator, the bits carried from limb 'd4' to # limb 'h0' fit in a 32-bit integer. This is true for poly1305-generic # which processes only one block at a time. However, it's not true for # the AVX2 implementation, which processes 4 blocks at a time and # therefore can produce intermediate limbs about 4x larger. # # Fix it by making the relevant calculations use 64-bit arithmetic rather # than 32-bit. Note that most of the carries already used 64-bit # arithmetic, but the d4 -> h0 carry was different for some reason. # # To be safe I also made the same change to the corresponding SSE2 code, # though that only operates on 1 or 2 blocks at a time. I don't think # it's really needed for poly1305_block_sse2(), but it doesn't hurt # because it's already x86_64 code. It might be needed for # poly1305_2block_sse2(), but overflows aren't easy to reproduce there. # # This bug was originally detected by my patches that improve testmgr to # fuzz algorithms against their generic implementation. But also add a # test vector which reproduces it directly (in the AVX2 case). # # Fixes: b1ccc8f4b631 ("crypto: poly1305 - Add a four block AVX2 variant for x86_64") # Fixes: c70f4abef07a ("crypto: poly1305 - Add a SSE2 SIMD variant for x86_64") # Cc: <stable@vger.kernel.org> # v4.3+ # Cc: Martin Willi <martin@strongswan.org> # Cc: Jason A. Donenfeld <Jason@zx2c4.com> # Signed-off-by: Eric Biggers <ebiggers@google.com> # Reviewed-by: Martin Willi <martin@strongswan.org> # Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-ld --version # < git log --format=%s --max-count=1 678cce4019d746da6c680c48ba9e6d417803e127 # < make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # make -s -j 80 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1036:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:651:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64-gcc4.6 # Build took: 0:00:17.160892

© Michael Ellerman 2006-2018.