# git rev-parse -q --verify b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40^{commit} b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 already have revision, skipping fetch # git checkout -q -f -B kisskb b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # git clean -qxdf # < git log -1 # commit b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # Author: Nathan Fontenot # Date: Tue Oct 2 10:35:59 2018 -0500 # # powerpc/pseries: Track LMB nid instead of using device tree # # When removing memory we need to remove the memory from the node # it was added to instead of looking up the node it should be in # in the device tree. # # During testing we have seen scenarios where the affinity for a # LMB changes due to a partition migration or PRRN event. In these # cases the node the LMB exists in may not match the node the device # tree indicates it belongs in. This can lead to a system crash # when trying to DLPAR remove the LMB after a migration or PRRN # event. The current code looks up the node in the device tree to # remove the LMB from, the crash occurs when we try to offline this # node and it does not have any data, i.e. node_data[nid] == NULL. # # 36:mon> e # cpu 0x36: Vector: 300 (Data Access) at [c0000001828b7810] # pc: c00000000036d08c: try_offline_node+0x2c/0x1b0 # lr: c0000000003a14ec: remove_memory+0xbc/0x110 # sp: c0000001828b7a90 # msr: 800000000280b033 # dar: 9a28 # dsisr: 40000000 # current = 0xc0000006329c4c80 # paca = 0xc000000007a55200 softe: 0 irq_happened: 0x01 # pid = 76926, comm = kworker/u320:3 # # 36:mon> t # [link register ] c0000000003a14ec remove_memory+0xbc/0x110 # [c0000001828b7a90] c00000000006a1cc arch_remove_memory+0x9c/0xd0 (unreliable) # [c0000001828b7ad0] c0000000003a14e0 remove_memory+0xb0/0x110 # [c0000001828b7b20] c0000000000c7db4 dlpar_remove_lmb+0x94/0x160 # [c0000001828b7b60] c0000000000c8ef8 dlpar_memory+0x7e8/0xd10 # [c0000001828b7bf0] c0000000000bf828 handle_dlpar_errorlog+0xf8/0x160 # [c0000001828b7c60] c0000000000bf8cc pseries_hp_work_fn+0x3c/0xa0 # [c0000001828b7c90] c000000000128cd8 process_one_work+0x298/0x5a0 # [c0000001828b7d20] c000000000129068 worker_thread+0x88/0x620 # [c0000001828b7dc0] c00000000013223c kthread+0x1ac/0x1c0 # [c0000001828b7e30] c00000000000b45c ret_from_kernel_thread+0x5c/0x80 # # To resolve this we need to track the node a LMB belongs to when # it is added to the system so we can remove it from that node instead # of the node that the device tree indicates it should belong to. # # Signed-off-by: Nathan Fontenot # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-ld --version # < git log --format=%s --max-count=1 b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_ALTIVEC_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ppc64_defconfig # Added to kconfig CONFIG_ALTIVEC=n # Added to kconfig CONFIG_PPC_TRANSACTIONAL_MEM=n # yes \n | make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_ALTIVEC_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc64_defconfig+NO_ALTIVEC_powerpc-gcc4.6 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1435:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/futex.c: In function 'do_futex': /kisskb/src/kernel/futex.c:1658:3: warning: 'oldval' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/futex.c:1633:6: note: 'oldval' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec.isra.28': /kisskb/src/net/bridge/br_netlink.c:652:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2076:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/netfilter/nf_nat_masquerade.c:15:21: warning: 'masq_refcnt6' defined but not used [-Wunused-variable] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1842:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1755:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] WARNING: vmlinux.o(.text+0x3dc6): Section mismatch in reference from the variable start_here_multiplatform to the function .init.text:.early_setup() The function start_here_multiplatform() references the function __init .early_setup(). This is often because start_here_multiplatform lacks a __init annotation or the annotation of .early_setup is wrong. Completed OK # rm -rf /kisskb/build/powerpc-next_ppc64_defconfig+NO_ALTIVEC_powerpc-gcc4.6 # Build took: 0:03:00.964515