# git rev-parse -q --verify b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40^{commit} b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 already have revision, skipping fetch # git checkout -q -f -B kisskb b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # git clean -qxdf # < git log -1 # commit b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # Author: Nathan Fontenot # Date: Tue Oct 2 10:35:59 2018 -0500 # # powerpc/pseries: Track LMB nid instead of using device tree # # When removing memory we need to remove the memory from the node # it was added to instead of looking up the node it should be in # in the device tree. # # During testing we have seen scenarios where the affinity for a # LMB changes due to a partition migration or PRRN event. In these # cases the node the LMB exists in may not match the node the device # tree indicates it belongs in. This can lead to a system crash # when trying to DLPAR remove the LMB after a migration or PRRN # event. The current code looks up the node in the device tree to # remove the LMB from, the crash occurs when we try to offline this # node and it does not have any data, i.e. node_data[nid] == NULL. # # 36:mon> e # cpu 0x36: Vector: 300 (Data Access) at [c0000001828b7810] # pc: c00000000036d08c: try_offline_node+0x2c/0x1b0 # lr: c0000000003a14ec: remove_memory+0xbc/0x110 # sp: c0000001828b7a90 # msr: 800000000280b033 # dar: 9a28 # dsisr: 40000000 # current = 0xc0000006329c4c80 # paca = 0xc000000007a55200 softe: 0 irq_happened: 0x01 # pid = 76926, comm = kworker/u320:3 # # 36:mon> t # [link register ] c0000000003a14ec remove_memory+0xbc/0x110 # [c0000001828b7a90] c00000000006a1cc arch_remove_memory+0x9c/0xd0 (unreliable) # [c0000001828b7ad0] c0000000003a14e0 remove_memory+0xb0/0x110 # [c0000001828b7b20] c0000000000c7db4 dlpar_remove_lmb+0x94/0x160 # [c0000001828b7b60] c0000000000c8ef8 dlpar_memory+0x7e8/0xd10 # [c0000001828b7bf0] c0000000000bf828 handle_dlpar_errorlog+0xf8/0x160 # [c0000001828b7c60] c0000000000bf8cc pseries_hp_work_fn+0x3c/0xa0 # [c0000001828b7c90] c000000000128cd8 process_one_work+0x298/0x5a0 # [c0000001828b7d20] c000000000129068 worker_thread+0x88/0x620 # [c0000001828b7dc0] c00000000013223c kthread+0x1ac/0x1c0 # [c0000001828b7e30] c00000000000b45c ret_from_kernel_thread+0x5c/0x80 # # To resolve this we need to track the node a LMB belongs to when # it is added to the system so we can remove it from that node instead # of the node that the device tree indicates it should belong to. # # Signed-off-by: Nathan Fontenot # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < /opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux-ld --version # < git log --format=%s --max-count=1 b2d3b5ee66f2a04a918cc043cec0c9ed3de58f40 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- mpc85xx_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-5.5.0-nolibc/powerpc64-linux/bin/powerpc64-linux- :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] In file included from /kisskb/src/include/linux/kernel.h:11:0, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:15: /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/include/linux/err.h:22:49: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define IS_ERR_VALUE(x) unlikely((unsigned long)(void *)(x) >= (unsigned long)-MAX_ERRNO) ^ /kisskb/src/include/linux/compiler.h:77:42: note: in definition of macro 'unlikely' # define unlikely(x) __builtin_expect(!!(x), 0) ^ /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: note: in expansion of macro 'IS_ERR_VALUE' if (IS_ERR_VALUE(fep->ring_mem_addr)) ^ /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8541cds.dts:334.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) /kisskb/src/arch/powerpc/boot/dts/fsl/mpc8555cds.dts:334.3-21: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbc3830) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbb2ffc) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:11 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5793678 Bytes = 5657.89 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c00314 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5793102 Bytes = 5657.33 KiB = 5.52 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:11 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5764539 Bytes = 5629.43 KiB = 5.50 MiB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5794108 Bytes = 5658.31 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c00314 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5792966 Bytes = 5657.19 KiB = 5.52 MiB Load Address: 00c00000 Entry Point: 00c00314 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:11 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5792964 Bytes = 5657.19 KiB = 5.52 MiB Load Address: 00c00000 Entry Point: 00c00314 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5795527 Bytes = 5659.69 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5794653 Bytes = 5658.84 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5793098 Bytes = 5657.32 KiB = 5.52 MiB Load Address: 00c00000 Entry Point: 00c00314 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5795470 Bytes = 5659.64 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5794917 Bytes = 5659.10 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:12 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5793667 Bytes = 5657.88 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:13 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5794026 Bytes = 5658.23 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:13 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5792972 Bytes = 5657.20 KiB = 5.52 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:13 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5793664 Bytes = 5657.88 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Image Name: Linux-5.1.0-rc3-gb2d3b5ee66f2 Created: Tue Apr 30 01:52:13 2019 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5795352 Bytes = 5659.52 KiB = 5.53 MiB Load Address: 00c00000 Entry Point: 00c002a4 Completed OK # rm -rf /kisskb/build/powerpc-next_mpc85xx_defconfig_powerpc-gcc5 # Build took: 0:02:03.558778