# git rev-parse -q --verify 12f363511d47f86c49b7766c349989cb33fd61a8^{commit} 12f363511d47f86c49b7766c349989cb33fd61a8 already have revision, skipping fetch # git checkout -q -f -B kisskb 12f363511d47f86c49b7766c349989cb33fd61a8 # git clean -qxdf # < git log -1 # commit 12f363511d47f86c49b7766c349989cb33fd61a8 # Author: Christophe Leroy # Date: Tue Apr 30 16:11:59 2019 +0000 # # powerpc/32s: Fix BATs setting with CONFIG_STRICT_KERNEL_RWX # # Serge reported some crashes with CONFIG_STRICT_KERNEL_RWX enabled # on a book3s32 machine. # # Analysis shows two issues: # - BATs addresses and sizes are not properly aligned. # - There is a gap between the last address covered by BATs and the # first address covered by pages. # # Memory mapped with DBATs: # 0: 0xc0000000-0xc07fffff 0x00000000 Kernel RO coherent # 1: 0xc0800000-0xc0bfffff 0x00800000 Kernel RO coherent # 2: 0xc0c00000-0xc13fffff 0x00c00000 Kernel RW coherent # 3: 0xc1400000-0xc23fffff 0x01400000 Kernel RW coherent # 4: 0xc2400000-0xc43fffff 0x02400000 Kernel RW coherent # 5: 0xc4400000-0xc83fffff 0x04400000 Kernel RW coherent # 6: 0xc8400000-0xd03fffff 0x08400000 Kernel RW coherent # 7: 0xd0400000-0xe03fffff 0x10400000 Kernel RW coherent # # Memory mapped with pages: # 0xe1000000-0xefffffff 0x21000000 240M rw present dirty accessed # # This patch fixes both issues. With the patch, we get the following # which is as expected: # # Memory mapped with DBATs: # 0: 0xc0000000-0xc07fffff 0x00000000 Kernel RO coherent # 1: 0xc0800000-0xc0bfffff 0x00800000 Kernel RO coherent # 2: 0xc0c00000-0xc0ffffff 0x00c00000 Kernel RW coherent # 3: 0xc1000000-0xc1ffffff 0x01000000 Kernel RW coherent # 4: 0xc2000000-0xc3ffffff 0x02000000 Kernel RW coherent # 5: 0xc4000000-0xc7ffffff 0x04000000 Kernel RW coherent # 6: 0xc8000000-0xcfffffff 0x08000000 Kernel RW coherent # 7: 0xd0000000-0xdfffffff 0x10000000 Kernel RW coherent # # Memory mapped with pages: # 0xe0000000-0xefffffff 0x20000000 256M rw present dirty accessed # # Fixes: 63b2bc619565 ("powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX") # Reported-by: Serge Belyshev # Acked-by: Segher Boessenkool # Signed-off-by: Christophe Leroy # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-ld --version # < git log --format=%s --max-count=1 12f363511d47f86c49b7766c349989cb33fd61a8 # < make -s -j 10 ARCH=mips O=/kisskb/build/powerpc-fixes_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 10 ARCH=mips O=/kisskb/build/powerpc-fixes_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:39: MIPS VDSO requires binutils >= 2.25 :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/arch/mips/vdso/Makefile:39: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:140:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:88:6: note: 'levelspread[]' was declared here /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1855:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2594:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:337:21: note: 'pdeo' was declared here /kisskb/src/drivers/i2c/i2c-core-base.c: In function 'i2c_generic_scl_recovery': /kisskb/src/drivers/i2c/i2c-core-base.c:235:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c: In function 'xs_read_stream_request.constprop.17': /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'read' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sunrpc/xprtsock.c:529:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/fs_parser.c: In function 'fs_validate_description': /kisskb/src/fs/fs_parser.c:413:6: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'int' [-Wformat] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:247:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:227:19: note: 'i' was declared here :1478:2: warning: #warning syscall pidfd_send_signal not implemented [-Wcpp] :1481:2: warning: #warning syscall io_uring_setup not implemented [-Wcpp] :1484:2: warning: #warning syscall io_uring_enter not implemented [-Wcpp] :1487:2: warning: #warning syscall io_uring_register not implemented [-Wcpp] /kisskb/src/arch/mips/vdso/Makefile:39: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:187:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] FIT description: Linux 5.1.0-rc2-g12f363511d47 Created: Thu May 2 17:32:13 2019 Image 0 (kernel@0) Description: Linux 5.1.0-rc2-g12f363511d47 Created: Thu May 2 17:32:13 2019 Type: Kernel Image Compression: gzip compressed Data Size: 4370884 Bytes = 4268.44 KiB = 4.17 MiB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8081dbd0 Hash algo: sha1 Hash value: d3818a132e7a6a2b8e22dd5d35affe04c397c6e5 Image 1 (fdt@boston) Description: img,boston Device Tree Created: Thu May 2 17:32:13 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 3793 Bytes = 3.70 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 4799f50d688573234da6e9d7701234d394759ef4 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Thu May 2 17:32:13 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Thu May 2 17:32:13 2019 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 KiB = 0.00 MiB Architecture: MIPS Hash algo: sha1 Hash value: 63d058b780f65e22da30f0a183433765f1807f1d Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/powerpc-fixes_mips-defconfig_mips # Build took: 0:01:33.997459